From: John Ogness <john.ogness@linutronix.de>
To: Masahiro Yamada <masahiroy@kernel.org>,
linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH 3/3] printk: move CONSOLE_EXT_LOG_MAX to kernel/printk/printk.c
Date: Tue, 02 Feb 2021 09:50:54 +0106 [thread overview]
Message-ID: <87bld22709.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20210202070218.856847-3-masahiroy@kernel.org>
On 2021-02-02, Masahiro Yamada <masahiroy@kernel.org> wrote:
> This macro is only used in kernel/printk/printk.c
I recently posted a patch [0] that added another macro CONSOLE_LOG_MAX
here. But it also is only used in printk.c. I see no reason why either
should be in the header. Neither my patch nor commit d43ff430f434
("printk: guard the amount written per line by devkmsg_read()") show any
motivation for using printk.h.
I am fine with moving them out. The only consequences could be
out-of-tree modules breaking, but do we care about that?
John Ogness
[0] https://lkml.kernel.org/r/20210126211551.26536-5-john.ogness@linutronix.de
next prev parent reply other threads:[~2021-02-02 8:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 7:02 [PATCH 1/3] printk: use CONFIG_CONSOLE_LOGLEVEL_* directly Masahiro Yamada
2021-02-02 7:02 ` Masahiro Yamada
2021-02-02 7:02 ` [PATCH 2/3] printk: hard-code CONSOLE_LOGLEVEL_MIN in printk.c Masahiro Yamada
2021-02-02 10:06 ` Sergey Senozhatsky
2021-02-02 12:51 ` Joe Perches
2021-02-02 7:02 ` [PATCH 3/3] printk: move CONSOLE_EXT_LOG_MAX to kernel/printk/printk.c Masahiro Yamada
2021-02-02 8:44 ` John Ogness [this message]
2021-02-02 10:04 ` Sergey Senozhatsky
2021-02-02 12:29 ` kernel test robot
2021-02-02 12:29 ` kernel test robot
2021-02-03 13:59 ` Petr Mladek
2021-02-03 13:59 ` Petr Mladek
2021-02-02 8:38 ` [PATCH 1/3] printk: use CONFIG_CONSOLE_LOGLEVEL_* directly John Ogness
2021-02-02 8:38 ` John Ogness
2021-02-03 15:23 ` Petr Mladek
2021-02-03 15:23 ` Petr Mladek
2021-02-03 21:51 ` Masahiro Yamada
2021-02-03 21:51 ` Masahiro Yamada
2021-02-04 10:16 ` Petr Mladek
2021-02-04 10:16 ` Petr Mladek
2021-02-02 10:09 ` Sergey Senozhatsky
2021-02-02 10:09 ` Sergey Senozhatsky
2021-02-02 23:04 ` Masahiro Yamada
2021-02-02 23:04 ` Masahiro Yamada
2021-02-02 10:12 ` Greg Kroah-Hartman
2021-02-02 10:12 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bld22709.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.