From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54C8DC433E0 for ; Fri, 29 Jan 2021 15:28:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D20CD60C3D for ; Fri, 29 Jan 2021 15:28:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D20CD60C3D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SHNO97ebNwh82EPU7TuWnc4RLgeEDMFomh+tlsSHMXU=; b=K55nypwRaEuc+5YDtBAbdnUzBL Sg4QdLoxiUelrvYwxN49Mxv+PjSFsdfab0rC79P59/QsdIGcr9HD3kFPZVJz4YBXVFqUZkdikAW5j ed1i4rZLukLzxWvby68PTg+F5KRArr4n/S+8S9he1YNG7CMsblzvdMnHz0g1dRKAxPjJ0loRGKAnK I56TBsHDaq+zJXP5GsDXA/R9Sv5RYUEG+816I8xF5yjQ+B1lI9NicLTXr6lOOm+mnnpoNVdOwehsH fYp3TY+Kb9kIM4CgnnMNx0tEDyy1uIjE2m+m2klWPJg1DmrOnuI2t6G/J8ho08QhfmHkpwnhVYTv2 dtS/gzuA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5VgX-0004PB-87; Fri, 29 Jan 2021 15:27:45 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5VgU-0004OK-V7 for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 15:27:44 +0000 X-Originating-IP: 90.65.91.141 Received: from localhost (lfbn-lyo-1-1912-141.w90-65.abo.wanadoo.fr [90.65.91.141]) (Authenticated sender: gregory.clement@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 578201C0005; Fri, 29 Jan 2021 15:27:40 +0000 (UTC) From: Gregory CLEMENT To: Rosen Penev , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: dts: armada388-helios4: assign pinctrl to LEDs In-Reply-To: <20201203022321.19952-1-rosenp@gmail.com> References: <20201203022321.19952-1-rosenp@gmail.com> Date: Fri, 29 Jan 2021 16:27:40 +0100 Message-ID: <87bld7u5jn.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_102743_112056_4BE47096 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rosen, > Split up the pins to match earlier definitions. Allows LEDs to flash > properly. > > Fixes: ced8025b569e ("ARM: dts: armada388-helios4") > > Signed-off-by: Rosen Penev Applied on mvebu/dt Thanks, Gregory > --- > arch/arm/boot/dts/armada-388-helios4.dts | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/armada-388-helios4.dts b/arch/arm/boot/dts/armada-388-helios4.dts > index b3728de3bd3f..5a6af7e83e44 100644 > --- a/arch/arm/boot/dts/armada-388-helios4.dts > +++ b/arch/arm/boot/dts/armada-388-helios4.dts > @@ -70,6 +70,9 @@ > > system-leds { > compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&helios_system_led_pins>; > + > status-led { > label = "helios4:green:status"; > gpios = <&gpio0 24 GPIO_ACTIVE_LOW>; > @@ -86,6 +89,9 @@ > > io-leds { > compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&helios_io_led_pins>; > + > sata1-led { > label = "helios4:green:ata1"; > gpios = <&gpio1 17 GPIO_ACTIVE_LOW>; > @@ -286,9 +292,12 @@ > "mpp39", "mpp40"; > marvell,function = "sd0"; > }; > - helios_led_pins: helios-led-pins { > - marvell,pins = "mpp24", "mpp25", > - "mpp49", "mpp50", > + helios_system_led_pins: helios-system-led-pins { > + marvell,pins = "mpp24", "mpp25"; > + marvell,function = "gpio"; > + }; > + helios_io_led_pins: helios-io-led-pins { > + marvell,pins = "mpp49", "mpp50", > "mpp52", "mpp53", > "mpp54"; > marvell,function = "gpio"; > -- > 2.17.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel