From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36287C43217 for ; Tue, 19 Jan 2021 18:27:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 186E422CAD for ; Tue, 19 Jan 2021 18:27:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730577AbhASQfC (ORCPT ); Tue, 19 Jan 2021 11:35:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:52060 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731808AbhASQe5 (ORCPT ); Tue, 19 Jan 2021 11:34:57 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D0D53AE55; Tue, 19 Jan 2021 16:34:15 +0000 (UTC) References: <20210119093143.17222-1-rpalethorpe@suse.com> <20210119093143.17222-5-rpalethorpe@suse.com> <322f1056-0a73-65e6-531a-3275029df256@pengutronix.de> <3277a88e-0301-7f3d-b024-c728e1041092@pengutronix.de> User-agent: mu4e 1.4.14; emacs 27.1 From: Richard Palethorpe To: Marc Kleine-Budde Cc: Cyril Hrubis , ltp@lists.linux.it, Oliver Hartkopp , linux-can@vger.kernel.org Subject: Re: [LTP] [PATCH v2 4/6] can_recv_own_msgs: Convert to new library Reply-To: rpalethorpe@suse.de In-reply-to: <3277a88e-0301-7f3d-b024-c728e1041092@pengutronix.de> Date: Tue, 19 Jan 2021 16:34:14 +0000 Message-ID: <87bldkq41l.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hello All, Marc Kleine-Budde writes: > On 1/19/21 4:06 PM, Cyril Hrubis wrote: >> Hi! >>>> /* >>>> - * tst-rcv-own-msgs.c >>>> - * >>>> - * Copyright (c) 2010 Volkswagen Group Electronic Research >>>> - * All rights reserved. >>>> - * >>>> - * Redistribution and use in source and binary forms, with or without >>>> - * modification, are permitted provided that the following conditions >>>> - * are met: >>>> - * 1. Redistributions of source code must retain the above copyright >>>> - * notice, this list of conditions and the following disclaimer. >>>> - * 2. Redistributions in binary form must reproduce the above copyright >>>> - * notice, this list of conditions and the following disclaimer in the >>>> - * documentation and/or other materials provided with the distribution. >>>> - * 3. Neither the name of Volkswagen nor the names of its contributors >>>> - * may be used to endorse or promote products derived from this software >>>> - * without specific prior written permission. >>> >>> IANAL, I think you're missing this license. Is looks like some sort >>> of BSD to me. Ufff, thanks, I should pay more attention when it is a test imported from elsewhere. >>> >>>> - * >>>> - * Alternatively, provided that this notice is retained in full, this >>>> - * software may be distributed under the terms of the GNU General >>>> - * Public License ("GPL") version 2, in which case the provisions of the >>>> - * GPL apply INSTEAD OF those given above. >>> >>> It doesn't say "or later". >> >> Looks like we cannot just remove this license. So what about moving this >> text into a separate COPYING file and changing the SPDX to GPL-v2.0? > > This file is dual licensed, better keep it dual licensed. > > regards, > Marc HHmm, this appears to be the BSD-3-Clause license with the following text inserted in the middle: * Alternatively, provided that this notice is retained in full, this * software may be distributed under the terms of the GNU General * Public License ("GPL") version 2, in which case the provisions of the * GPL apply INSTEAD OF those given above. * * The provided data structures and external interfaces from this code * are not restricted to be used by modules with a GPL compatible license. I don't see any corresponding SPDX identifier or exception for this. It is probably easiest and safest just to keep it as-is. -- Thank you, Richard. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Palethorpe Date: Tue, 19 Jan 2021 16:34:14 +0000 Subject: [LTP] [PATCH v2 4/6] can_recv_own_msgs: Convert to new library In-Reply-To: <3277a88e-0301-7f3d-b024-c728e1041092@pengutronix.de> References: <20210119093143.17222-1-rpalethorpe@suse.com> <20210119093143.17222-5-rpalethorpe@suse.com> <322f1056-0a73-65e6-531a-3275029df256@pengutronix.de> <3277a88e-0301-7f3d-b024-c728e1041092@pengutronix.de> Message-ID: <87bldkq41l.fsf@suse.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hello All, Marc Kleine-Budde writes: > On 1/19/21 4:06 PM, Cyril Hrubis wrote: >> Hi! >>>> /* >>>> - * tst-rcv-own-msgs.c >>>> - * >>>> - * Copyright (c) 2010 Volkswagen Group Electronic Research >>>> - * All rights reserved. >>>> - * >>>> - * Redistribution and use in source and binary forms, with or without >>>> - * modification, are permitted provided that the following conditions >>>> - * are met: >>>> - * 1. Redistributions of source code must retain the above copyright >>>> - * notice, this list of conditions and the following disclaimer. >>>> - * 2. Redistributions in binary form must reproduce the above copyright >>>> - * notice, this list of conditions and the following disclaimer in the >>>> - * documentation and/or other materials provided with the distribution. >>>> - * 3. Neither the name of Volkswagen nor the names of its contributors >>>> - * may be used to endorse or promote products derived from this software >>>> - * without specific prior written permission. >>> >>> IANAL, I think you're missing this license. Is looks like some sort >>> of BSD to me. Ufff, thanks, I should pay more attention when it is a test imported from elsewhere. >>> >>>> - * >>>> - * Alternatively, provided that this notice is retained in full, this >>>> - * software may be distributed under the terms of the GNU General >>>> - * Public License ("GPL") version 2, in which case the provisions of the >>>> - * GPL apply INSTEAD OF those given above. >>> >>> It doesn't say "or later". >> >> Looks like we cannot just remove this license. So what about moving this >> text into a separate COPYING file and changing the SPDX to GPL-v2.0? > > This file is dual licensed, better keep it dual licensed. > > regards, > Marc HHmm, this appears to be the BSD-3-Clause license with the following text inserted in the middle: * Alternatively, provided that this notice is retained in full, this * software may be distributed under the terms of the GNU General * Public License ("GPL") version 2, in which case the provisions of the * GPL apply INSTEAD OF those given above. * * The provided data structures and external interfaces from this code * are not restricted to be used by modules with a GPL compatible license. I don't see any corresponding SPDX identifier or exception for this. It is probably easiest and safest just to keep it as-is. -- Thank you, Richard.