From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85990C64E8A for ; Mon, 30 Nov 2020 13:56:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F6A72084C for ; Mon, 30 Nov 2020 13:56:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726863AbgK3N4L convert rfc822-to-8bit (ORCPT ); Mon, 30 Nov 2020 08:56:11 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:46469 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726841AbgK3N4K (ORCPT ); Mon, 30 Nov 2020 08:56:10 -0500 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 637D9440A96; Mon, 30 Nov 2020 15:55:28 +0200 (IST) References: <20201130135130.rynozhii4yfxtmdh@pengutronix.de> User-agent: mu4e 1.4.13; emacs 27.1 From: Baruch Siach To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Thierry Reding , Lee Jones , Linus Walleij , Bartosz Golaszewski , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Petazzoni , Chris Packham , Sascha Hauer , Ralph Sennhauser , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] gpio: mvebu: fix potential user-after-free on probe In-reply-to: <20201130135130.rynozhii4yfxtmdh@pengutronix.de> Date: Mon, 30 Nov 2020 15:55:28 +0200 Message-ID: <87blffdk4v.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Uwe, On Mon, Nov 30 2020, Uwe Kleine-König wrote: > On Mon, Nov 30, 2020 at 03:33:23PM +0200, Baruch Siach wrote: >> When mvebu_pwm_probe() fails IRQ domain is not released. Move >> mvebu_pwm_probe() before IRQ domain registration. > > And now if something with IRQ domain registration fails the pwm stuff > isn't freed? As far as I can see mvebu_pwm_probe() uses devres exclusively to allocate resources. baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4B29C64E7B for ; Mon, 30 Nov 2020 13:56:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C4802076E for ; Mon, 30 Nov 2020 13:56:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CxE8tKw8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C4802076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S4DZE25vvz5Debq/FzWMekvb37W5LVuvXB9yNyqwF1s=; b=CxE8tKw8uU3U4GDWWvZJL7UJs qH+ZzvQ+WABG4l+6A0Pv0pJcHtKoScRWyEf2VAqp1OiKQfwSTaBwxfnPrPasonPD6TjsWFksmvTD4 8FPb0wHejwr/NhW1N2oyP+xzk53uLVAhaDzdM7U4wN13zKzcRda6dZtzVqpvx8Y25wXV+2kaGB+NJ AchWzQWxIwLcQMCZiJ9pR8wEI8CtqOzgc46bcT3GAtBZOCLnvXiCJpumu5KTi+eYwL+tK2h3bEO1b ExUp0dfecxLBtfLKqWj/4PYi0WQnnK16OWXbE8cAtrMu2ENZ6rywaW4zY+koLJyKNXpjKD+hV6LbM DPt4XyfhQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjjeS-0008B8-1W; Mon, 30 Nov 2020 13:55:36 +0000 Received: from guitar.tcltek.co.il ([192.115.133.116] helo=mx.tkos.co.il) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjjeM-000899-CP for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 13:55:32 +0000 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 637D9440A96; Mon, 30 Nov 2020 15:55:28 +0200 (IST) References: <20201130135130.rynozhii4yfxtmdh@pengutronix.de> User-agent: mu4e 1.4.13; emacs 27.1 From: Baruch Siach To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH] gpio: mvebu: fix potential user-after-free on probe In-reply-to: <20201130135130.rynozhii4yfxtmdh@pengutronix.de> Date: Mon, 30 Nov 2020 15:55:28 +0200 Message-ID: <87blffdk4v.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_085530_655142_3D92E77B X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sascha Hauer , linux-pwm@vger.kernel.org, Linus Walleij , Chris Packham , Bartosz Golaszewski , Thierry Reding , Thomas Petazzoni , linux-gpio@vger.kernel.org, Ralph Sennhauser , Lee Jones , Gregory Clement , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVXdlLAoKT24gTW9uLCBOb3YgMzAgMjAyMCwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4g T24gTW9uLCBOb3YgMzAsIDIwMjAgYXQgMDM6MzM6MjNQTSArMDIwMCwgQmFydWNoIFNpYWNoIHdy b3RlOgo+PiBXaGVuIG12ZWJ1X3B3bV9wcm9iZSgpIGZhaWxzIElSUSBkb21haW4gaXMgbm90IHJl bGVhc2VkLiBNb3ZlCj4+IG12ZWJ1X3B3bV9wcm9iZSgpIGJlZm9yZSBJUlEgZG9tYWluIHJlZ2lz dHJhdGlvbi4KPgo+IEFuZCBub3cgaWYgc29tZXRoaW5nIHdpdGggSVJRIGRvbWFpbiByZWdpc3Ry YXRpb24gZmFpbHMgdGhlIHB3bSBzdHVmZgo+IGlzbid0IGZyZWVkPwoKQXMgZmFyIGFzIEkgY2Fu IHNlZSBtdmVidV9wd21fcHJvYmUoKSB1c2VzIGRldnJlcyBleGNsdXNpdmVseSB0bwphbGxvY2F0 ZSByZXNvdXJjZXMuCgpiYXJ1Y2gKCi0tIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIH4uIC5+ICAgVGsgT3BlbiBTeXN0ZW1zCj19LS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tb29PLS1VLS1Pb28tLS0tLS0t LS0tLS17PQogICAtIGJhcnVjaEB0a29zLmNvLmlsIC0gdGVsOiArOTcyLjUyLjM2OC40NjU2LCBo dHRwOi8vd3d3LnRrb3MuY28uaWwgLQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=