All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Alexander Graf <graf@amazon.com>, X86 ML <x86@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Alexandre Chartre <alexandre.chartre@oracle.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <sean.j.christopherson@intel.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Petr Mladek <pmladek@suse.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Will Deacon <will@kernel.org>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Wei Liu <wei.liu@kernel.org>,
	Michael Kelley <mikelley@microsoft.com>,
	Jason Chen CJ <jason.cj.chen@intel.com>,
	Zhao Yakui <yakui.zhao@intel.com>,
	"Peter Zijlstra \(Intel\)" <peterz@infradead.org>,
	Avi Kivity <avi@scylladb.com>, "Herrenschmidt\,
	Benjamin" <benh@amazon.com>,
	robketr@amazon.de, amos@scylladb.com,
	Brian Gerst <brgerst@gmail.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] x86/irq: Preserve vector in orig_ax for APIC code
Date: Wed, 26 Aug 2020 20:30:25 +0200	[thread overview]
Message-ID: <87blixuuny.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <fd87a87d-7d8a-9959-6c81-f49003a43c21@amazon.com>

On Wed, Aug 26 2020 at 18:33, Alexander Graf wrote:
> On 26.08.20 16:27, Thomas Gleixner wrote:
>> The below nasty hack cures it, but I hate it with a passion. I'll look
>> deeper for a sane variant.
>
> An alternative (that doesn't make the code easier to read, but would fix 
> the issue at hand) would be touse a pushq imm16 with vector | 0x8000 
> instead to always make the value negative, no?

Which makes each entry larger than 8 byte which was frowned upon before.

And it does not solve the issue that we abuse orig_ax which Andy
mentioned.

Thanks,

        tglx

  reply	other threads:[~2020-08-26 18:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 11:53 [PATCH] x86/irq: Preserve vector in orig_ax for APIC code Alexander Graf
2020-08-26 13:22 ` Josh Poimboeuf
2020-08-26 13:51   ` Alexander Graf
2020-08-26 14:27 ` Thomas Gleixner
2020-08-26 16:13   ` Andy Lutomirski
2020-08-26 17:47     ` Thomas Gleixner
2020-08-26 18:00       ` Andy Lutomirski
2020-08-26 18:22         ` Graf (AWS), Alexander
2020-08-26 16:33   ` Alexander Graf
2020-08-26 18:30     ` Thomas Gleixner [this message]
2020-08-26 18:53       ` Thomas Gleixner
2020-08-26 20:09         ` Alexander Graf
2020-08-26 20:21         ` x86/irq: Unbreak interrupt affinity setting Thomas Gleixner
2020-08-26 21:37           ` David Laight
2020-08-26 21:47             ` David Laight
2020-08-26 22:52               ` Alexander Graf
2020-08-27  8:31                 ` David Laight
2020-08-26 22:07             ` Thomas Gleixner
2020-08-27  8:28               ` David Laight
2020-08-27  7:32           ` [tip: x86/urgent] " tip-bot2 for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blixuuny.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=alexandre.chartre@oracle.com \
    --cc=amos@scylladb.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=avi@scylladb.com \
    --cc=benh@amazon.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=brgerst@gmail.com \
    --cc=frederic@kernel.org \
    --cc=graf@amazon.com \
    --cc=jason.cj.chen@intel.com \
    --cc=jgross@suse.com \
    --cc=joel@joelfernandes.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=paulmck@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=robketr@amazon.de \
    --cc=rostedt@goodmis.org \
    --cc=sean.j.christopherson@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=wei.liu@kernel.org \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.