From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F8DC433E2 for ; Tue, 21 Jul 2020 09:44:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C17752072E for ; Tue, 21 Jul 2020 09:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595324648; bh=dRBqRpPHLqQ+YiVHyYwy7/iduBS4RS42lBSIgjREvkc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-ID:From; b=TrnEfprbHKMibbcJmqgzD7Qw1CZP8e1cgst1PpxUtYEylrs/ctehsxexyYov2jfpS AvWJimywTNEmmR2KRk0dX+4VNOJtoEjy0SUOweyOqci34U88dGlJnTzBRxPmhVWHU3 sTvDEHRMIEOl7GiQBcCM3F3NPMta246eUMacErlI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728006AbgGUJoF (ORCPT ); Tue, 21 Jul 2020 05:44:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbgGUJoE (ORCPT ); Tue, 21 Jul 2020 05:44:04 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 661B6C061794; Tue, 21 Jul 2020 02:44:04 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id q6so2346748ljp.4; Tue, 21 Jul 2020 02:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=4B4uTKaYVVIs2NUU7WSS3PrxtkG5yE1ho1vSzkWNNJY=; b=pdJRleq1eaXiymciRCaJyMpEjyPf0ED+Y0ls4trEfLYY1pCXRP0dEAYl7GKpTZrGN5 4GCC1/QU/PadIe17M5/f5otVVm34IdsMKlFm0E53OJ7M/CMFib65tcxSgVcwPbY669Tq 8ffyI9mQksGVgB9Mh2FJGtMdH0DRHXCI6GQGp3JL3k+bOa5AKg+Ww3F7MPO4prHB+Jl2 Gy/ZBuJKzVJ2p6EVq/HKKEKesmnzGdFI5P4H7gfxBOMgydhnzEFXTglpA5n/nhtz+V81 cZSZl1i31a2GiehcPueTGiGw+nYK7dUYaXhwXVWH83GmBnPWKRNoxtayXR2kQrU60a0w vXsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :date:message-id:mime-version; bh=4B4uTKaYVVIs2NUU7WSS3PrxtkG5yE1ho1vSzkWNNJY=; b=uZFeVN/WTEr6f7t7z0YJvXzvANQFZgIS0hwc9F0EPF1oat082YUBowKF7JjTPMK9zU smcMC/tsG4HQ8ju06Yuc1VXRSgsEkdp2pLlCFnznN/q43Fb0WIhuaeOt6zDGcwCmBMEm tt0Wobv3v/QOpgzzMcUKJ2UR/93oo0Hw9bjS5XuFY0Vq6Ah2e3ONEFif681AHhXIU/8V IP0NpeafpFG9NULQvCQpU0X+ijlA2VZtbdaC7hv3jfNKlJOle1b1r4FnvMBGPlob3AMR TLo3TXp9Hu099Ea8hRgNA71JeDCeksFUKBc3MzbwTqNRmfZVmajsxvbdDZ1+Lm9mVgfu xE0A== X-Gm-Message-State: AOAM5306UMv/DUUBnf54K896/tFmtiNGDhKJHxfRE4S75FTGyMAYPoV2 4pHcD3c8WMgDWKv1qeFCzaHCfj4aqMTgLA== X-Google-Smtp-Source: ABdhPJzhA3jW9y1U/VHRqB2+TAhq8vBgv7fDywrgkTgJmnvYz3ND+eXb6bTGt9vwJhd+hEJYMucSKQ== X-Received: by 2002:a2e:8597:: with SMTP id b23mr11438006lji.338.1595324642702; Tue, 21 Jul 2020 02:44:02 -0700 (PDT) Received: from saruman (91-155-214-58.elisa-laajakaista.fi. [91.155.214.58]) by smtp.gmail.com with ESMTPSA id r22sm4192790ljc.25.2020.07.21.02.44.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Jul 2020 02:44:02 -0700 (PDT) From: Felipe Balbi To: Minas Harutyunyan , Lee Jones , "gregkh\@linuxfoundation.org" Cc: "linux-arm-kernel\@lists.infradead.org" , "linux-kernel\@vger.kernel.org" , "linux-usb\@vger.kernel.org" , Ben Dooks Subject: Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2 In-Reply-To: <566f2d65-1b5a-ed2a-f33f-516b66be2624@synopsys.com> References: <20200715093209.3165641-1-lee.jones@linaro.org> <20200715093209.3165641-2-lee.jones@linaro.org> <566f2d65-1b5a-ed2a-f33f-516b66be2624@synopsys.com> Date: Tue, 21 Jul 2020 12:43:57 +0300 Message-ID: <87blk9p5ia.fsf@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Minas Harutyunyan writes: > On 7/15/2020 1:32 PM, Lee Jones wrote: >> The value obtained from GINTSTS2 should be masked with the GINTMSK2 >> value. Looks like this has been broken since >> dwc2_gadget_wkup_alert_handler() was added back in 2018. >>=20 >> Also fixes the following W=3D1 warning: >>=20 >> drivers/usb/dwc2/gadget.c: In function =E2=80=98dwc2_gadget_wkup_alert= _handler=E2=80=99: >> drivers/usb/dwc2/gadget.c:259:6: warning: variable =E2=80=98gintmsk2= =E2=80=99 set but not used [-Wunused-but-set-variable] >> 259 | u32 gintmsk2; >> | ^~~~~~~~ >>=20 >> Cc: Minas Harutyunyan >> Cc: Ben Dooks >> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert inte= rrupt") >> Signed-off-by: Lee Jones > > Acked-by: Minas Harutyunyan Should I apply the entire series or only 1/8? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl8WuN0ACgkQzL64meEa mQacAQ//a/P5SYnBnlVVnSmY6/+H5xaTyA0frND1g+cvwxNLc8oWt8WK97bow8mn gHNkRsPUfur72sCbsHhbOczv7Kc2ea3d+0KJNTv0idAgr8zUG0we/lYewX7+YCDc x911DeDk19uqC84Xbt9LmC9iBJbqPA+IlzckS2CwunqNws57n01+/p+txsNOEwXc EfCJBfEljT+W8u+yoeAu2FDdL3etFHZuIEE/aSLYC5qTqtM8dnUcoci0NDb3J+If uhJ0U0E8S9u3D8vGaL78cZHvMCvY6C4NLj+CdwkTFIGh3wx0uYSyOGnvrd2mlupS UV0oUqJj6vqDZ0MjpUYpAYd9tqSiucigXy13vId9QOSgTGsVKYNHevUlUOLq8lYC q29fZ4qNprDyKdc/JRuzkqanRqVfP7+HArMOXajAbCb1Qbk+qoYp12LuDs4yFWBW cBe1/yy9ItxJAjp7oMBiuMsjWdn/Di7mf3HMt5fTti0jNptDq1BPGsksUudJ656I OewK0YelUC6ptvxRfE4YwI7MUoG5EciU9tonBpFGkU2euzs6VrIpIF9haDIKEuC8 8eafrA9+yamuhElBP0xix/Bbif/Lk6oxK6yXVIwdB5qCNEgHRPjLzDEQykO1QBwp BMykpU5UXXpdqYD9kuT3k/hHTLq8GeO2o3bHVWoWZTvw7ZumzMk= =1ehQ -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04544C433E0 for ; Tue, 21 Jul 2020 09:45:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBDA22065D for ; Tue, 21 Jul 2020 09:45:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XL8ibw0X"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pdJRleq1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBDA22065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mL5DTpWFr2hGpLmucwp3qF8giaoDM4ZbWVcCk4ukCKs=; b=XL8ibw0X9oymr2sQeuOPw19Mf lJkJzLzdqGNaX1TPN7QzQcQjB10ugNhLdwGx9Vtu11YThxATkk03mBr4wVzLQ78iRpW3D/VtsnEwV BwLt3dODLUJisHxJBjqfrBcdx5lenu6V5gvBWw2LjDzUWB0W3HU4bYTY2KGM9HJh0bD9Tl1S8bjZq DcjRujIv/F3GSsX/inBoE4ukotQ41JI4tz2wMFsuAO7lnXR4Rvi5uZQvGSH0fmv3vOIRCwn+EEn3P MHR0bpQv468BGkawI71+hFqKYO31vVY22wEX6d42XvUhlnKDYSX/SAZ/FwWcLDyfMQkI0VTex3CW7 +Gf9eLmbA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxooh-00023a-Tc; Tue, 21 Jul 2020 09:44:07 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxooe-00022f-GO for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2020 09:44:05 +0000 Received: by mail-lj1-x242.google.com with SMTP id x9so23345205ljc.5 for ; Tue, 21 Jul 2020 02:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=4B4uTKaYVVIs2NUU7WSS3PrxtkG5yE1ho1vSzkWNNJY=; b=pdJRleq1eaXiymciRCaJyMpEjyPf0ED+Y0ls4trEfLYY1pCXRP0dEAYl7GKpTZrGN5 4GCC1/QU/PadIe17M5/f5otVVm34IdsMKlFm0E53OJ7M/CMFib65tcxSgVcwPbY669Tq 8ffyI9mQksGVgB9Mh2FJGtMdH0DRHXCI6GQGp3JL3k+bOa5AKg+Ww3F7MPO4prHB+Jl2 Gy/ZBuJKzVJ2p6EVq/HKKEKesmnzGdFI5P4H7gfxBOMgydhnzEFXTglpA5n/nhtz+V81 cZSZl1i31a2GiehcPueTGiGw+nYK7dUYaXhwXVWH83GmBnPWKRNoxtayXR2kQrU60a0w vXsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :date:message-id:mime-version; bh=4B4uTKaYVVIs2NUU7WSS3PrxtkG5yE1ho1vSzkWNNJY=; b=HAnlBQgXNz0n68q6QxQukUcSSVuEDpm2Vjar5nA5PpffrILyERsxEVDEuo2s+hpgpe +d3XRsVBeiyOVw46MgPfDnJPZ1/OPxNjACnf7zSGynrUgGqti54aOI0j/FUOnVevh2zp FNVOHONYyp882/sWe/szEKrrwgCBspTwtcxfPLI1k59YQrjGaRSpZsV3jy20nOaz3Va5 4yWQ5wg2W+NXcknWAWopYTVZvNZd/D504x6CEPEp/wSqlWSGblCZZwPb2ordw5ZAIja2 P29Mu39lMzfeRww4Ho1dbV88TiIat7E8IoQshUdx4xr8bhVO0qmX/FdItVsFSIwR3Ald OoHQ== X-Gm-Message-State: AOAM530ot/c2RcZ6tk7F5+0tF+oX4bRKx10v7jUnzQ/c7h+fJ+DiSWfL 6zUfJGAC4sf1UTIVRQPu7TU= X-Google-Smtp-Source: ABdhPJzhA3jW9y1U/VHRqB2+TAhq8vBgv7fDywrgkTgJmnvYz3ND+eXb6bTGt9vwJhd+hEJYMucSKQ== X-Received: by 2002:a2e:8597:: with SMTP id b23mr11438006lji.338.1595324642702; Tue, 21 Jul 2020 02:44:02 -0700 (PDT) Received: from saruman (91-155-214-58.elisa-laajakaista.fi. [91.155.214.58]) by smtp.gmail.com with ESMTPSA id r22sm4192790ljc.25.2020.07.21.02.44.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Jul 2020 02:44:02 -0700 (PDT) From: Felipe Balbi To: Minas Harutyunyan , Lee Jones , "gregkh\@linuxfoundation.org" Subject: Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2 In-Reply-To: <566f2d65-1b5a-ed2a-f33f-516b66be2624@synopsys.com> References: <20200715093209.3165641-1-lee.jones@linaro.org> <20200715093209.3165641-2-lee.jones@linaro.org> <566f2d65-1b5a-ed2a-f33f-516b66be2624@synopsys.com> Date: Tue, 21 Jul 2020 12:43:57 +0300 Message-ID: <87blk9p5ia.fsf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_054404_575056_75C2B7F6 X-CRM114-Status: UNSURE ( 9.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ben Dooks , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: multipart/mixed; boundary="===============0763360826077542890==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0763360826077542890== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Minas Harutyunyan writes: > On 7/15/2020 1:32 PM, Lee Jones wrote: >> The value obtained from GINTSTS2 should be masked with the GINTMSK2 >> value. Looks like this has been broken since >> dwc2_gadget_wkup_alert_handler() was added back in 2018. >>=20 >> Also fixes the following W=3D1 warning: >>=20 >> drivers/usb/dwc2/gadget.c: In function =E2=80=98dwc2_gadget_wkup_alert= _handler=E2=80=99: >> drivers/usb/dwc2/gadget.c:259:6: warning: variable =E2=80=98gintmsk2= =E2=80=99 set but not used [-Wunused-but-set-variable] >> 259 | u32 gintmsk2; >> | ^~~~~~~~ >>=20 >> Cc: Minas Harutyunyan >> Cc: Ben Dooks >> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert inte= rrupt") >> Signed-off-by: Lee Jones > > Acked-by: Minas Harutyunyan Should I apply the entire series or only 1/8? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl8WuN0ACgkQzL64meEa mQacAQ//a/P5SYnBnlVVnSmY6/+H5xaTyA0frND1g+cvwxNLc8oWt8WK97bow8mn gHNkRsPUfur72sCbsHhbOczv7Kc2ea3d+0KJNTv0idAgr8zUG0we/lYewX7+YCDc x911DeDk19uqC84Xbt9LmC9iBJbqPA+IlzckS2CwunqNws57n01+/p+txsNOEwXc EfCJBfEljT+W8u+yoeAu2FDdL3etFHZuIEE/aSLYC5qTqtM8dnUcoci0NDb3J+If uhJ0U0E8S9u3D8vGaL78cZHvMCvY6C4NLj+CdwkTFIGh3wx0uYSyOGnvrd2mlupS UV0oUqJj6vqDZ0MjpUYpAYd9tqSiucigXy13vId9QOSgTGsVKYNHevUlUOLq8lYC q29fZ4qNprDyKdc/JRuzkqanRqVfP7+HArMOXajAbCb1Qbk+qoYp12LuDs4yFWBW cBe1/yy9ItxJAjp7oMBiuMsjWdn/Di7mf3HMt5fTti0jNptDq1BPGsksUudJ656I OewK0YelUC6ptvxRfE4YwI7MUoG5EciU9tonBpFGkU2euzs6VrIpIF9haDIKEuC8 8eafrA9+yamuhElBP0xix/Bbif/Lk6oxK6yXVIwdB5qCNEgHRPjLzDEQykO1QBwp BMykpU5UXXpdqYD9kuT3k/hHTLq8GeO2o3bHVWoWZTvw7ZumzMk= =1ehQ -----END PGP SIGNATURE----- --=-=-=-- --===============0763360826077542890== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0763360826077542890==--