From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTOxG-0002tk-Vt for ath10k@lists.infradead.org; Tue, 28 Apr 2020 12:03:25 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: increase rx buffer size to 2048 In-Reply-To: <3097447.aZuNXRJysd@sven-edge> (Sven Eckelmann's message of "Sat, 25 Apr 2020 13:14:42 +0200") References: <20200205191043.21913-1-linus.luessing@c0d3.blue> <3300912.TRQvxCK2vZ@bentobox> <3097447.aZuNXRJysd@sven-edge> Date: Tue, 28 Apr 2020 15:01:28 +0300 Message-ID: <87blnblsyv.fsf@codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Sven Eckelmann Cc: Linus =?utf-8?Q?L=C3=BCssing?= , Simon Wunderlich , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, mail@adrianschmutzler.de, Ben Greear , "David S . Miller" , Linus =?utf-8?Q?L=C3=BCssing?= U3ZlbiBFY2tlbG1hbm4gPHN2ZW5AbmFyZmF0aW9uLm9yZz4gd3JpdGVzOgoKPiBPbiBXZWRuZXNk YXksIDEgQXByaWwgMjAyMCAwOTowMDo0OSBDRVNUIFN2ZW4gRWNrZWxtYW5uIHdyb3RlOgo+PiBP biBXZWRuZXNkYXksIDUgRmVicnVhcnkgMjAyMCAyMDoxMDo0MyBDRVNUIExpbnVzIEzDvHNzaW5n IHdyb3RlOgo+PiA+IEZyb206IExpbnVzIEzDvHNzaW5nIDxsbEBzaW1vbnd1bmRlcmxpY2guZGU+ Cj4+ID4gCj4+ID4gQmVmb3JlLCBvbmx5IGZyYW1lcyB3aXRoIGEgbWF4aW11bSBzaXplIG9mIDE1 MjggYnl0ZXMgY291bGQgYmUKPj4gPiB0cmFuc21pdHRlZCBiZXR3ZWVuIHR3byA4MDIuMTFzIG5v ZGVzLgo+PiA+IAo+PiA+IEZvciBiYXRtYW4tYWR2IGZvciBpbnN0YW5jZSwgd2hpY2ggYWRkcyBp dHMgb3duIGhlYWRlciB0byBlYWNoIGZyYW1lLAo+PiA+IHdlIHR5cGljYWxseSBuZWVkIGFuIE1U VSBvZiBhdCBsZWFzdCAxNTMyIGJ5dGVzIHRvIGJlIGFibGUgdG8gdHJhbnNtaXQKPj4gPiB3aXRo b3V0IGZyYWdtZW50YXRpb24uCj4+ID4gCj4+ID4gVGhpcyBwYXRjaCBub3cgaW5jcmVhc2VzIHRo ZSBtYXhtaW11bSBmcmFtZSBzaXplIGZyb20gMTUyOCB0byAxNjU2Cj4+ID4gYnl0ZXMuCj4+IFsu Li5dCj4+IAo+PiBAS2FsbGUsIEkgc2F3IHRoYXQgdGhpcyBwYXRjaCB3YXMgbWFya2VkIGFzIGRl ZmVycmVkIFsxXSBidXQgSSBjb3VsZG4ndCBmaW5kIAo+PiBhbnkgbWFpbCB3aHkgaXQgd2FzIGRv bmUgc28uIEl0IHNlZW1zIGxpa2UgdGhpcyBjdXJyZW50bHkgY3JlYXRlcyByZWFsIHdvcmxkIAo+ PiBwcm9ibGVtcyAtIHNvIHdvdWxkIGJlIG5pY2UgaWYgeW91IGNvdWxkIGV4cGxhaW4gc2hvcnRs eSB3aGF0IGlzIGN1cnJlbnRseSAKPj4gYmxvY2tpbmcgaXRzIGFjY2VwdGFuY2UuCj4KPiBQaW5n PwoKU29ycnkgZm9yIHRoZSBkZWxheSwgbXkgcGxhbiB3YXMgdG8gZmlyc3Qgd3JpdGUgc29tZSBk b2N1bWVudGF0aW9uIGFib3V0CmRpZmZlcmVudCBoYXJkd2FyZSBmYW1pbGllcyBidXQgaGF2ZW4n dCBtYW5hZ2VkIHRvIGRvIHRoYXQgeWV0LgoKTXkgcHJvYmxlbSB3aXRoIHRoaXMgcGF0Y2ggaXMg dGhhdCBJIGRvbid0IGtub3cgd2hhdCBoYXJkd2FyZSBhbmQKZmlybXdhcmUgdmVyc2lvbnMgd2Vy ZSB0ZXN0ZWQsIHNvIGl0IG5lZWRzIGFuYWx5c2lzIGJlZm9yZSBJIGZlZWwgc2FmZQp0byBhcHBs eSBpdC4gVGhlIGF0aDEwayBoYXJkd2FyZSBmYW1pbGllcyBhcmUgdmVyeSBkaWZmZXJlbnQgdGhh dCBldmVuCmlmIGEgcGF0Y2ggd29ya3MgcGVyZmVjdGx5IG9uIG9uZSBhdGgxMGsgaGFyZHdhcmUg aXQgY291bGQgc3RpbGwgYnJlYWsKYmFkbHkgb24gYW5vdGhlciBvbmUuCgpXaGF0IG1ha2VzIG1l IGZhc3RlciB0byBhcHBseSBhdGgxMGsgcGF0Y2hlcyBpcyB0byBoYXZlIGNvbXByZWhlbnNpdmUK YW5hbHlzaXMgaW4gdGhlIGNvbW1pdCBsb2cuIFRoaXMgc2hvd3MgbWUgdGhlIHBhdGNoIGF1dGhv ciBoYXMKY29uc2lkZXJlZCBhYm91dCBhbGwgaGFyZHdhcmUgZmFtaWxpZXMsIG5vdCBqdXN0IHRo ZSBvbmUgaGUgaXMgdGVzdGluZwpvbiwgYW5kIHRoYXQgSSBkb24ndCBuZWVkIHRvIGRvIHRoZSBh bmFseXNpcyBteXNlbGYuCgotLSAKaHR0cHM6Ly93aXJlbGVzcy53aWtpLmtlcm5lbC5vcmcvZW4v ZGV2ZWxvcGVycy9kb2N1bWVudGF0aW9uL3N1Ym1pdHRpbmdwYXRjaGVzCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0 aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 091C3C83008 for ; Tue, 28 Apr 2020 12:02:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBB36206D7 for ; Tue, 28 Apr 2020 12:02:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="sLNTJtw0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726556AbgD1MCh (ORCPT ); Tue, 28 Apr 2020 08:02:37 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:17365 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726644AbgD1MCh (ORCPT ); Tue, 28 Apr 2020 08:02:37 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588075356; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: Date: References: In-Reply-To: Subject: Cc: To: From: Sender; bh=YxH+2DR7vWFpUoIHziSKBV2f45z4/gOayRfRydsyFKo=; b=sLNTJtw01efRDhNcwIpimwlqQXj1HsKfS7LtggKWnxP27nNHjqXamazOEG79JQq7HuoxRVea YB3gU2vsEwcI6WhZYPUh+m3xmBxinTni5c5BKaqBkOauuH5/Fg7rMPIu3eATzzDCXgBCJgLT SDIoYRWxFz3nowKSJEiVLWMs56o= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea81b20.7f91eb17bbc8-smtp-out-n04; Tue, 28 Apr 2020 12:01:36 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BC9DBC43637; Tue, 28 Apr 2020 12:01:34 +0000 (UTC) Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id E244DC433D2; Tue, 28 Apr 2020 12:01:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E244DC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Sven Eckelmann Cc: ath10k@lists.infradead.org, Linus =?utf-8?Q?L=C3=BCssing?= , Simon Wunderlich , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Greear , "David S . Miller" , Linus =?utf-8?Q?L=C3=BCssing?= , mail@adrianschmutzler.de Subject: Re: [PATCH] ath10k: increase rx buffer size to 2048 In-Reply-To: <3097447.aZuNXRJysd@sven-edge> (Sven Eckelmann's message of "Sat, 25 Apr 2020 13:14:42 +0200") References: <20200205191043.21913-1-linus.luessing@c0d3.blue> <3300912.TRQvxCK2vZ@bentobox> <3097447.aZuNXRJysd@sven-edge> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) Date: Tue, 28 Apr 2020 15:01:28 +0300 Message-ID: <87blnblsyv.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sven Eckelmann writes: > On Wednesday, 1 April 2020 09:00:49 CEST Sven Eckelmann wrote: >> On Wednesday, 5 February 2020 20:10:43 CEST Linus L=C3=BCssing wrote: >> > From: Linus L=C3=BCssing >> >=20 >> > Before, only frames with a maximum size of 1528 bytes could be >> > transmitted between two 802.11s nodes. >> >=20 >> > For batman-adv for instance, which adds its own header to each frame, >> > we typically need an MTU of at least 1532 bytes to be able to transmit >> > without fragmentation. >> >=20 >> > This patch now increases the maxmimum frame size from 1528 to 1656 >> > bytes. >> [...] >>=20 >> @Kalle, I saw that this patch was marked as deferred [1] but I couldn't = find=20 >> any mail why it was done so. It seems like this currently creates real w= orld=20 >> problems - so would be nice if you could explain shortly what is current= ly=20 >> blocking its acceptance. > > Ping? Sorry for the delay, my plan was to first write some documentation about different hardware families but haven't managed to do that yet. My problem with this patch is that I don't know what hardware and firmware versions were tested, so it needs analysis before I feel safe to apply it. The ath10k hardware families are very different that even if a patch works perfectly on one ath10k hardware it could still break badly on another one. What makes me faster to apply ath10k patches is to have comprehensive analysis in the commit log. This shows me the patch author has considered about all hardware families, not just the one he is testing on, and that I don't need to do the analysis myself. --=20 https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes