All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: crosa@redhat.com, philmd@redhat.com, qemu-devel@nongnu.org,
	ehabkost@redhat.com, mdroth@linux.vnet.ibm.com
Subject: Re: [PATCH v2 4/4] qapi: Brush off some (py)lint
Date: Thu, 05 Mar 2020 06:56:09 +0100	[thread overview]
Message-ID: <87blpb1h1i.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <896c42b1-eaeb-51bd-1dc3-ba5508431149@redhat.com> (John Snow's message of "Wed, 4 Mar 2020 15:33:48 -0500")

John Snow <jsnow@redhat.com> writes:

> On 3/4/20 10:59 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  scripts/qapi/commands.py   |  2 +-
>>  scripts/qapi/expr.py       |  3 +--
>>  scripts/qapi/gen.py        |  9 ++++++---
>>  scripts/qapi/introspect.py |  2 --
>>  scripts/qapi/parser.py     |  6 ++----
>>  scripts/qapi/schema.py     | 11 +++++------
>>  6 files changed, 15 insertions(+), 18 deletions(-)
>> 
>
> Looks okay. (I don't care as much about no-else-return being there or
> not, and this module is your baby.)

I admit I personally prefer to elide the else there.  But my main
argument is consistent style.  Picking the one pylint wants makes
consistency easier.

> Reviewed-by: John Snow <jsnow@redhat.com>

Thanks!



  reply	other threads:[~2020-03-05  5:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 15:59 [PATCH v2 0/4] qapi: Bye-bye Python 2 Markus Armbruster
2020-03-04 15:59 ` [PATCH v2 1/4] qapi: Inheriting from object is pointless with Python 3, drop Markus Armbruster
2020-03-04 20:25   ` John Snow
2020-03-04 15:59 ` [PATCH v2 2/4] qapi: Drop conditionals for Python 2 Markus Armbruster
2020-03-04 20:26   ` John Snow
2020-03-04 15:59 ` [PATCH v2 3/4] qapi: Use super() now we have Python 3 Markus Armbruster
2020-03-04 20:30   ` John Snow
2020-03-04 15:59 ` [PATCH v2 4/4] qapi: Brush off some (py)lint Markus Armbruster
2020-03-04 20:33   ` John Snow
2020-03-05  5:56     ` Markus Armbruster [this message]
2020-03-05 18:09       ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blpb1h1i.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.