From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a05:6512:3aa:0:0:0:0 with SMTP id v10csp5101804lfp; Tue, 4 Feb 2020 01:15:31 -0800 (PST) X-Google-Smtp-Source: APXvYqwgOS/auW/6hB4peszxE+rzK2/81FGIRKILE0RAagdHRZI0KhCdKb+ZkTDSucVXMMHAHs0l X-Received: by 2002:aed:24b2:: with SMTP id t47mr27409704qtc.337.1580807731079; Tue, 04 Feb 2020 01:15:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580807731; cv=none; d=google.com; s=arc-20160816; b=TNb2mcJ4r6TTFbQ0pK8BGRlqn6JDh60Po64w2BAjSK0qM9Jh6+oIMUs1ZE+ZQHTknW 72iN6FLZNZT+eVNXDYPf768d6s4YO3fScsjtNcp/xT7h6DYDBBBnmlqCM+ghGyvKXxER qlk0+XPoN5TrS6QgxY3SbUmAa0guVv51yIIPu0Wm6TT37UUL8XpflGRBeL4ONqp0JUEm qYNl2QUMxYHqJ4dKuPRyh1CCM3wnjonHQHXihgu9xSTWHjUob+qWZrbsqyRs0HC/WBht LguYaUGOn0FiMUCWQdBL/1jri339pHNEc99S67F24trpHLc48Py1PyAOkJsVkXGZ7FYW Kjeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:to:from:dkim-signature; bh=an2Gkp9unIEriLSGyodP//4XJXFL/hL+jhCSDIXSz9U=; b=07zmXR8sR/qCgGEm4nQOqnoffDvsjC3LcfSxWSvyy85W4b7cDysZ6vEt+BeO4q70Ez hEasWBsQ90xogJrO35c7s5RUbb/4WDT/IiTILSMx1OcYUBEAV9egganytnfIxzf4YwvW Nors+Xy5MfQK0r8MXLyWPBEhc91DFtE4R3bOEMTxXYJjQe+2N4HTYKgRPT3jba1RCdZp SQLSVPpYvson392qGAKCkFkeH52LS1T+oohXFGPoJRZC8OBGEKyQvz+7dWa5rPc2tnL2 N1fuGSjMwDRYjQT9ixeFiL3FiJ/n3gSJiBa0lylGDj9V1v7Cc3legv/OS8NtBg+k+KDk vtEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=CqxaqOLi; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 127si13746909qkl.279.2020.02.04.01.15.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Feb 2020 01:15:31 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=CqxaqOLi; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:54846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyuIs-0007Si-BO for alex.bennee@linaro.org; Tue, 04 Feb 2020 04:15:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52563) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyuI2-0006oa-U1 for qemu-devel@nongnu.org; Tue, 04 Feb 2020 04:14:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyuHz-0003Ki-U1 for qemu-devel@nongnu.org; Tue, 04 Feb 2020 04:14:36 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:32423 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iyuHz-0003Cb-NQ for qemu-devel@nongnu.org; Tue, 04 Feb 2020 04:14:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580807673; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=an2Gkp9unIEriLSGyodP//4XJXFL/hL+jhCSDIXSz9U=; b=CqxaqOLiTP0Q6dnxGzLUBsBCzh7cCYAnDb1GusBX03OR6MWVhWzVpTuaTa3aNALiK+/JBE Px2M0+5zWIvuYsE11hnfC2yFxULPhTjyo3SqRG4A9xd4amIRaFWTpmy7bUYnNiF/XYOHEO p0vlY7Jf2LzEASltgkmu/mFNhIodjRE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-GhtMIrN5M6SFCFNClTYhnA-1; Tue, 04 Feb 2020 04:14:32 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F109B801E72; Tue, 4 Feb 2020 09:14:30 +0000 (UTC) Received: from redhat.com (ovpn-117-28.ams2.redhat.com [10.36.117.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74AD35C1B5; Tue, 4 Feb 2020 09:14:27 +0000 (UTC) From: Juan Quintela To: Keqian Zhu Subject: Re: [PATCH] migration: Optimization about wait-unplug migration state In-Reply-To: <20200204050841.44453-1-zhukeqian1@huawei.com> (Keqian Zhu's message of "Tue, 4 Feb 2020 13:08:41 +0800") References: <20200204050841.44453-1-zhukeqian1@huawei.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Tue, 04 Feb 2020 10:14:24 +0100 Message-ID: <87blqehfyn.fsf@secure.laptop> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: GhtMIrN5M6SFCFNClTYhnA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: jfreimann@redhat.com, wanghaibin.wang@huawei.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: yW3g65cdPpn0 Keqian Zhu wrote: > qemu_savevm_nr_failover_devices() is originally designed to > get the number of failover devices, but it actually returns > the number of "unplug-pending" failover devices now. Moreover, > what drives migration state to wait-unplug should be the number > of "unplug-pending" failover devices, not all failover devices. > > We can also notice that qemu_savevm_state_guest_unplug_pending() > and qemu_savevm_nr_failover_devices() is equivalent almost (from > the code view). So the latter is incorrect semantically and > useless, just delete it. > > In the qemu_savevm_state_guest_unplug_pending(), once hit a > unplug-pending failover device, then it can return true right > now to save cpu time. > > Signed-off-by: Keqian Zhu Reviewed-by: Juan Quintela For my reading you are right: - 1st function naming is not right - 2nd function achieves exactly the same effect I will wait until Jens says anything, but then I will queue it. Thanks, Juan.