All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Petri Latvala <petri.latvala@intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] runner: Make the result an incomplete if a test is killed due to taint
Date: Wed, 29 Jan 2020 16:13:36 +0200	[thread overview]
Message-ID: <87blqm9wq7.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <158030646210.11197.985551830684189117@skylake-alporthouse-com>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Quoting Petri Latvala (2020-01-29 13:56:19)
>> If we're checking for taints, we kill the test as soon as we notice a
>> taint. Out of the box, such killing will get marked as such and yields
>> a 'timeout' result, which is misleading. The test didn't spend too
>> much time, it just did nasties.
>> 
>> Make sure taint-killing results in an 'incomplete' result
>> instead. It's still not completely truthful for the state of the
>> testing but closer than a 'timeout'. And stands out more in CI result
>> analysis.
>> 
>> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>
> Incomplete has been synonymous in my mind with the "kernel oopsed" so it
> worksforme. Even if the HW dies, everyone blames the kernel for letting
> it die!
>

So with this patch, we can now assume 'incomplete' is always
atleast oops/bug_on or a more catastrophics system hang?

-Mika
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-01-29 14:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 13:56 [igt-dev] [PATCH i-g-t] runner: Make the result an incomplete if a test is killed due to taint Petri Latvala
2020-01-29 14:01 ` Chris Wilson
2020-01-29 14:13   ` Mika Kuoppala [this message]
2020-01-29 14:27     ` Chris Wilson
2020-01-29 16:37 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-30  8:57   ` Petri Latvala
2020-02-01  2:05 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blqm9wq7.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.