From: Felipe Balbi <balbi@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: Re: [PATCH] usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors
Date: Thu, 02 Jan 2020 13:24:04 +0200 [thread overview]
Message-ID: <87blrmksob.fsf@kernel.org> (raw)
In-Reply-To: <20191231174848.741314-1-linus.walleij@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2039 bytes --]
Hi,
Linus Walleij <linus.walleij@linaro.org> writes:
> Instead of using the legacy GPIO API and keeping track on
> polarity inversion semantics in the driver, switch to use
> GPIO descriptors for this driver and change all consumers
> in the process.
>
> This makes it possible to retire platform data completely:
> the only remaining platform data member was "wakeup" which
> was intended to make the vbus interrupt wakeup capable,
> but was not set by any users and thus remained unused. VBUS
> was not waking any devices up. Leave a comment about it so
> later developers using the platform can consider setting it
> to always enabled so plugging in USB wakes up the platform.
>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Cc: Daniel Mack <daniel@zonque.org>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> This change hits arch/arm/mach-pxa/* and
> arch/arm/mach-s3c64* so I have CC to the most active
> maintainers.
> ---
> arch/arm/mach-pxa/colibri-pxa320.c | 16 ++---
> arch/arm/mach-pxa/eseries.c | 40 +++++++-----
> arch/arm/mach-pxa/gumstix.c | 18 +++---
> arch/arm/mach-pxa/hx4700.c | 22 ++++---
> arch/arm/mach-pxa/magician.c | 22 ++++---
> arch/arm/mach-pxa/mioa701.c | 15 +++--
> arch/arm/mach-pxa/palm27x.c | 34 +++++------
> arch/arm/mach-pxa/palmt5.c | 1 -
> arch/arm/mach-pxa/palmtc.c | 18 +++---
> arch/arm/mach-pxa/palmte2.c | 18 +++---
> arch/arm/mach-pxa/palmtx.c | 1 -
> arch/arm/mach-pxa/palmz72.c | 1 -
> arch/arm/mach-pxa/tosa.c | 18 +++---
> arch/arm/mach-pxa/vpac270.c | 15 ++---
> arch/arm/mach-s3c64xx/mach-smartq.c | 13 ++--
> drivers/usb/phy/phy-gpio-vbus-usb.c | 95 +++++++++++++----------------
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-01-02 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 17:48 [PATCH] usb: phy: phy-gpio-vbus-usb: Convert to GPIO descriptors Linus Walleij
2020-01-02 11:24 ` Felipe Balbi [this message]
2020-01-02 15:23 ` Sylwester Nawrocki
2020-01-02 15:54 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blrmksob.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=daniel@zonque.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robert.jarzmik@free.fr \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.