From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E000EC2D0DC for ; Thu, 2 Jan 2020 10:30:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB4132085B for ; Thu, 2 Jan 2020 10:30:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB4132085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 60578896FA; Thu, 2 Jan 2020 10:30:22 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 65DE2896FA for ; Thu, 2 Jan 2020 10:30:21 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2020 02:30:20 -0800 X-IronPort-AV: E=Sophos;i="5.69,386,1571727600"; d="scan'208";a="221346159" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2020 02:30:19 -0800 From: Jani Nikula To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <157677483329.6469.18250205597696895684@skylake-alporthouse-com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191219155652.2666-1-jani.nikula@intel.com> <20191219155652.2666-3-jani.nikula@intel.com> <157677483329.6469.18250205597696895684@skylake-alporthouse-com> Date: Thu, 02 Jan 2020 12:30:17 +0200 Message-ID: <87blrmtakm.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: reimplement header test feature X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masahiro Yamada Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 19 Dec 2019, Chris Wilson wrote: > Quoting Jani Nikula (2019-12-19 15:56:52) >> From: Masahiro Yamada >> >> I implemented a small build rule in drivers/gpu/drm/i915/Makefile >> without relying on the special header-test-y syntax that was removed in >> commit fcbb8461fd23 ("kbuild: remove header compile test"). >> >> I excluded some headers from the test coverage. I hope somebody >> intrested can take a closer look at them. >> >> Dummy subdir Makefiles can be removed altogether as single target build >> use case is now covered by commit 394053f4a4b3 ("kbuild: make single >> targets work more correctly"). >> >> v2 by Jani: >> - add selftests/i915_perf_selftests.h to no-header-test >> - add .gitignore for *.hdrtest >> >> Cc: Chris Wilson >> Cc: Masahiro Yamada >> Signed-off-by: Masahiro Yamada >> Signed-off-by: Jani Nikula > > Whelp, I guess that explains why CI didn't tell me off for breaking the > self-contained headers. The pattern matching works, I didn't see any > residue after a make clean, and git status is not swamped with the > artifacts. Single object build still works. O=_build still works > (O=_build -j10 did not, hopefully that is not significant???) I couldn't reproduce any issues with parallel out-of-tree builds. Fingers crossed. > Everything looks (mostly) in order, > Reviewed-by: Chris Wilson Thanks, pushed. BR, Jani. > -Chris > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx