Re: [PATCH] target/arm: Set ISSIs16Bit in make_issinfo

["Alex Bennée" <alex.bennee@linaro.org>]

Richard Henderson <richard.henderson@linaro.org> writes:

> During the conversion to decodetree, the setting of
> ISSIs16Bit got lost.  This causes the guest os to
> incorrectly adjust trapping memory operations.
>
> Fixes: 46beb58efbb8a2a32

It's not really obvious from this commit where we end up now calling...


> Cc: qemu-stable@nongnu.org
> Reported-by: Jeff Kubascik <jeff.kubascik@dornerworks.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/translate.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index 2b6c1f91bf..9f0afbdb75 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -8556,6 +8556,9 @@ static ISSInfo make_issinfo(DisasContext *s, int rd, bool p, bool w)
>      /* ISS not valid if writeback */
>      if (p && !w) {
>          ret = rd;
> +        if (s->base.pc_next - s->pc_curr == 2) {
> +            ret |= ISSIs16Bit;
> +        }

this function.

Should I be seeing op_load_rr/ri in the included generated functions?

>      } else {
>          ret = ISSInvalid;
>      }


-- 
Alex Bennée