From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mdroth@linux.vnet.ibm.com" <mdroth@linux.vnet.ibm.com>
Subject: Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument
Date: Wed, 04 Dec 2019 14:03:25 +0100 [thread overview]
Message-ID: <87blsob5uq.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <878snybrf7.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Fri, 29 Nov 2019 17:03:56 +0100")
Markus Armbruster <armbru@redhat.com> writes:
> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>
>> 29.11.2019 17:35, Markus Armbruster wrote:
[...]
>>> I pushed my fixups to git://repo.or.cz/qemu/armbru.git branch error-prep
>>> for your convenience. The commit messages of the fixed up commits need
>>> rephrasing, of course.
>>>
>>
>> Looked through fixups, looks OK for me, thanks! What next?
>
> Let me finish my fixing incorrect dereferences of errp, and then we
> figure out what to include in v7.
Your v6 with my fixups does not conflict with my "[PATCH v2 00/18] Error
handling fixes", except for "hw/core/loader-fit: fix freeing errp in
fit_load_fdt", which my "[PATCH v2 07/18] hw/core: Fix fit_load_fdt()
error handling violations" supersedes.
Suggest you work in the fixups and post as v7. I'll merge that in my
tree, to give you a base for the remainder of your "auto propagated
local_err" work. While you work on that, I'll work on getting the base
merged into master. Sounds like a plan?
next prev parent reply other threads:[~2019-12-04 13:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 18:37 [PATCH v6] error: rename errp to errp_in where it is IN-argument Vladimir Sementsov-Ogievskiy
2019-11-28 14:23 ` Markus Armbruster
2019-11-28 14:54 ` Vladimir Sementsov-Ogievskiy
2019-11-28 20:29 ` Markus Armbruster
2019-11-29 8:28 ` Vladimir Sementsov-Ogievskiy
2019-11-29 14:35 ` Markus Armbruster
2019-11-29 15:09 ` Vladimir Sementsov-Ogievskiy
2019-11-29 16:03 ` Markus Armbruster
2019-12-04 13:03 ` Markus Armbruster [this message]
2019-12-04 14:59 ` Vladimir Sementsov-Ogievskiy
2019-12-04 15:40 ` Markus Armbruster
2019-11-29 8:45 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blsob5uq.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.