From: Kalle Valo <kvalo@codeaurora.org>
To: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
Cc: ath11k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath11k/hal: Fix few bugs in ath11k_hal_srng_dst_num_free()
Date: Thu, 18 Jul 2019 14:37:04 +0300 [thread overview]
Message-ID: <87blxr376n.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1563423855-32397-1-git-send-email-vthiagar@codeaurora.org> (Vasanthakumar Thiagarajan's message of "Thu, 18 Jul 2019 09:54:14 +0530")
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> writes:
> The logic to compute the number of available buffers in destination
> ring is wrong. It should be just the different between head and
> tail pointers in terms of the entry size. This functions currently
> unused, this is fixed to make use of this function in follow-up
> patches. Also make destination ring head pointer volatile because
> it is independently updated by HW.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
[...]
> --- a/drivers/net/wireless/ath/ath11k/hal.h
> +++ b/drivers/net/wireless/ath/ath11k/hal.h
> @@ -538,7 +538,7 @@ struct hal_srng {
> u32 tp;
>
> /* Shadow head pointer location to be updated by HW */
> - u32 *hp_addr;
> + volatile u32 *hp_addr;
What about tp_addr, shouldn't we make that also volatile to remove the
ugly cast? Can someone send another patch to fix that, please?
--
Kalle Valo
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2019-07-18 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 4:24 [PATCH 1/2] ath11k/hal: Fix few bugs in ath11k_hal_srng_dst_num_free() Vasanthakumar Thiagarajan
2019-07-18 4:24 ` [PATCH 2/2] ath11k/dp_rx: Fix possible REO ring desc overwrite Vasanthakumar Thiagarajan
2019-07-18 11:37 ` Kalle Valo [this message]
2019-07-18 12:13 ` [PATCH 1/2] ath11k/hal: Fix few bugs in ath11k_hal_srng_dst_num_free() Vasanthakumar Thiagarajan
2019-07-31 15:06 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blxr376n.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=vthiagar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.