From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.86_2) id 1hjMfK-0000bB-96 for mharc-grub-devel@gnu.org; Fri, 05 Jul 2019 07:46:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44511) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjMfH-0000Zx-73 for grub-devel@gnu.org; Fri, 05 Jul 2019 07:46:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjMfF-0006bz-8Y for grub-devel@gnu.org; Fri, 05 Jul 2019 07:46:07 -0400 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]:46752) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjMfD-0006RP-JH for grub-devel@gnu.org; Fri, 05 Jul 2019 07:46:05 -0400 Received: by mail-qk1-x743.google.com with SMTP id r4so7582772qkm.13 for ; Fri, 05 Jul 2019 04:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=X9S6QXjOep5Hl5vpV4dTyCxrmtaeunNw28lI1HsYW40=; b=i7yuJujJa4KkfrDNFeWVf9Afw4S++b13qq+kp6DuccWXreqxMaUYQqemRLHH3ZR8KY 0GPUDQ+698h+U+f5MHPusIIw4I42njWP3cL4U9PNI9znKfXYP6VKQwcZRO788CVVun3/ fuoCGy+DmVj+pQ6OJVo0zi2mccd08Ti4xGKQCGLbb9M7eJVTwCSv9pt2cPxOcXjOfymb XSV3+FKxMtJGFuh9CbCAOeIrWm7+dnlePZuHvH51nt88xNWp2vB3OsjIGxtUKFSZ0o9f DiOPp1tkHqNp/F1qiYhfITe4dJMsousN8B2IlOUpZauzb/ToS38jgmy9EVvvlXA2DXMw 51jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=X9S6QXjOep5Hl5vpV4dTyCxrmtaeunNw28lI1HsYW40=; b=BNmTYe7v2IvrxAwKXuqbfc/yQoUQU3UDqAdYpTd8LOJO/9JMXFuw0wzttmYKEN6wWx rIMoOnVWPz0R7Bl/sqZARnbIFQ+/5gUTvJlGiHFi3sSc5vxvd0HhWPmwJpsOyrb2lk/X BApt64xvgrsHfAepCYETkiuBiOe4bAKhRwdL1IKdnuTuVXq2LVstlYSLP2lKzChTy5dx KHdqUNcrC/pKGfk+VxL9+010DdZf+7/li9LwnmTOR5TpBKaVO/zwlbMyocKHMC3IbYpR cKKxQtBf6ptEpPdR8ft3ZXVUdv4fprMMbwFGMq54Dp9NDS3+joydbgbDJV+GVscwsrWi v4AA== X-Gm-Message-State: APjAAAWxV+7gw8AZ1QGsiL53HUtcmwR89RIes96xw1/WE3lCNiUmh0zd ifUpFsWexsLxUcCJat/AgMJcLamO X-Google-Smtp-Source: APXvYqwOr31pduXApFr0AHapVx/x0FDRIKX/0I50N6xOc3qstdRVo0d+W2cWpX2HVph/a8be4uGLhA== X-Received: by 2002:a05:620a:1286:: with SMTP id w6mr2594805qki.219.1562327161472; Fri, 05 Jul 2019 04:46:01 -0700 (PDT) Received: from callisto ([2601:986:200:7341:2cf7:f5dc:5eed:77b3]) by smtp.gmail.com with ESMTPSA id u71sm3733626qka.21.2019.07.05.04.46.00 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Jul 2019 04:46:00 -0700 (PDT) From: David Michael To: grub-devel@gnu.org Subject: [PATCH] generic/blocklist: Fix flag name Date: Fri, 05 Jul 2019 07:45:59 -0400 Message-ID: <87bly8r9fs.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::743 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jul 2019 11:46:09 -0000 Signed-off-by: David Michael --- Hi, I tried to test the new release and hit this build failure: In file included from ../grub-core/osdep/blocklist.c:6:0: ../grub-core/osdep/generic/blocklist.c: In function =E2=80=98grub_install_g= et_blocklist=E2=80=99: ../grub-core/osdep/generic/blocklist.c:62:67: error: =E2=80=98FILE_TYPE_NO_= DECOMPRESS=E2=80=99 undeclared (first use in this function); did you mean = =E2=80=98GRUB_FILE_TYPE_NO_DECOMPRESS=E2=80=99? file =3D grub_file_open (core_path_dev, GRUB_FILE_TYPE_NONE | FILE_T= YPE_NO_DECOMPRESS); ^~~~~~~~= ~~~~~~~~~~~~~~~ GRUB_FIL= E_TYPE_NO_DECOMPRESS ../grub-core/osdep/generic/blocklist.c:62:67: note: each undeclared identif= ier is reported only once for each function it appears in It seems to be fixed by this change. Can it be applied for the next releas= e? Thanks. David grub-core/osdep/generic/blocklist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/osdep/generic/blocklist.c b/grub-core/osdep/generic/= blocklist.c index ea2a511b6..2d9040302 100644 --- a/grub-core/osdep/generic/blocklist.c +++ b/grub-core/osdep/generic/blocklist.c @@ -59,7 +59,7 @@ grub_install_get_blocklist (grub_device_t root_dev, =20 grub_disk_cache_invalidate_all (); =20 - file =3D grub_file_open (core_path_dev, GRUB_FILE_TYPE_NONE | FILE_T= YPE_NO_DECOMPRESS); + file =3D grub_file_open (core_path_dev, GRUB_FILE_TYPE_NONE | GRUB_F= ILE_TYPE_NO_DECOMPRESS); if (file) { if (grub_file_size (file) !=3D core_size) @@ -116,7 +116,7 @@ grub_install_get_blocklist (grub_device_t root_dev, =20 grub_file_t file; /* Now read the core image to determine where the sectors are. */ - file =3D grub_file_open (core_path_dev, GRUB_FILE_TYPE_NONE | FILE_TYPE_= NO_DECOMPRESS); + file =3D grub_file_open (core_path_dev, GRUB_FILE_TYPE_NONE | GRUB_FILE_= TYPE_NO_DECOMPRESS); if (! file) grub_util_error ("%s", grub_errmsg); =20 --=20 2.20.1