From: Jani Nikula <jani.nikula@intel.com>
To: Paul Wise <pabs3@bonedaddy.net>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Ilpo Järvinen" <ilpo.jarvinen@cs.helsinki.fi>,
stable@vger.kernel.org, "Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Harish Chegondi" <harish.chegondi@intel.com>
Subject: Re: [PATCH 2/2] drm: add fallback override/firmware EDID modes workaround
Date: Mon, 10 Jun 2019 12:32:30 +0300 [thread overview]
Message-ID: <87blz5zsy9.fsf@intel.com> (raw)
In-Reply-To: <0667fc81810f2da5110c7da00963c93da90a6cd7.camel@bonedaddy.net>
On Sat, 08 Jun 2019, Paul Wise <pabs3@bonedaddy.net> wrote:
> On Sat, 2019-06-08 at 13:10 +0800, Paul Wise wrote:
>
>> I've tested these two patches on top of Linux v5.2-rc3 and the EDID
>> override works correctly on an Intel Ironlake GPU with a monitor that
>> lost its EDID a while ago.
>
> While testing I noticed a couple of things:
>
> While everything the GUI is the correct resolution, GNOME is unable to
> identify the monitor vendor or model. This is a regression from the
> previous edid override functionality. It looks like this is because the
> edid file in /sys is not populated with the EDID override data.
Right, I've added a call to drm_connector_update_edid_property() in v2
to address this issue.
> I got a crash due to null pointer dereference at one point, I'll try to
> track down when this happens.
Can't think of why this would happen; the backtrace might offer clues.
Thanks for testing!
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2019-06-10 9:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 11:05 [PATCH 1/2] drm/edid: abstract override/firmware EDID retrieval Jani Nikula
2019-06-07 11:05 ` [PATCH 2/2] drm: add fallback override/firmware EDID modes workaround Jani Nikula
2019-06-07 15:10 ` Daniel Vetter
2019-06-08 1:06 ` Paul Wise
2019-06-08 5:10 ` Paul Wise
2019-06-08 5:48 ` Paul Wise
2019-06-10 9:32 ` Jani Nikula [this message]
2019-06-11 8:28 ` Paul Wise
2019-06-08 15:40 ` Paul Wise
2019-06-10 9:30 ` [PATCH v2] " Jani Nikula
2019-06-11 8:27 ` Paul Wise
2019-06-12 10:53 ` Jani Nikula
2019-06-07 11:48 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/edid: abstract override/firmware EDID retrieval Patchwork
2019-06-07 12:08 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-09 22:57 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-06-10 12:31 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/edid: abstract override/firmware EDID retrieval (rev2) Patchwork
2019-06-10 12:53 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-11 6:26 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blz5zsy9.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harish.chegondi@intel.com \
--cc=ilpo.jarvinen@cs.helsinki.fi \
--cc=intel-gfx@lists.freedesktop.org \
--cc=pabs3@bonedaddy.net \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.