From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/vc4: Fix with pm_runtime synchronization on DSI Date: Mon, 01 Apr 2019 10:48:11 -0700 Message-ID: <87bm1p1usk.fsf@anholt.net> References: <20190329012913.29538-1-hoegeun.kwon@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1156511684==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 74BAE6E1D3 for ; Mon, 1 Apr 2019 17:48:14 +0000 (UTC) In-Reply-To: <20190329012913.29538-1-hoegeun.kwon@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org Cc: hoegeun.kwon@samsung.com List-Id: dri-devel@lists.freedesktop.org --===============1156511684== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hoegeun Kwon writes: > There is a problem when often dpms goes from off to on. pm idle is not > in sync and the problem occurs. Modify pm_runtime_put from > asynchronous to synchronous. Why would we need the power domain to go to off before we try to come back? Any idea? Also, please specify what "the problem" is. > > Signed-off-by: Hoegeun Kwon > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c > index 11702e1d9011..b0264c7b8bed 100644 > --- a/drivers/gpu/drm/vc4/vc4_dsi.c > +++ b/drivers/gpu/drm/vc4/vc4_dsi.c > @@ -822,7 +822,7 @@ static void vc4_dsi_encoder_disable(struct drm_encode= r *encoder) > clk_disable_unprepare(dsi->escape_clock); > clk_disable_unprepare(dsi->pixel_clock); >=20=20 > - pm_runtime_put(dev); > + pm_runtime_put_sync(dev); > } >=20=20 > /* Extends the mode's blank intervals to handle BCM2835's integer-only > --=20 > 2.17.1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlyiTtsACgkQtdYpNtH8 nuiblhAAuZlE5rdargq/hV2o5vTgMuNRzXxg+2e8mwv41EVmQBYZRf0Xr13zGkkJ YqR/uiL4KMtbLqcldyCVujVruH86s/ns6zvYKwIsROzAQRxe1W0fqGgn+zrLgloW iQ+gX+LM/HXwAnkzqsV/kEFjpagZN+FwcvSvjhEtPtXOdQDCeG3ic+GMLJ+XQuMf +8WXQE+igMwYJVrAma8a2AlyZ5Pfj591luync2T/p+Qny3zNhgY4b7MSZ+ga/2GQ i5JU+nytJkLe6USBW23cQvsNkO9IUY9yvTXO8LSpJ7z2pif9E/yuXZb1oCTRhoQj 8dwTvELAfAN8UuIQAn2ye3uHaAOalsnke1w333AdXQGGuzA0t1crFBatp2YjOg6J eXYguaAfcCacn34bkmbaNZ/fKzzV4Fgb1CRpY+svbmce3nRLUMjqRfNLYFFsi/sI 0x2WTZKW0SFXYnhXEOxwGH0HJiIAHVKa5lIRzPZDK1owKrEJEzWlgYemSjIX15zT 9kDDiByT4qXk1yjxX5XNNzJv4t4sEScGVImOfCIaVHLwrBHxsN4H7ag67Bk0Hwin KmUOikrxdHtGsOb+UGgsKjojI/ulngqgmihEDANWFNrWXJXCleaRabNjzMtcOanM Uu4jJut/vO20NRoPqaSGdtiRtjjE18tb5q4iE9qNiwEmS4R14GA= =dItW -----END PGP SIGNATURE----- --=-=-=-- --===============1156511684== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1156511684==--