From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH v8] drm: Add library for shmem backed GEM objects
Date: Wed, 13 Mar 2019 13:56:36 -0700
Message-ID: <87bm2etrwb.fsf@anholt.net>
References: <20190313004344.24169-1-robh@kernel.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1916311747=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from anholt.net (anholt.net [50.246.234.109])
 by gabe.freedesktop.org (Postfix) with ESMTP id 2EAE489F07
 for <dri-devel@lists.freedesktop.org>; Wed, 13 Mar 2019 20:56:40 +0000 (UTC)
In-Reply-To: <20190313004344.24169-1-robh@kernel.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Rob Herring <robh@kernel.org>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

--===============1916311747==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Rob Herring <robh@kernel.org> writes:

> From: Noralf Tr=C3=B8nnes <noralf@tronnes.org>
>
> This adds a library for shmem backed GEM objects.

I read through the whole thing, and the only bit I didn't like
(drm_gem_shmem_create_with_handle returns an unrefcounted object
pointer) was a copy-and-paste from CMA that we should fix in both
places, and has no downside in the current usage since the pointer value
is unused.  Just one question left:

> v7:
> - Use write-combine for mmap instead. This is the more common
>   case. (robher)

I don't actually see this in the code.  Wasn't there supposed to be a:

       vma->vm_page_prot =3D pgprot_writecombine(vm_get_page_prot(vma->vm_f=
lags));

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlyJboQACgkQtdYpNtH8
nuhzig/9HjEoSKdxnoyREGjYlKQ28h1XZHIpzojvece0AIhu93jb5GAcPYyjgXKu
ZPdLxGpKwGGwja/mkcNH2HFWrfb7ak+UEJY0xNaMrBc+LUqlLOvaFilouIGfNwrO
NNcnZoIwfo3u6iKwWrVvCkyGSe6T+I/QdHYx2X52HnecPGJQj7oWxzQusBdn5k29
hw4MNx9vy0D7TSTiFjhC4wTtMARIycKfBolu3UNBUQpJ6by4s4FExyrPqg2y5jzw
ZRacQWe0yHwqyRagHRMaq44CzsFGlW9xrRd0Jr/V8G9yxH+Nr/KIqv7QiYxR6AN3
vph5zyjZ0mvu02+bIRmKF4S2KCkTch8bHWGQdh5dKb4gu78D4DNr3CqmnqThQTVI
wNsFTyCMbhvnU3jO9oKmzZ6S0QeQ0qhjneBaI2WiE8ssvVQngVZTGSiXw7uGbtqC
nLdlyZVvD+EE2fcpJco9xY8QkosLh40j+EEVT7ccg4QCe/AMk8Duv73O9TBPbscs
1ZmbpJQr5Fp8fyN0V3bo5KXdTVoY2p2pf2kzRuulG02mxcCojgDDMHw/diLrVErT
aOkFjova/yWN4BzhGQFkI8+r7prZXebmoHPVt056ousvcrExlTD2XSbWlsl3fo4I
t4uzyKbe1cW8ipOxOmKZwy3xcm7reHBx/uvxOYIYqT9mlWky05U=
=G27c
-----END PGP SIGNATURE-----
--=-=-=--

--===============1916311747==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs

--===============1916311747==--