From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/3] drm/i915: Use intel_engine_stop_cs when stopping ringbuffer Date: Thu, 28 Feb 2019 18:53:46 +0200 Message-ID: <87bm2vvopx.fsf@gaia.fi.intel.com> References: <20190228160133.819-1-mika.kuoppala@linux.intel.com> <20190228161411.10462-1-mika.kuoppala@linux.intel.com> <155137168789.5847.2160231273636703233@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC1AA6E20C for ; Thu, 28 Feb 2019 16:54:14 +0000 (UTC) In-Reply-To: <155137168789.5847.2160231273636703233@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu ZyBNaWthIEt1b3BwYWxhICgyMDE5LTAyLTI4IDE2OjE0OjExKQo+PiBXZSBoYXZlIGFuIGV4cG9y dGVkIGZ1bmN0aW9uIGZvciBzdG9wcGluZyB0aGUgZW5naW5lIGJlZm9yZQo+PiBkaXNhYmxpbmcg YSByaW5nYnVmZmVyLiBUYWtlIGl0IGludG8gdXNlLgo+PiAKPj4gdjI6IHVzZSBmdyBvbiBlbXB0 eSBjaGVjawo+PiB2MzogdGFpbCBpcyB0YWlsCj4+IAo+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJp c0BjaHJpcy13aWxzb24uY28udWs+Cj4+IFNpZ25lZC1vZmYtYnk6IE1pa2EgS3VvcHBhbGEgPG1p a2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+PiBSZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29u IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZW5naW5lX2NzLmMgIHwgIDMgKysKPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3JpbmdidWZmZXIuYyB8IDQxICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPj4gIDIgZmls ZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+PiBpbmRleCBkZjhmODgxNDJmMWQuLmUz NWRjMDM4NmJmNiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5n aW5lX2NzLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMK Pj4gQEAgLTg1Niw2ICs4NTYsOSBAQCB2b2lkIGludGVsX2VuZ2luZV9jYW5jZWxfc3RvcF9jcyhz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+ICB7Cj4+ICAgICAgICAgc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZW5naW5lLT5pOTE1Owo+PiAgCj4+ICsgICAgICAg aWYgKElOVEVMX0dFTihkZXZfcHJpdikgPCAzKQo+PiArICAgICAgICAgICAgICAgcmV0dXJuOwo+ PiArCj4+ICAgICAgICAgR0VNX1RSQUNFKCIlc1xuIiwgZW5naW5lLT5uYW1lKTsKPj4gIAo+PiAg ICAgICAgIEk5MTVfV1JJVEVfRlcoUklOR19NSV9NT0RFKGVuZ2luZS0+bW1pb19iYXNlKSwKPj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+PiBpbmRleCAxYjk2YjA5NjBh ZGMuLjVmZTI4ZDkwODdiNyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcmluZ2J1ZmZlci5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jpbmdi dWZmZXIuYwo+PiBAQCAtNjA0LDI2ICs2MDQsMzIgQEAgc3RhdGljIHZvaWQgcmluZ19zZXR1cF9z dGF0dXNfcGFnZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+ICAgICAgICAgZmx1 c2hfY3NfdGxiKGVuZ2luZSk7Cj4+ICB9Cj4+ICAKPj4gK3N0YXRpYyBib29sIHJpbmdfaXNfZW1w dHkoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+PiArewo+PiArICAgICAgIHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGVuZ2luZS0+aTkxNTsKPj4gKyAgICAgICBj b25zdCB1MzIgYmFzZSA9IGVuZ2luZS0+bW1pb19iYXNlOwo+PiArCj4+ICsgICAgICAgcmV0dXJu IChJOTE1X1JFQURfRlcoUklOR19IRUFEKGJhc2UpKSAmIEhFQURfQUREUikgPT0KPj4gKyAgICAg ICAgICAgICAgIChJOTE1X1JFQURfRlcoUklOR19UQUlMKGJhc2UpKSAmIFRBSUxfQUREUik7Cj4+ ICt9Cj4+ICsKPj4gIHN0YXRpYyBib29sIHN0b3BfcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUpCj4+ICB7Cj4+ICAgICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gZW5naW5lLT5pOTE1Owo+PiArICAgICAgIGludCByZXQ7Cj4+ICAKPj4gLSAgICAgICBp ZiAoSU5URUxfR0VOKGRldl9wcml2KSA+IDIpIHsKPj4gLSAgICAgICAgICAgICAgIEk5MTVfV1JJ VEVfTU9ERShlbmdpbmUsIF9NQVNLRURfQklUX0VOQUJMRShTVE9QX1JJTkcpKTsKPj4gLSAgICAg ICAgICAgICAgIGlmIChpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwKPj4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBSSU5HX01JX01PREUoZW5naW5l LT5tbWlvX2Jhc2UpLAo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIE1PREVfSURMRSwKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBNT0RFX0lETEUsCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgMTAwMCkpIHsKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgRFJNX0VSUk9SKCIlcyA6 IHRpbWVkIG91dCB0cnlpbmcgdG8gc3RvcCByaW5nXG4iLAo+PiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZW5naW5lLT5uYW1lKTsKPj4gLSAgICAgICAgICAgICAgICAgICAgICAg LyogU29tZXRpbWVzIHdlIG9ic2VydmUgdGhhdCB0aGUgaWRsZSBmbGFnIGlzIG5vdAo+PiAtICAg ICAgICAgICAgICAgICAgICAgICAgKiBzZXQgZXZlbiB0aG91Z2ggdGhlIHJpbmcgaXMgZW1wdHku IFNvIGRvdWJsZQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgKiBjaGVjayBiZWZvcmUgZ2l2 aW5nIHVwLgo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgKi8KPj4gLSAgICAgICAgICAgICAg ICAgICAgICAgaWYgKEk5MTVfUkVBRF9IRUFEKGVuZ2luZSkgIT0gSTkxNV9SRUFEX1RBSUwoZW5n aW5lKSkKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4+ IC0gICAgICAgICAgICAgICB9Cj4+ICsgICAgICAgcmV0ID0gaW50ZWxfZW5naW5lX3N0b3BfY3Mo ZW5naW5lKTsKPj4gKyAgICAgICBpZiAocmV0ID09IC1FTk9ERVYpCj4+ICsgICAgICAgICAgICAg ICByZXQgPSAwOwo+PiArCj4+ICsgICAgICAgaWYgKHJldCkgewo+PiArICAgICAgICAgICAgICAg LyoKPj4gKyAgICAgICAgICAgICAgICAqIFNvbWV0aW1lcyB3ZSBvYnNlcnZlIHRoYXQgdGhlIGlk bGUgZmxhZyBpcyBub3QKPj4gKyAgICAgICAgICAgICAgICAqIHNldCBldmVuIHRob3VnaCB0aGUg cmluZyBpcyBlbXB0eS4gU28gZG91YmxlCj4+ICsgICAgICAgICAgICAgICAgKiBjaGVjayBiZWZv cmUgZ2l2aW5nIHVwLgo+PiArICAgICAgICAgICAgICAgICovCj4+ICsgICAgICAgICAgICAgICBp ZiAoIXJpbmdfaXNfZW1wdHkoZW5naW5lKSkKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwo+Cj4gSG1tLCB0aGlua2luZyBtb3JlIGFib3V0IHRoaXMsIHNob3VsZG4ndCB3 ZSBwdXNoIHRoaXMgZG93biB0byBzdG9wX2NzKCk/Cj4KPiBJZiB0aGF0J3MgcmVwb3J0aW5nIGFu IGVycm9yIGluIGEgc2l0dWF0aW9uIHdoZXJlIHdlIGNhbiBkZXRlcm1pbmUgdGhhdAo+IHRoZSBy aW5nIGlzIGlkbGUgYW55d2F5LCB3ZSBjYW4gcmVwb3J0IHRoZSBzdG9wX2NzIHN1Y2NlZWRlZC4K Ck1ha2VzIHNlbnNlLCBJIHdpbGwgdGFrZSBhIGxvb2suCgpJIGZlbHQgc21hbGwgdXJnZSB0byBk ZWZsYXRlIHRoZSAnc3RvcCcuCgpXb3VsZCBpdCBiZSBjb25mdXNpbmcgaWYgd2UganVzdCBkaWQK aW50ZWxfZW5naW5lX3N0YXJ0fHN0b3AgaW5zdGVhZCBvZiBzdG9wX2NzIGFuZApjYW5jZWxfc3Rv cF9jcz8KClNvIGhtbToKCmludGVsX2VuZ2luZV9zdGFydCgpCmludGVsX2VuZ2luZV9zdG9wKCkK CnRoZXNlIHdvdWxkIG9ubHkgdG9nZ2xlIHRoZSBTVE9QX1JJTkcKCmFuZCBmb3IgcmVwbGFjaW5n IHN0b3BfcmluZyB3aXRoOgppbnRlbF9lbmdpbmVfZW1wdHlfcmluZygpCgpmb3IgemVyb2luZyB0 aGUgaGVhZHMuCgpvbmUgJ3N0b3AnIHRvIHJ1bGUgdGhlIChyaW5nKXdvcmxkIT8KCi1NaWthCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==