From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Seeking QEMU makefile advice
Date: Wed, 13 Feb 2019 17:15:50 +0100 [thread overview]
Message-ID: <87bm3f4qbt.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <9e429792-cbea-c96c-ad48-7f5bdd7ef781@redhat.com> (Paolo Bonzini's message of "Wed, 13 Feb 2019 15:18:31 +0100")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 13/02/19 10:49, Markus Armbruster wrote:
>> * Define QAPI_COMMON_MODULES, QAPI_TARGET_MODULES and QAPI_MODULES in
>> Makefile.obj
>>
>> * Add to util-obj-y in Makefile.obj
>>
>> * Add to obj-y in Makefile.target
>
> Why can't both be in Makefile.objs, or in qapi/Makefile.objs?
When I try either place, I get
LINK x86_64-softmmu/qemu-system-x86_64
monitor.o: In function `qmp_query_qmp_schema':
/work/armbru/qemu/monitor.c:1136: undefined reference to `qmp_schema_qlit'
[more errors...]
Compiling with V=1 confirms qapi-introspect.o isn't in $(all-obj-y).
I think this is the case because Makefile.target has
all-obj-y := $(obj-y)
before
include $(SRC_PATH)/Makefile.objs
If I move the former below the latter (without really understanding the
consequences), I get
make[1]: *** No rule to make target '9pfs/', needed by 'qemu-system-x86_64'.
make[1]: *** No rule to make target 'acpi/', needed by 'qemu-system-x86_64'.
make[1]: *** No rule to make target 'adc/', needed by 'qemu-system-x86_64'.
[many, many more...]
What now?
next prev parent reply other threads:[~2019-02-13 16:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 9:49 [Qemu-devel] Seeking QEMU makefile advice Markus Armbruster
2019-02-13 14:18 ` Paolo Bonzini
2019-02-13 16:15 ` Markus Armbruster [this message]
2019-02-13 16:19 ` Paolo Bonzini
2019-02-14 8:30 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm3f4qbt.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.