All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: kbuild-all@01.org
Subject: Re: [PATCH] drm/i915/perf: Annotate i915_perf.wakeref for keneldoc
Date: Tue, 15 Jan 2019 12:45:50 +0200	[thread overview]
Message-ID: <87bm4iyza9.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190115102505.4843-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> drivers/gpu/drm/i915/i915_drv.h:1375: warning: Function parameter or member 'wakeref' not described in 'i915_perf_stream'
>
> Reported-by: kbuild-all@01.org
> Fixes: 6619c0075f78 ("drm/i915/perf: Track the rpm wakeref")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_drv.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index fa99824f63b3..956c1c86f90d 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1336,6 +1336,10 @@ struct i915_perf_stream {
>  	 */
>  	struct list_head link;
>  
> +	/**
> +	 * @wakeref: As we keep the device awake while the perf stream is
> +	 * active, we track our runtime pm reference for later release.
> +	 */
>  	intel_wakeref_t wakeref;
>  
>  	/**
> -- 
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-01-15 10:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 10:25 [PATCH] drm/i915/perf: Annotate i915_perf.wakeref for keneldoc Chris Wilson
2019-01-15 10:45 ` Mika Kuoppala [this message]
2019-01-15 11:09   ` Chris Wilson
2019-01-15 14:44     ` Mika Kuoppala
2019-01-15 14:48       ` Chris Wilson
2019-01-15 10:51 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-01-15 11:08 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-15 14:10 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm4iyza9.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kbuild-all@01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.