All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fixup kerneldoc for intel_device_info_runtime_init
Date: Mon, 07 Jan 2019 11:52:43 +0200	[thread overview]
Message-ID: <87bm4s94lw.fsf@intel.com> (raw)
In-Reply-To: <20190105014652.3472-1-chris@chris-wilson.co.uk>

On Sat, 05 Jan 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>   CC [M]  drivers/gpu/drm/i915/intel_device_info.o
> drivers/gpu/drm/i915/intel_device_info.c:727: warning: Function parameter or member 'dev_priv' not described in 'intel_device_info_runtime_init'
> drivers/gpu/drm/i915/intel_device_info.c:727: warning: Excess function parameter 'info' description in 'intel_device_info_runtime_init'
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>

Sorry and thanks.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/intel_device_info.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index e0ce0c9791fc..855a5074ad77 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -709,7 +709,7 @@ static u32 read_timestamp_frequency(struct drm_i915_private *dev_priv)
>  
>  /**
>   * intel_device_info_runtime_init - initialize runtime info
> - * @info: intel device info struct
> + * @dev_priv: the i915 device
>   *
>   * Determine various intel_device_info fields at runtime.
>   *

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-01-07  9:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-05  1:46 [PATCH] drm/i915: Fixup kerneldoc for intel_device_info_runtime_init Chris Wilson
2019-01-05  2:34 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-05  3:41 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-07  9:44 ` [PATCH] " Joonas Lahtinen
2019-01-07  9:52 ` Jani Nikula [this message]
2019-01-07  9:57   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm4s94lw.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.