From: Jani Nikula <jani.nikula@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition
Date: Fri, 16 Nov 2018 12:54:00 +0200 [thread overview]
Message-ID: <87bm6pgunr.fsf@intel.com> (raw)
In-Reply-To: <154236482065.10902.11931625551035935281@jlahtine-desk.ger.corp.intel.com>
On Fri, 16 Nov 2018, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> Quoting Jani Nikula (2018-11-15 14:01:24)
>> No need to use a compound statement enclosed in parenthesis where a C99
>> compound literal will do. No functional changes.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Out of curiosity, did this have an effect on asm generation?
> Presumably not.
For some reason it caused tons of label etc. changes so it was hard to
check, but I didn't spot any functional asm changes.
BR,
Jani.
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Regards, Joonas
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-16 10:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 12:01 [PATCH 1/5] drm/i915: extract fixed point math to i915_fixed.h Jani Nikula
2018-11-15 12:01 ` [PATCH 2/5] drm/i915/fixed: prefer kernel types over stdint types Jani Nikula
2018-11-16 10:38 ` Joonas Lahtinen
2018-11-15 12:01 ` [PATCH 3/5] drm/i915/fixed: simplify FP_16_16_MAX definition Jani Nikula
2018-11-16 10:40 ` Joonas Lahtinen
2018-11-16 10:54 ` Jani Nikula [this message]
2018-11-16 10:52 ` Chris Wilson
2018-11-20 11:12 ` Jani Nikula
2018-11-15 12:01 ` [PATCH 4/5] drm/i915/fixed: simplify is_fixed16_zero() Jani Nikula
2018-11-16 10:40 ` Joonas Lahtinen
2018-11-15 12:01 ` [PATCH 5/5] drm/i915/fixed: cosmetic cleanup Jani Nikula
2018-11-16 10:56 ` Joonas Lahtinen
2018-11-15 12:57 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h Patchwork
2018-11-15 13:00 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-15 13:14 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-15 15:55 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-16 10:36 ` [PATCH 1/5] " Joonas Lahtinen
2018-11-16 10:52 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm6pgunr.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.