From: Kalle Valo <kvalo@codeaurora.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76x0: run calibration after scanning
Date: Tue, 30 Oct 2018 12:23:40 +0200 [thread overview]
Message-ID: <87bm7bg2c3.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20181030093655.GA26345@redhat.com> (Stanislaw Gruszka's message of "Tue, 30 Oct 2018 10:36:56 +0100")
Stanislaw Gruszka <sgruszka@redhat.com> writes:
> On Mon, Oct 29, 2018 at 04:25:31PM +0200, Kalle Valo wrote:
>> Stanislaw Gruszka <sgruszka@redhat.com> writes:
>>
>> > If we are associated and scanning is performed , sw_scan_complete callback
>> > is done after we get back to operating channel, so we do not perform
>> > phy calibration and queue cal work. Fix this by run calibration from
>> > sw_scan_complete().
>> >
>> > Fixes: bbd10586f0df ("mt76x0: phy: do not run calibration during channel switch")
>> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
>> > ---
>> > This is for 4.20
>>
>> So what are the symptoms from user's point of view? Is this a
>> regression?
>
> We do not perform gain calibration any longer if somebody will
> request scan after association. This is formally a regression,
> but calibration code changed a lot, so perhaps this can be dropped
> for 4.20 and eventually go through -stable if I can confirm
> it fixes performance problems.
To me that would be a much better option, less conflicts that way.
--
Kalle Valo
next prev parent reply other threads:[~2018-10-30 10:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 10:16 [PATCH] mt76x0: run calibration after scanning Stanislaw Gruszka
2018-10-29 14:25 ` Kalle Valo
2018-10-30 9:36 ` Stanislaw Gruszka
2018-10-30 10:23 ` Kalle Valo [this message]
2018-10-30 9:39 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm7bg2c3.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.