From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBvqt-0004GY-Fo for qemu-devel@nongnu.org; Mon, 15 Oct 2018 01:55:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gBvqp-0003mn-9c for qemu-devel@nongnu.org; Mon, 15 Oct 2018 01:55:39 -0400 From: Markus Armbruster References: <20181013050227.17022-1-ehabkost@redhat.com> <219bba9b-4102-f838-a46f-11b9704ca78f@redhat.com> <20181013203607.GL31060@habkost.net> <0547ccec-6b85-a03f-88e3-74baa5ab4273@redhat.com> Date: Mon, 15 Oct 2018 07:55:26 +0200 In-Reply-To: <0547ccec-6b85-a03f-88e3-74baa5ab4273@redhat.com> (Max Reitz's message of "Sun, 14 Oct 2018 13:39:44 +0200") Message-ID: <87bm7v69f5.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RFC] Require Python 3 for building QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Eduardo Habkost , Kevin Wolf , Peter Maydell , qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi , Cleber Rosa , Fam Zheng , Alex =?utf-8?Q?Be?= =?utf-8?Q?nn=C3=A9e?= , Philippe =?utf-8?Q?Mathi?= =?utf-8?Q?eu-Daud=C3=A9?= Max Reitz writes: > On 13.10.18 22:36, Eduardo Habkost wrote: >> On Sat, Oct 13, 2018 at 08:20:25PM +0200, Max Reitz wrote: >>> On 13.10.18 07:02, Eduardo Habkost wrote: >>>> Signed-off-by: Eduardo Habkost >>>> --- >>>> I'd like to do this in QEMU 3.1. I think it's time to drop >>>> support for old systems that have only Python 2. >>>> >>>> We still have a few scripts that are not required for building >>>> QEMU that still work only with Python 2 (iotests being the most >>>> relevant set). Requiring Python 3 for building QEMU won't >>>> prevent people from using those scripts with Python 2 until they >>>> are finally ported. >>> >>> It very much does because the iotests specifically use the python path >>> qemu was configured with. >>> >>> To fix this, configure would need to write something else for into >>> tests/qemu-iotests/common.env for $PYTHON. But what? I don't really >>> want to introduce a new configure option for this. >> >> What's wrong with '/usr/bin/env python2' and just using the >> python2 binary from $PATH? Why do we need to make the Python >> interpreter path for iotests configurable? > > Nothing, sounds good. No idea why I discarded that idea. > >>> So the real fix is indeed to make the iotests work with Python 3, and I >>> think that needs to be done before we can require Python 3. Maybe it >>> even needs to be done at the same time. >> >> I agree that this would be even better. I just don't think the >> pending iotest porting should force all the rest of the build >> scripts to be compatible with Python 2. > > True. It just means that we have to do something about the iotests > before this patch can be merged. I keep hearing about that "we" guy, and all the stuff he has to do, but I've never seen him deliver anything.