All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.clement@bootlin.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: clearfog-gt-8k: add PCIe slot description
Date: Wed, 03 Oct 2018 17:22:55 +0200	[thread overview]
Message-ID: <87bm8bm4vk.fsf@bootlin.com> (raw)
In-Reply-To: <20181003134345.id34eoianoeeodvs@sapphire.tkos.co.il> (Baruch Siach's message of "Wed, 3 Oct 2018 16:43:45 +0300")

Hi Baruch,
 
 On mer., oct. 03 2018, Baruch Siach <baruch@tkos.co.il> wrote:

> Hi Andrew,
>
> On Wed, Oct 03, 2018 at 03:31:10PM +0200, Andrew Lunn wrote:
>> On Wed, Oct 03, 2018 at 04:23:01PM +0300, Baruch Siach wrote:
>> > This adds support for the PCIe interface on the CON4 mini-PCIe
>> > connector.
>> 
>> Is there a dependency between this and the implementation of the
>> reset-gpios? It would be good to at least mention if there is/is not
>> such a dependency. You could put it under the ---.
>
> There is no hard dependency between the patches. This patch is about hardware 
> description which is correct regardless of software implementation. For the 
> hardware to work you need to toggle the reset signal. But you can also do that 
> in the bootloader if the kernel does not support reset-gpios.
>
> baruch
>
>> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Applied on mvebu/dt64

Thanks,

Gregory

>> > ---
>> >  arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 7 +++++++
>> >  1 file changed, 7 insertions(+)
>> > 
>> > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
>> > index 2e06d82bec58..a13549749ee7 100644
>> > --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
>> > +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
>> > @@ -233,6 +233,13 @@
>> >  	};
>> >  };
>> >  
>> > +&cp0_pcie0 {
>> > +	pinctrl-names = "default";
>> > +	pinctrl-0 = <&cp0_pci0_reset_pins>;
>> > +	reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
>> > +	status = "okay";
>> > +};
>> > +
>> >  &cp0_gpio2 {
>> >  	sata_reset {
>> >  		gpio-hog;
>
> -- 
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

      reply	other threads:[~2018-10-03 15:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 13:23 [PATCH] arm64: dts: clearfog-gt-8k: add PCIe slot description Baruch Siach
2018-10-03 13:31 ` Andrew Lunn
2018-10-03 13:43   ` Baruch Siach
2018-10-03 15:22     ` Gregory CLEMENT [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm8bm4vk.fsf@bootlin.com \
    --to=gregory.clement@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.