From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from out01.mta.xmission.com ([166.70.13.231]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fs5xz-00059r-9K for kexec@lists.infradead.org; Tue, 21 Aug 2018 12:41:00 +0000 From: ebiederm@xmission.com (Eric W. Biederman) References: <20180801210804.175176-1-ndesaulniers@google.com> Date: Tue, 21 Aug 2018 14:40:02 +0200 In-Reply-To: (Linus Torvalds's message of "Mon, 20 Aug 2018 16:48:38 -0700") Message-ID: <87bm9v28rh.fsf@xmission.com> MIME-Version: 1.0 Subject: Re: [PATCH] x86/kexec: prefer _THIS_IP_ to current_text_addr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Linus Torvalds Cc: Kate Stewart , Simon Horman , Philippe Ombredanne , Greg Kroah-Hartman , the arch/x86 maintainers , Nick Desaulniers , Linux Kernel Mailing List , Kexec Mailing List , natechancellor@gmail.com, Ingo Molnar , Peter Anvin , Thomas Gleixner , Andrew Morton Linus Torvalds writes: > On Mon, Aug 20, 2018 at 10:58 AM Nick Desaulniers > wrote: >> >> + akpm, Linus >> >> Bumping for review. > > Ugh. I am not personally a huge fan of this endless "fix up one at a time". > > Just do a patch that removes current_text_addr() entirely and be done > with it, if that's what we want the end result to be. > > Don't bother with these small "let's remove the remaining ones one by > one". Just get it over and done with. One is generic code the other is assembly but the both appear to do the same thing without unexpected complexity. That said the patch earlier in this thread has clearly never been compiled as it is using THIS_IP instead of _THIS_IP_ and there is not a define of THIS_IP in the kernel. Eric _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C038C4321D for ; Tue, 21 Aug 2018 12:40:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D96852151D for ; Tue, 21 Aug 2018 12:40:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D96852151D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xmission.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727223AbeHUQAb (ORCPT ); Tue, 21 Aug 2018 12:00:31 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:49033 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726775AbeHUQAb (ORCPT ); Tue, 21 Aug 2018 12:00:31 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fs5xU-0002ys-H8; Tue, 21 Aug 2018 06:40:28 -0600 Received: from [105.224.248.17] (helo=x220.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1fs5xE-0000nD-Jo; Tue, 21 Aug 2018 06:40:28 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Linus Torvalds Cc: Nick Desaulniers , Thomas Gleixner , Ingo Molnar , Peter Anvin , Simon Horman , Andrew Morton , natechancellor@gmail.com, "the arch\/x86 maintainers" , Philippe Ombredanne , Kate Stewart , Greg Kroah-Hartman , Linux Kernel Mailing List , Kexec Mailing List References: <20180801210804.175176-1-ndesaulniers@google.com> Date: Tue, 21 Aug 2018 14:40:02 +0200 In-Reply-To: (Linus Torvalds's message of "Mon, 20 Aug 2018 16:48:38 -0700") Message-ID: <87bm9v28rh.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1fs5xE-0000nD-Jo;;;mid=<87bm9v28rh.fsf@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=105.224.248.17;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX183i7m6VAJKDbk/tSZH55UsXBjfKw/gkXQ= X-SA-Exim-Connect-IP: 105.224.248.17 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] x86/kexec: prefer _THIS_IP_ to current_text_addr X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds writes: > On Mon, Aug 20, 2018 at 10:58 AM Nick Desaulniers > wrote: >> >> + akpm, Linus >> >> Bumping for review. > > Ugh. I am not personally a huge fan of this endless "fix up one at a time". > > Just do a patch that removes current_text_addr() entirely and be done > with it, if that's what we want the end result to be. > > Don't bother with these small "let's remove the remaining ones one by > one". Just get it over and done with. One is generic code the other is assembly but the both appear to do the same thing without unexpected complexity. That said the patch earlier in this thread has clearly never been compiled as it is using THIS_IP instead of _THIS_IP_ and there is not a define of THIS_IP in the kernel. Eric