From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH 13/31] drm/i915: Move the irq_counter inside
 the spinlock
Date: Wed, 27 Jun 2018 17:23:59 +0300
Message-ID: <87bmbwux34.fsf@gaia.fi.intel.com>
References: <20180625094842.8499-1-chris@chris-wilson.co.uk>
 <20180625094842.8499-13-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A7FD36E98C
 for <intel-gfx@lists.freedesktop.org>; Wed, 27 Jun 2018 14:24:43 +0000 (UTC)
In-Reply-To: <20180625094842.8499-13-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUmF0aGVy
IHRoYW4gaGF2ZSBtdWx0aXBsZSBsb2NrZWQgaW5zdHJ1Y3Rpb25zIGluc2lkZSB0aGUgbm90aWZ5
X3JpbmcoKQo+IGlycSBoYW5kbGVyLCBtb3ZlIHRoZW0gaW5zaWRlIHRoZSBzcGlubG9jayBhbmQg
cmVkdWNlIHRoZWlyIGludHJpbnNpYwo+IGxvY2tpbmcuCj4KCkxlc3MgaXMgYmV0dGVyLCBjb3Vs
ZCBub3RlIGluIGNvbW1pdCBtZXNzYWdlIHRoYXQgd2Ugb21pdCB0aGUgbm9uCndhaXQgb25lcy4K
ClJldmlld2VkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNv
bT4KCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u
dWs+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgICAgICAgICAgfCAg
NCArKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jICAgICAgfCAgNCAr
Ky0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMgfCAxMSArKysr
KysrLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggIHwgIDIg
Ky0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+
Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gaW5kZXggNTNkYWQ0OGY5MmNlLi42NzMwYzFhN2Yx
MzUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ICsrKyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBAQCAtMTE1Myw4ICsxMTUzLDYgQEAg
c3RhdGljIHZvaWQgbm90aWZ5X3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+
ICAJaWYgKHVubGlrZWx5KCFlbmdpbmUtPmJyZWFkY3J1bWJzLmlycV9hcm1lZCkpCj4gIAkJcmV0
dXJuOwo+ICAKPiAtCWF0b21pY19pbmMoJmVuZ2luZS0+aXJxX2NvdW50KTsKPiAtCj4gIAlyY3Vf
cmVhZF9sb2NrKCk7Cj4gIAo+ICAJc3Bpbl9sb2NrKCZlbmdpbmUtPmJyZWFkY3J1bWJzLmlycV9s
b2NrKTsKPiBAQCAtMTE4OSw2ICsxMTg3LDggQEAgc3RhdGljIHZvaWQgbm90aWZ5X3Jpbmcoc3Ry
dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJCQkJdHNrID0gd2FpdC0+dHNrOwo+ICAJ
CQl9Cj4gIAkJfQo+ICsKPiArCQllbmdpbmUtPmJyZWFkY3J1bWJzLmlycV9jb3VudCsrOwo+ICAJ
fSBlbHNlIHsKPiAgCQlpZiAoZW5naW5lLT5icmVhZGNydW1icy5pcnFfYXJtZWQpCj4gIAkJCV9f
aW50ZWxfZW5naW5lX2Rpc2FybV9icmVhZGNydW1icyhlbmdpbmUpOwo+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfcmVxdWVzdC5jCj4gaW5kZXggMTFmMTc1NTU0ZGE4Li42OTYxMjU2NjMxMDUgMTAwNjQ0
Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMKPiArKysgYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYwo+IEBAIC0xMTYxLDcgKzExNjEsNyBAQCBz
dGF0aWMgYm9vbCBfX2k5MTVfc3Bpbl9yZXF1ZXN0KGNvbnN0IHN0cnVjdCBpOTE1X3JlcXVlc3Qg
KnJxLAo+ICAJICogdGFrZXMgdG8gc2xlZXAgb24gYSByZXF1ZXN0LCBvbiB0aGUgb3JkZXIgb2Yg
YSBtaWNyb3NlY29uZC4KPiAgCSAqLwo+ICAKPiAtCWlycSA9IGF0b21pY19yZWFkKCZlbmdpbmUt
PmlycV9jb3VudCk7Cj4gKwlpcnEgPSBSRUFEX09OQ0UoZW5naW5lLT5icmVhZGNydW1icy5pcnFf
Y291bnQpOwo+ICAJdGltZW91dF91cyArPSBsb2NhbF9jbG9ja191cygmY3B1KTsKPiAgCWRvIHsK
PiAgCQlpZiAoaTkxNV9zZXFub19wYXNzZWQoaW50ZWxfZW5naW5lX2dldF9zZXFubyhlbmdpbmUp
LCBzZXFubykpCj4gQEAgLTExNzMsNyArMTE3Myw3IEBAIHN0YXRpYyBib29sIF9faTkxNV9zcGlu
X3JlcXVlc3QoY29uc3Qgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEsCj4gIAkJICogYXNzdW1lIHdl
IHdvbid0IHNlZSBvbmUgaW4gdGhlIG5lYXIgZnV0dXJlIGJ1dCByZXF1aXJlCj4gIAkJICogdGhl
IGVuZ2luZS0+c2Vxbm9fYmFycmllcigpIHRvIGZpeHVwIGNvaGVyZW5jeS4KPiAgCQkgKi8KPiAt
CQlpZiAoYXRvbWljX3JlYWQoJmVuZ2luZS0+aXJxX2NvdW50KSAhPSBpcnEpCj4gKwkJaWYgKFJF
QURfT05DRShlbmdpbmUtPmJyZWFkY3J1bWJzLmlycV9jb3VudCkgIT0gaXJxKQo+ICAJCQlicmVh
azsKPiAgCj4gIAkJaWYgKHNpZ25hbF9wZW5kaW5nX3N0YXRlKHN0YXRlLCBjdXJyZW50KSkKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMKPiBpbmRleCA4NmE5ODdiOGFj
NjYuLjFkYjZiYTdkOTI2ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9icmVhZGNydW1icy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRj
cnVtYnMuYwo+IEBAIC05OCwxMiArOTgsMTQgQEAgc3RhdGljIHZvaWQgaW50ZWxfYnJlYWRjcnVt
YnNfaGFuZ2NoZWNrKHN0cnVjdCB0aW1lcl9saXN0ICp0KQo+ICAJc3RydWN0IGludGVsX2VuZ2lu
ZV9jcyAqZW5naW5lID0KPiAgCQlmcm9tX3RpbWVyKGVuZ2luZSwgdCwgYnJlYWRjcnVtYnMuaGFu
Z2NoZWNrKTsKPiAgCXN0cnVjdCBpbnRlbF9icmVhZGNydW1icyAqYiA9ICZlbmdpbmUtPmJyZWFk
Y3J1bWJzOwo+ICsJdW5zaWduZWQgaW50IGlycV9jb3VudDsKPiAgCj4gIAlpZiAoIWItPmlycV9h
cm1lZCkKPiAgCQlyZXR1cm47Cj4gIAo+IC0JaWYgKGItPmhhbmdjaGVja19pbnRlcnJ1cHRzICE9
IGF0b21pY19yZWFkKCZlbmdpbmUtPmlycV9jb3VudCkpIHsKPiAtCQliLT5oYW5nY2hlY2tfaW50
ZXJydXB0cyA9IGF0b21pY19yZWFkKCZlbmdpbmUtPmlycV9jb3VudCk7Cj4gKwlpcnFfY291bnQg
PSBSRUFEX09OQ0UoYi0+aXJxX2NvdW50KTsKPiArCWlmIChiLT5oYW5nY2hlY2tfaW50ZXJydXB0
cyAhPSBpcnFfY291bnQpIHsKPiArCQliLT5oYW5nY2hlY2tfaW50ZXJydXB0cyA9IGlycV9jb3Vu
dDsKPiAgCQltb2RfdGltZXIoJmItPmhhbmdjaGVjaywgd2FpdF90aW1lb3V0KCkpOwo+ICAJCXJl
dHVybjsKPiAgCX0KPiBAQCAtMjcyLDEzICsyNzQsMTQgQEAgc3RhdGljIGJvb2wgdXNlX2Zha2Vf
aXJxKGNvbnN0IHN0cnVjdCBpbnRlbF9icmVhZGNydW1icyAqYikKPiAgCWlmICghdGVzdF9iaXQo
ZW5naW5lLT5pZCwgJmVuZ2luZS0+aTkxNS0+Z3B1X2Vycm9yLm1pc3NlZF9pcnFfcmluZ3MpKQo+
ICAJCXJldHVybiBmYWxzZTsKPiAgCj4gLQkvKiBPbmx5IHN0YXJ0IHdpdGggdGhlIGhlYXZ5IHdl
aWdodCBmYWtlIGlycSB0aW1lciBpZiB3ZSBoYXZlIG5vdAo+ICsJLyoKPiArCSAqIE9ubHkgc3Rh
cnQgd2l0aCB0aGUgaGVhdnkgd2VpZ2h0IGZha2UgaXJxIHRpbWVyIGlmIHdlIGhhdmUgbm90Cj4g
IAkgKiBzZWVuIGFueSBpbnRlcnJ1cHRzIHNpbmNlIGVuYWJsaW5nIGl0IHRoZSBmaXJzdCB0aW1l
LiBJZiB0aGUKPiAgCSAqIGludGVycnVwdHMgYXJlIHN0aWxsIGFycml2aW5nLCBpdCBtZWFucyB3
ZSBtYWRlIGEgbWlzdGFrZSBpbiBvdXIKPiAgCSAqIGVuZ2luZS0+c2Vxbm9fYmFycmllcigpLCBh
IHRpbWluZyBlcnJvciB0aGF0IHNob3VsZCBiZSB0cmFuc2llbnQKPiAgCSAqIGFuZCB1bmxpa2Vs
eSB0byByZW9jY3VyLgo+ICAJICovCj4gLQlyZXR1cm4gYXRvbWljX3JlYWQoJmVuZ2luZS0+aXJx
X2NvdW50KSA9PSBiLT5oYW5nY2hlY2tfaW50ZXJydXB0czsKPiArCXJldHVybiBSRUFEX09OQ0Uo
Yi0+aXJxX2NvdW50KSA9PSBiLT5oYW5nY2hlY2tfaW50ZXJydXB0czsKPiAgfQo+ICAKPiAgc3Rh
dGljIHZvaWQgZW5hYmxlX2Zha2VfaXJxKHN0cnVjdCBpbnRlbF9icmVhZGNydW1icyAqYikKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gaW5kZXggOGRkMzRiOWRjMThh
Li4zMzYwMmViMWM3N2YgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
cmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZl
ci5oCj4gQEAgLTM1Niw3ICszNTYsNiBAQCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzIHsKPiAgCXN0
cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpkZWZhdWx0X3N0YXRlOwo+ICAJdm9pZCAqcGlubmVk
X2RlZmF1bHRfc3RhdGU7Cj4gIAo+IC0JYXRvbWljX3QgaXJxX2NvdW50Owo+ICAJdW5zaWduZWQg
bG9uZyBpcnFfcG9zdGVkOwo+ICAjZGVmaW5lIEVOR0lORV9JUlFfQlJFQURDUlVNQiAwCj4gIAo+
IEBAIC0zOTAsNiArMzg5LDcgQEAgc3RydWN0IGludGVsX2VuZ2luZV9jcyB7Cj4gIAo+ICAJCXVu
c2lnbmVkIGludCBoYW5nY2hlY2tfaW50ZXJydXB0czsKPiAgCQl1bnNpZ25lZCBpbnQgaXJxX2Vu
YWJsZWQ7Cj4gKwkJdW5zaWduZWQgaW50IGlycV9jb3VudDsKPiAgCj4gIAkJYm9vbCBpcnFfYXJt
ZWQgOiAxOwo+ICAJCUk5MTVfU0VMRlRFU1RfREVDTEFSRShib29sIG1vY2sgOiAxKTsKPiAtLSAK
PiAyLjE4LjAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K
SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0
dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==