From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915/dsm: remove unnecessary dsm priv structure Date: Thu, 14 Jun 2018 16:04:54 +0300 Message-ID: <87bmcdzfgp.fsf@intel.com> References: <20180614104709.2808-1-jani.nikula@intel.com> <20180614125112.GC20518@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id C953A6E200 for ; Thu, 14 Jun 2018 13:05:02 +0000 (UTC) In-Reply-To: <20180614125112.GC20518@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxNCBKdW4gMjAxOCwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gVGh1LCBKdW4gMTQsIDIwMTggYXQgMDE6NDc6MDlQTSAr MDMwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IFBhc3MgYSBsb2NhbCBhY3BpX2hhbmRsZSBhcm91 bmQgaW5zdGVhZCBvZiBoYXZpbmcgYSBzdGF0aWMgZHNtIHByaXYKPj4gc3RydWN0dXJlLiBJZiB3 ZSBuZWVkIGl0IGxhdGVyLCB3ZSBjYW4gYWx3YXlzIG1vdmUgaXQgdG8gZGV2X3ByaXYsIGFuZAo+ PiB0aGUgY2hhbmdlIGF0IGhhbmQgd2lsbCBtYWtlIHRoYXQgZWFzaWVyIGFzIHdlbGwuCj4+IAo+ PiBDYXJlIGlzIHRha2VuIHRvIHByZXNlcnZlIG9sZCBiZWhhdmlvdXIsIHBhcnRpY3VsYXJseSB1 c2luZyB0aGUgbGFzdAo+PiBub24tTlVMTCBhY3BpIGhhbmRsZSwgd2hldGhlciBpdCBtYWtlcyBz ZW5zZSBvciBub3QuCj4+IAo+PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1 bGFAaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2FjcGku YyB8IDI3ICsrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDEx IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+PiAKPj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2FjcGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2FjcGkuYwo+PiBpbmRleCBkMWFiZjRiYjdjODEuLjZiYTQ3OGU1N2I5YiAxMDA2NDQKPj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYWNwaS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2FjcGkuYwo+PiBAQCAtMTIsMTAgKzEyLDYgQEAKPj4gICNkZWZpbmUg SU5URUxfRFNNX1JFVklTSU9OX0lEIDEgLyogRm9yIENhbHBlbGxhIGFueXdheS4uLiAqLwo+PiAg I2RlZmluZSBJTlRFTF9EU01fRk5fUExBVEZPUk1fTVVYX0lORk8gMSAvKiBObyBhcmdzICovCj4+ ICAKPj4gLXN0YXRpYyBzdHJ1Y3QgaW50ZWxfZHNtX3ByaXYgewo+PiAtCWFjcGlfaGFuZGxlIGRo YW5kbGU7Cj4+IC19IGludGVsX2RzbV9wcml2Owo+PiAtCj4+ICBzdGF0aWMgY29uc3QgZ3VpZF90 IGludGVsX2RzbV9ndWlkID0KPj4gIAlHVUlEX0lOSVQoMHg3ZWQ4NzNkMywgMHhjMmQwLCAweDRl NGYsCj4+ICAJCSAgMHhhOCwgMHg1NCwgMHgwZiwgMHgxMywgMHgxNywgMHhiMCwgMHgxYywgMHgy Yyk7Cj4+IEBAIC03MiwxMiArNjgsMTIgQEAgc3RhdGljIGNoYXIgKmludGVsX2RzbV9tdXhfdHlw ZSh1OCB0eXBlKQo+PiAgCX0KPj4gIH0KPj4gIAo+PiAtc3RhdGljIHZvaWQgaW50ZWxfZHNtX3Bs YXRmb3JtX211eF9pbmZvKHZvaWQpCj4+ICtzdGF0aWMgdm9pZCBpbnRlbF9kc21fcGxhdGZvcm1f bXV4X2luZm8oYWNwaV9oYW5kbGUgZGhhbmRsZSkKPj4gIHsKPj4gIAlpbnQgaTsKPj4gIAl1bmlv biBhY3BpX29iamVjdCAqcGtnLCAqY29ubmVjdG9yX2NvdW50Owo+PiAgCj4+IC0JcGtnID0gYWNw aV9ldmFsdWF0ZV9kc21fdHlwZWQoaW50ZWxfZHNtX3ByaXYuZGhhbmRsZSwgJmludGVsX2RzbV9n dWlkLAo+PiArCXBrZyA9IGFjcGlfZXZhbHVhdGVfZHNtX3R5cGVkKGRoYW5kbGUsICZpbnRlbF9k c21fZ3VpZCwKPj4gIAkJCUlOVEVMX0RTTV9SRVZJU0lPTl9JRCwgSU5URUxfRFNNX0ZOX1BMQVRG T1JNX01VWF9JTkZPLAo+PiAgCQkJTlVMTCwgQUNQSV9UWVBFX1BBQ0tBR0UpOwo+PiAgCWlmICgh cGtnKSB7Cj4+IEBAIC0xMDcsNDEgKzEwMyw0MCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9kc21fcGxh dGZvcm1fbXV4X2luZm8odm9pZCkKPj4gIAlBQ1BJX0ZSRUUocGtnKTsKPj4gIH0KPj4gIAo+PiAt c3RhdGljIGJvb2wgaW50ZWxfZHNtX3BjaV9wcm9iZShzdHJ1Y3QgcGNpX2RldiAqcGRldikKPj4g K3N0YXRpYyBhY3BpX2hhbmRsZSBpbnRlbF9kc21fcGNpX3Byb2JlKHN0cnVjdCBwY2lfZGV2ICpw ZGV2KQo+PiAgewo+PiAgCWFjcGlfaGFuZGxlIGRoYW5kbGU7Cj4+ICAKPj4gIAlkaGFuZGxlID0g QUNQSV9IQU5ETEUoJnBkZXYtPmRldik7Cj4+ICAJaWYgKCFkaGFuZGxlKQo+PiAtCQlyZXR1cm4g ZmFsc2U7Cj4+ICsJCXJldHVybiBOVUxMOwo+PiAgCj4+ICAJaWYgKCFhY3BpX2NoZWNrX2RzbShk aGFuZGxlLCAmaW50ZWxfZHNtX2d1aWQsIElOVEVMX0RTTV9SRVZJU0lPTl9JRCwKPj4gIAkJCSAg ICAxIDw8IElOVEVMX0RTTV9GTl9QTEFURk9STV9NVVhfSU5GTykpIHsKPj4gIAkJRFJNX0RFQlVH X0tNUygibm8gX0RTTSBtZXRob2QgZm9yIGludGVsIGRldmljZVxuIik7Cj4+IC0JCXJldHVybiBm YWxzZTsKPj4gKwkJcmV0dXJuIE5VTEw7Cj4+ICAJfQo+PiAgCj4+IC0JaW50ZWxfZHNtX3ByaXYu ZGhhbmRsZSA9IGRoYW5kbGU7Cj4+IC0JaW50ZWxfZHNtX3BsYXRmb3JtX211eF9pbmZvKCk7Cj4+ ICsJaW50ZWxfZHNtX3BsYXRmb3JtX211eF9pbmZvKGRoYW5kbGUpOwo+PiAgCj4+IC0JcmV0dXJu IHRydWU7Cj4+ICsJcmV0dXJuIGRoYW5kbGU7Cj4+ICB9Cj4+ICAKPj4gIHN0YXRpYyBib29sIGlu dGVsX2RzbV9kZXRlY3Qodm9pZCkKPj4gIHsKPj4gKwlhY3BpX2hhbmRsZSBkaGFuZGxlID0gTlVM TDsKPj4gIAljaGFyIGFjcGlfbWV0aG9kX25hbWVbMjU1XSA9IHsgMCB9Owo+PiAgCXN0cnVjdCBh Y3BpX2J1ZmZlciBidWZmZXIgPSB7c2l6ZW9mKGFjcGlfbWV0aG9kX25hbWUpLCBhY3BpX21ldGhv ZF9uYW1lfTsKPj4gIAlzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IE5VTEw7Cj4+IC0JYm9vbCBoYXNf ZHNtID0gZmFsc2U7Cj4+ICAJaW50IHZnYV9jb3VudCA9IDA7Cj4+ICAKPj4gIAl3aGlsZSAoKHBk ZXYgPSBwY2lfZ2V0X2NsYXNzKFBDSV9DTEFTU19ESVNQTEFZX1ZHQSA8PCA4LCBwZGV2KSkgIT0g TlVMTCkgewo+PiAgCQl2Z2FfY291bnQrKzsKPj4gLQkJaGFzX2RzbSB8PSBpbnRlbF9kc21fcGNp X3Byb2JlKHBkZXYpOwo+PiArCQlkaGFuZGxlID0gaW50ZWxfZHNtX3BjaV9wcm9iZShwZGV2KSA/ OiBkaGFuZGxlOwo+Cj4gSSAqdGhpbmsqIGdjYyBwcm9taXNlcyBub3QgdG8gZXZhbHVhdGUgdGhp bmdzIHR3aWNlIHdpdGggPzosIHNvCj4gc2hvdWxkIGJlIHNhZmUgZXZlbiBpZiBpbnRlbF9kc21f cGNpX3Byb2JlKCkgaGFzIHNvbWUgc2lkZSBlZmZlY3RzLgoKWWVhaCBJIHdhcyB3b25kZXJpbmcg aWYgdGhpcyB3YXMgdG9vIGNsZXZlciwgYnV0IHRoZW4gdGhlIGFsdGVybmF0aXZlCndhcyBwcmV0 dHkgdGVkaW91cyB3aXRoIGFub3RoZXIgdGVtcCB2YXJpYWJsZSBhbmQgY29uZGl0aW9ucyBldGMu IE9yCmNoYW5naW5nIGJlaGF2aW91ciB3aGljaCBJIHdhbnRlZCB0byBhdm9pZC4KCj4gUmV2aWV3 ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpU aGFua3MgZm9yIHRoZSByZXZpZXcsIHB1c2hlZCB0byBkaW5xLgoKQlIsCkphbmkuCgo+Cj4+ICAJ fQo+PiAgCj4+IC0JaWYgKHZnYV9jb3VudCA9PSAyICYmIGhhc19kc20pIHsKPj4gLQkJYWNwaV9n ZXRfbmFtZShpbnRlbF9kc21fcHJpdi5kaGFuZGxlLCBBQ1BJX0ZVTExfUEFUSE5BTUUsICZidWZm ZXIpOwo+PiArCWlmICh2Z2FfY291bnQgPT0gMiAmJiBkaGFuZGxlKSB7Cj4+ICsJCWFjcGlfZ2V0 X25hbWUoZGhhbmRsZSwgQUNQSV9GVUxMX1BBVEhOQU1FLCAmYnVmZmVyKTsKPj4gIAkJRFJNX0RF QlVHX0RSSVZFUigidmdhX3N3aXRjaGVyb286IGRldGVjdGVkIERTTSBzd2l0Y2hpbmcgbWV0aG9k ICVzIGhhbmRsZVxuIiwKPj4gIAkJCQkgYWNwaV9tZXRob2RfbmFtZSk7Cj4+ICAJCXJldHVybiB0 cnVlOwo+PiAtLSAKPj4gMi4xMS4wCj4+IAo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4+IEludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBT b3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=