From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/2] usb: dwc3: of_simple: don't call pm_runtime_set_active() From: Felipe Balbi Message-Id: <87bmcwcl1j.fsf@linux.intel.com> Date: Thu, 31 May 2018 10:59:52 +0300 To: Roger Quadros , Tero Kristo , "Gerlach, Dave" Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Nishanth Menon , "Nori, Sekhar" List-ID: SGksCgpSb2dlciBRdWFkcm9zIDxyb2dlcnFAdGkuY29tPiB3cml0ZXM6Cgo+IE9uIDMwLzA1LzE4 IDE1OjMxLCBGZWxpcGUgQmFsYmkgd3JvdGU6Cj4+IFJvZ2VyIFF1YWRyb3MgPHJvZ2VycUB0aS5j b20+IHdyaXRlczoKPj4gCj4+PiBEb24ndCBjYWxsIHBtX3J1bnRpbWVfc2V0X2FjdGl2ZSgpIGFz IGl0IHdpbGwgcHJldmVudCB0aGUgZGV2aWNlCj4+PiBmcm9tIGJlaW5nIGFjdGl2YXRlZCBpbiB0 aGUgbmV4dCBwbV9ydW50aW1lX2dldF9zeW5jKCkgY2FsbC4KPj4+Cj4+PiBBbHNvIGNhbGwgcG1f cnVudGltZV9nZXRfc3luYygpIGJlZm9yZSBvZl9wbGF0Zm9ybV9wb3B1bGF0ZSgpLgo+Pj4KPj4+ IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFF1YWRyb3MgPHJvZ2VycUB0aS5jb20+Cj4+IAo+PiBUaGlz IHBhdGNoIGlzIHdyb25nLgo+PiAKPj4+IC0tLQo+Pj4gIGRyaXZlcnMvdXNiL2R3YzMvZHdjMy1v Zi1zaW1wbGUuYyB8IDcgKysrLS0tLQo+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMo KyksIDQgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2R3YzMv ZHdjMy1vZi1zaW1wbGUuYyBiL2RyaXZlcnMvdXNiL2R3YzMvZHdjMy1vZi1zaW1wbGUuYwo+Pj4g aW5kZXggZTk4ZDIyMS4uMmNiYjVjMCAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvdXNiL2R3YzMv ZHdjMy1vZi1zaW1wbGUuYwo+Pj4gKysrIGIvZHJpdmVycy91c2IvZHdjMy9kd2MzLW9mLXNpbXBs ZS5jCj4+PiBAQCAtMTIxLDYgKzEyMSw5IEBAIHN0YXRpYyBpbnQgZHdjM19vZl9zaW1wbGVfcHJv YmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4+ICAJaWYgKHJldCkKPj4+ICAJCWdv dG8gZXJyX3Jlc2V0Y19hc3NlcnQ7Cj4+PiAgCj4+PiArCXBtX3J1bnRpbWVfZW5hYmxlKGRldik7 Cj4+PiArCXBtX3J1bnRpbWVfZ2V0X3N5bmMoZGV2KTsKPj4gCj4+IE5vLCB0aGlzIGlzIHRoZSB3 cm9uZyB3YXkgdG8gZG8gdGhpbmdzLiBNeSBkZXZpY2Ugc2hvdWxkIGJlIGVuYWJsZWQKPj4gYWxy ZWFkeSBmcm9tIHByb2JlLCBzcGVjaWFsbHkgc2luY2UgSSBoYXZlIGFscmVhZHkgZW5hYmxlZCBj bG9ja3MuCj4KPiBBcyBmYXIgYXMgSSB1bmRlcnN0b29kIGp1c3QgZW5hYmxpbmcgY2xvY2tzICh3 aGljaCBtaWdodCBub3QgaW5jbHVkZSBidXMgY2xvY2spCj4gZG9lc24ndCBlbnN1cmUgZGV2aWNl IGlzIGVuYWJsZWQuCj4KPiBEaWQgeW91IG1lYW4gdGhhdCBJIGRvbid0IG5lZWQgdG8gZG8gYSBw bV9ydW50aW1lX2dldF9zeW5jKCkgdG8gZW5hYmxlIG15IGRldmljZSBpbiBwcm9iZT8KPiBXaG8g aXMgZW5hYmxpbmcgYnkgZGV2aWNlIGZvciBtZSB0aGVuPyBJcyBkZXZpY2UgY29yZSBzdXBwb3Nl ZCB0byBkbyBpdD8KCk5vdCBkZXZpY2UgY29yZSwgYnV0IHRoZSBidXMgY29kZS4gTG9vayBhdCBo b3cgUENJIGhhbmRsZXMgaXQuIElJUkMsCm9ubHkgVEkncyBvbWFwX2RldmljZSBiZWhhdmVzIHBl Y3VsaWFybHkgV1JUIHByb2JlICYgcG0gcnVudGltZS4KCj4gVGhlIGlzc3VlIEkgd2FzIGZhY2lu ZyBpcyB0aGF0IHdpdGhvdXQgdGhpcyBwYXRjaCBteSBkZXZpY2Ugd2Fzbid0IGJlaW5nIGVuYWJs ZWQKPiBhcyBwbV9ydW50aW1lX3NldF9hY3RpdmUoKSBpcyBiZWluZyBkb25lIF9iZWZvcmVfIHBt X3J1bnRpbWVfZ2V0X3N5bmMoKS4KPiBJdCBjb3VsZCBiZSBhbiBpc3N1ZSB3aXRoIHRoZSBwbGF0 Zm9ybSdzIFBNIGRvbWFpbiBjb2RlIGFzIHdlbGwuCgpDb3VsZCBiZQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754089AbeEaIBy (ORCPT ); Thu, 31 May 2018 04:01:54 -0400 Received: from mga01.intel.com ([192.55.52.88]:54703 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753934AbeEaIBv (ORCPT ); Thu, 31 May 2018 04:01:51 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,463,1520924400"; d="asc'?scan'208";a="45314351" From: Felipe Balbi To: Roger Quadros , Tero Kristo , "Gerlach\, Dave" Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Nishanth Menon , "Nori\, Sekhar" Subject: Re: [PATCH 2/2] usb: dwc3: of_simple: don't call pm_runtime_set_active() In-Reply-To: References: <1527518174-27860-1-git-send-email-rogerq@ti.com> <1527518174-27860-2-git-send-email-rogerq@ti.com> <87k1rlcok2.fsf@linux.intel.com> Date: Thu, 31 May 2018 10:59:52 +0300 Message-ID: <87bmcwcl1j.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Roger Quadros writes: > On 30/05/18 15:31, Felipe Balbi wrote: >> Roger Quadros writes: >>=20 >>> Don't call pm_runtime_set_active() as it will prevent the device >>> from being activated in the next pm_runtime_get_sync() call. >>> >>> Also call pm_runtime_get_sync() before of_platform_populate(). >>> >>> Signed-off-by: Roger Quadros >>=20 >> This patch is wrong. >>=20 >>> --- >>> drivers/usb/dwc3/dwc3-of-simple.c | 7 +++---- >>> 1 file changed, 3 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-= of-simple.c >>> index e98d221..2cbb5c0 100644 >>> --- a/drivers/usb/dwc3/dwc3-of-simple.c >>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c >>> @@ -121,6 +121,9 @@ static int dwc3_of_simple_probe(struct platform_dev= ice *pdev) >>> if (ret) >>> goto err_resetc_assert; >>>=20=20 >>> + pm_runtime_enable(dev); >>> + pm_runtime_get_sync(dev); >>=20 >> No, this is the wrong way to do things. My device should be enabled >> already from probe, specially since I have already enabled clocks. > > As far as I understood just enabling clocks (which might not include bus = clock) > doesn't ensure device is enabled. > > Did you mean that I don't need to do a pm_runtime_get_sync() to enable my= device in probe? > Who is enabling by device for me then? Is device core supposed to do it? Not device core, but the bus code. Look at how PCI handles it. IIRC, only TI's omap_device behaves peculiarly WRT probe & pm runtime. > The issue I was facing is that without this patch my device wasn't being = enabled > as pm_runtime_set_active() is being done _before_ pm_runtime_get_sync(). > It could be an issue with the platform's PM domain code as well. Could be =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlsPq3gACgkQzL64meEa mQbNIxAAuy04aGRDNcfBLfnHTZc6SImdiuiGUNL8okbukSji03jWf3EN/8TSDjGd P+SbInnQeZ/VuPsdzR7wKbEoRudOrKJ5fbp/BSQuKJjjbj2NHBAnCepmzsfPYTf/ u6K+fKiROfgdH7UpwFkYQgCPSSHBxOYHuwwst++Px10V67VWOFYcVy6oY2MPBEmM Mh4Trc7rlb6A9mR9Ye7buCfWLX7O+XJLYES27+NOlbdRsegn5PEt0NmLulqSgch5 yF9fPlwM+9W5bIxDp8WVlxvcf7Ixd5P8JwrMkbP5Xp7Bar709MLAK6sCB3P8fK96 on6pzFkkFgK1hr3/6KDCpqTcXJNQR/fPRYB96o4I+Tvd8leFqGC6T204x6Ghn8uP pSQ652ObHGHjj/JuVaHWscN+YD+cAvs+gbjI4UwpHuU+caCrdNMsW3PzummZV8Km KEzZVBtU/CXZFuliJJ7oDiglw1/Hf6BFK1kH9ob/xrZsqZ8YLYRCcEPbhzouM3ta W3VFzNN+qEmMI8mu7yir/Xku3O2RtQG6MsrqwxceO6mBKvz5ToJGPsOq6g2LUXOy U3p94VjNNRo41viRMX1Z0ofdTJeyedA59FtOC5/KBgI5jdvM1hz+9Zfxxli+o3qS nf1TSNkcWcvc2SuniNvAnwgrGYzUSP0pkfxGbkUOQyLLSzVIQEM= =eyym -----END PGP SIGNATURE----- --=-=-=--