From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fE84r-000658-Mu for qemu-devel@nongnu.org; Thu, 03 May 2018 02:50:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fE84o-0002Mw-Ja for qemu-devel@nongnu.org; Thu, 03 May 2018 02:50:53 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:37390 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fE84o-0002L7-ER for qemu-devel@nongnu.org; Thu, 03 May 2018 02:50:50 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 54118406E973 for ; Thu, 3 May 2018 06:50:49 +0000 (UTC) From: Markus Armbruster References: <1525281868-24747-1-git-send-email-thuth@redhat.com> <1525281868-24747-2-git-send-email-thuth@redhat.com> Date: Thu, 03 May 2018 08:50:48 +0200 In-Reply-To: <1525281868-24747-2-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Wed, 2 May 2018 19:24:25 +0200") Message-ID: <87bmdxtepj.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-options: Remove remainders of the -tdf option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, Paolo Bonzini Thomas Huth writes: > The -tdf options has been removed with d07aa197c5a1556449361a0cbb5108e2, > but apparently I forgot to remove the corresponding two lines from > qemu-options.hx. > > Signed-off-by: Thomas Huth > --- > qemu-options.hx | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index c611766..44daa10 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -3924,9 +3924,6 @@ DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection, > HXCOMM Deprecated by -machine kernel_irqchip=on|off property > DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386) > > -HXCOMM Deprecated (ignored) > -DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL) > - > DEF("msg", HAS_ARG, QEMU_OPTION_msg, > "-msg timestamp[=on|off]\n" > " change the format of messages\n" Makes me wonder what happens when you specify --tdf. Aha: nothing. Why? main() passes unknown options to os_parse_cmd_args(), which happily ignores them. Its function comment "return 0 if option handled, -1 otherwise" is bogus. Needs cleanup. Separate patch, not necessarily in this series. Suggest to mention in your commit message that --tdf is silently ignored. Feel free to also point out the need for cleanup there. Reviewed-by: Markus Armbruster