From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 7/9] drm/gem-fb-helper: Always do implicit sync Date: Fri, 20 Apr 2018 15:11:24 -0700 Message-ID: <87bmedil4j.fsf@anholt.net> References: <20180405154449.23038-1-daniel.vetter@ffwll.ch> <20180405154449.23038-8-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1911309122==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id CF0086E285 for ; Fri, 20 Apr 2018 22:11:27 +0000 (UTC) In-Reply-To: <20180405154449.23038-8-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: DRI Development Cc: David Airlie , Daniel Vetter , Gustavo Padovan , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org --===============1911309122== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Daniel Vetter writes: > I've done a lot of history digging. The first signs of this > optimization was introduced in i915: I can't come up with any reason this would matter. I almost came up with "You're doing tearing X11 front buffer rendering, and you do a modeset using the same fb, and so you block that modeset behind your rendering." Except that: 1) who cares 2) this helper is only for dma-bufs, not normal X11 rendering 3) your X11 driver should be doing pageflipping to be tear-free anyway, let's just fix that[1]. Reviewed-by: Eric Anholt [1] This is not actually me volunteering myself or anyone else to go fix that. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlraZY0ACgkQtdYpNtH8 nugsDw/+M5egLUfD6fpD8DJ/8UGe2hN+nCmwJn0fGHgEKdyDZw43IuhIxBA+Yt9U ZGTiedNhZOMtCF8tpJuMvVDs11jNX53X5pCRqw3vwrOLoHi0Uatm97H0fcr9dy7S VTg+7w19gF+HUZ2tM5PQeKNmsSebJBca9MFJlb1NAMRTPLiOirhXqFyeIszOpzjl c37S2vxveX4tPSgdS5LGuVVFzpJTx2aAN1Z37GpR3jLFb6jIlcqLEqoBCfENbUL8 8bu1jFs8Js2KdqHNjE0XbmtugFMvcPRBJVv7o8xL0/5WH807Fur2QQ1ponT8fPPl 3bkq/De8Nunrln9Ef6jWhB6q6yjB7gldSNQWP4tOYsuLmyW4Oo4VQtc9626iP67M gog9y4/COiH2c0ZZuLyWe2vnf7qBRxRNYoO37B7lZuFHlp2GBH9CqLvd3Z4Xx1Ij 0Bc5jWw7lG2ZLDuX2K7m7mZRVLzjErqmTl64kPmw50DLre617U2tun73GaA/FDK9 Y0dns19vy0cJxtgpDgreKZCt9igHfriTnsi8hWbfEBF47rsNDRaZSY+5uFlJ476v BRZtVdKT6NW2UYCO1r8/Ml9HA5lpavB+qvT6AaWZxOu/ibHjKe2FwnU2rEyOD9Z3 6tC7Bwivvx7yayds+AHcjdvPrzwD139n2t/42QaCSITdGGgzWx8= =iqev -----END PGP SIGNATURE----- --=-=-=-- --===============1911309122== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1911309122==--