From: Kalle Valo <kvalo@codeaurora.org>
To: linux-wireless@vger.kernel.org
Cc: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Avinash Patil <avinashp@quantenna.com>
Subject: Re: [PATCH 5/5] qtnfmac: implement 64-bit dma support
Date: Thu, 31 Aug 2017 14:09:12 +0300 [thread overview]
Message-ID: <87bmmwro2v.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170831094812.utahi5ayz3ag7wrl@bars> (Sergey Matyukevich's message of "Thu, 31 Aug 2017 12:48:12 +0300")
Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> writes:
> Hello Kalle,
>
>> > - writel(QTN_HOST_LO32(paddr),
>> > - PCIE_HDP_TX_HOST_Q_BASE_L(priv->pcie_reg_base));
>> > +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
>> > writel(QTN_HOST_HI32(paddr),
>> > PCIE_HDP_TX_HOST_Q_BASE_H(priv->pcie_reg_base));
>> > +#endif
>>
>> Personally I detest ifdefs and try to write code like this using
>> IS_ENABLED():
>>
>> if (IS_ENABLED(CONFIG_ARCH_DMA_ADDR_T_64BIT))
>> writel(QTN_HOST_HI32(paddr),
>> PCIE_HDP_TX_HOST_Q_BASE_H(priv->pcie_reg_base));
>>
>> But up to you which style you prefer.
>
> I agree that this way it looks better. But I am using the same ifdef in header
> to define QTN_HOST_* macros. So in this particular case I would prefer to
> keep the same notation in both source and header files.
Ok. I'll try to get these to 4.14 still.
--
Kalle Valo
prev parent reply other threads:[~2017-08-31 11:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 12:16 [PATCH 0/5] qtnfmac: pcie datapath updates and fixes Sergey Matyukevich
2017-08-29 12:16 ` [PATCH 1/5] qtnfmac: drop -D__CHECK_ENDIAN from cflags Sergey Matyukevich
2017-08-31 12:58 ` [1/5] " Kalle Valo
2017-08-29 12:16 ` [PATCH 2/5] qtnfmac: module param sanity check Sergey Matyukevich
2017-08-29 12:16 ` [PATCH 3/5] qtnfmac: modify qtnf_map_bar not to return NULL Sergey Matyukevich
2017-08-30 2:13 ` Igor Mitsyanko
2017-08-30 8:45 ` Sergey Matyukevich
2017-08-30 2:14 ` Igor Mitsyanko
2017-08-29 12:16 ` [PATCH 4/5] qtnfmac: fix free_xfer_buffer cleanup Sergey Matyukevich
2017-08-29 12:16 ` [PATCH 5/5] qtnfmac: implement 64-bit dma support Sergey Matyukevich
2017-08-30 16:38 ` Kalle Valo
2017-08-31 9:48 ` Sergey Matyukevich
2017-08-31 11:09 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmmwro2v.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=avinashp@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.