Re: [balbi-usb:next 21/42] drivers/usb/gadget/function/f_midi.c:836:24: error: 'f_midi_rmidi_free' undeclared

[Felipe Balbi <felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1758 bytes --]


Hi,

kbuild test robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
> head:   af982758d0a9e5189e657de2bbab2f65f16c48cc
> commit: b8bd28e32e5fc3ad2d8c80ad3978fabb523a1763 [21/42] usb: gadget: f_midi: Use snd_card_free_when_closed with refcount
> config: i386-randconfig-x075-201733 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         git checkout b8bd28e32e5fc3ad2d8c80ad3978fabb523a1763
>         # save the attached .config to linux build tree
>         make ARCH=i386 
>
> All errors (new ones prefixed by >>):
>
>    drivers/usb/gadget/function/f_midi.c: In function 'f_midi_register_card':
>>> drivers/usb/gadget/function/f_midi.c:836:24: error: 'f_midi_rmidi_free' undeclared (first use in this function)
>      rmidi->private_free = f_midi_rmidi_free;
>                            ^~~~~~~~~~~~~~~~~
>    drivers/usb/gadget/function/f_midi.c:836:24: note: each undeclared identifier is reported only once for each function it appears in
>    At top level:
>    drivers/usb/gadget/function/f_midi.c:1249:13: warning: 'f_midi_rmidi_free' defined but not used [-Wunused-function]
>     static void f_midi_rmidi_free(struct snd_rawmidi *rmidi)
>                 ^~~~~~~~~~~~~~~~~
>
> vim +/f_midi_rmidi_free +836 drivers/usb/gadget/function/f_midi.c

I'll fix it up locally, thanks

@@ -109,6 +109,7 @@ static inline struct f_midi *func_to_midi(struct usb_function *f)
 }
 
 static void f_midi_transmit(struct f_midi *midi);
+static void f_midi_rmidi_free(struct snd_rawmidi *rmidi);
 
 DECLARE_UAC_AC_HEADER_DESCRIPTOR(1);
 DECLARE_USB_MIDI_OUT_JACK_DESCRIPTOR(1);

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]