All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Re: BUG: double free of PCM structure upon module	removal
Date: Wed, 24 May 2017 09:58:47 +0200	[thread overview]
Message-ID: <87bmqi1ya0.fsf@belgarion.home> (raw)
In-Reply-To: <s5ho9uin4gv.wl-tiwai@suse.de> (Takashi Iwai's message of "Wed, 24 May 2017 08:39:28 +0200")

Takashi Iwai <tiwai@suse.de> writes:

> On Wed, 24 May 2017 08:31:39 +0200,
> I see, so my patch should cure such a case.
Indeed.

>> > In anyway the calls there look in a wrong order.  Basically we should
>> > start with snd_card_free() to sync with the whole operation finishes,
>> > then release everything.  Below is an untested patch to do that.
>> With you patch, the bug is gone in my first 3 tries.
>
> I think the patch below is simpler and has the same effect.
> If this works for you, I'll submit the proper patch.
Yep, I just tested it.
Feel free to add my :
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>

Thanks.

--
Robert

      reply	other threads:[~2017-05-24  7:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 16:46 BUG: double free of PCM structure upon module removal Robert Jarzmik
2017-05-23 17:14 ` Mark Brown
2017-05-23 18:14   ` Takashi Iwai
2017-05-24  6:31     ` Robert Jarzmik
2017-05-24  6:39       ` Takashi Iwai
2017-05-24  7:58         ` Robert Jarzmik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmqi1ya0.fsf@belgarion.home \
    --to=robert.jarzmik@free.fr \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.