From: Markus Armbruster <armbru@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org,
mitake.hitoshi@lab.ntt.co.jp, jcody@redhat.com,
pbonzini@redhat.com, namei.unix@gmail.com
Subject: Re: [Qemu-devel] [for-2.9 6/8] qapi-schema: SocketAddressFlat variants 'vsock' and 'fd'
Date: Thu, 30 Mar 2017 08:53:34 +0200 [thread overview]
Message-ID: <87bmsjfe6p.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <dbf432c4-405c-9197-3795-8f2600edaf38@redhat.com> (Max Reitz's message of "Wed, 29 Mar 2017 21:42:44 +0200")
Max Reitz <mreitz@redhat.com> writes:
> On 29.03.2017 18:45, Markus Armbruster wrote:
>> Note that the new variants are impossible in qemu_gluster_glfs_init(),
>> because the gconf->server can only come from qemu_gluster_parse_uri()
>> or qemu_gluster_parse_json(), and neither can create anything but
>> 'tcp' or 'unix'.
>
> s/tcp/inet/
Fixing...
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> block/gluster.c | 2 ++
>> qapi-schema.json | 19 ++++++++-----------
>> 2 files changed, 10 insertions(+), 11 deletions(-)
>>
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
Thanks!
next prev parent reply other threads:[~2017-03-30 6:53 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 16:45 [Qemu-devel] [for-2.9 0/8] Fixes and cleanups around SocketAddress Markus Armbruster
2017-03-29 16:45 ` [Qemu-devel] [for-2.9 1/8] nbd sockets vnc: Mark problematic address family tests TODO Markus Armbruster
2017-03-29 18:55 ` Max Reitz
2017-03-29 19:51 ` Eric Blake
2017-03-29 16:45 ` [Qemu-devel] [for-2.9 2/8] char: Fix socket with "type": "vsock" address Markus Armbruster
2017-03-29 16:48 ` Marc-André Lureau
2017-03-29 16:49 ` Marc-André Lureau
2017-03-30 6:32 ` Markus Armbruster
2017-03-29 18:42 ` Stefan Hajnoczi
2017-03-29 18:59 ` Max Reitz
2017-03-29 16:45 ` [Qemu-devel] [for-2.9 3/8] io vnc sockets: Clean up SocketAddressKind switches Markus Armbruster
2017-03-29 19:13 ` Max Reitz
2017-03-30 6:38 ` Markus Armbruster
2017-04-03 11:47 ` Daniel P. Berrange
2017-03-29 16:45 ` [Qemu-devel] [for-2.9 4/8] block: Document -drive problematic code and bugs Markus Armbruster
2017-03-29 19:33 ` Max Reitz
2017-03-30 6:52 ` Markus Armbruster
2017-03-30 13:09 ` Eric Blake
2017-03-30 14:42 ` Markus Armbruster
2017-03-30 16:10 ` Max Reitz
2017-03-29 16:45 ` [Qemu-devel] [for-2.9 5/8] gluster: Prepare for SocketAddressFlat extension Markus Armbruster
2017-03-29 19:35 ` Max Reitz
2017-03-29 20:07 ` Jeff Cody
2017-03-29 16:45 ` [Qemu-devel] [for-2.9 6/8] qapi-schema: SocketAddressFlat variants 'vsock' and 'fd' Markus Armbruster
2017-03-29 19:42 ` Max Reitz
2017-03-30 6:53 ` Markus Armbruster [this message]
2017-03-29 20:02 ` Eric Blake
2017-03-30 6:55 ` Markus Armbruster
2017-03-30 13:14 ` Eric Blake
2017-03-29 16:45 ` [Qemu-devel] [for-2.9 7/8] nbd: Tidy up blockdev-add interface Markus Armbruster
2017-03-29 17:02 ` Paolo Bonzini
2017-03-29 19:46 ` Max Reitz
2017-03-30 7:27 ` Markus Armbruster
2017-03-29 20:19 ` Eric Blake
2017-03-30 7:06 ` Markus Armbruster
2017-03-29 16:45 ` [Qemu-devel] [for-2.9 8/8] sheepdog: Fix blockdev-add Markus Armbruster
2017-03-29 19:59 ` Max Reitz
2017-03-29 20:32 ` Eric Blake
2017-03-29 20:35 ` Max Reitz
2017-03-30 7:47 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmsjfe6p.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mitake.hitoshi@lab.ntt.co.jp \
--cc=mreitz@redhat.com \
--cc=namei.unix@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.