From: Kyle Meyer <kyle@kyleam.com>
To: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/5] t1400: modernize style
Date: Tue, 21 Mar 2017 21:58:53 -0400 [thread overview]
Message-ID: <87bmsukr6q.fsf@kyleam.com> (raw)
In-Reply-To: <xmqq8tnysekm.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
> Jeff King <peff@peff.net> writes:
>
>> On Mon, Mar 20, 2017 at 08:56:11PM -0400, Kyle Meyer wrote:
[...]
>>> I also considered
>>>
>>> * making the quoting/spacing/breaks around the test descriptions and
>>> bodies more consistent, but I think this leads to too much code
>>> churn.
>>
>> I wouldn't mind the churn if you wanted to do it on top, but it's
>> definitely not necessary. There's nothing in 'pu' right now that touches
>> the file.
>
> Yes. But I do not mind (actually I do prefer) if that "on top" came
> as a separate follow-up after dust from these 5 settles ;-)
OK, I follow-up with that later. Thanks.
--
Kyle
next prev parent reply other threads:[~2017-03-22 1:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 0:56 [PATCH 0/5] t1400: modernize style Kyle Meyer
2017-03-21 0:56 ` [PATCH 1/5] t1400: rename test descriptions to be unique Kyle Meyer
2017-03-21 1:38 ` Jeff King
2017-03-21 0:56 ` [PATCH 2/5] t1400: set core.logAllRefUpdates in "logged by touch" tests Kyle Meyer
2017-03-21 1:49 ` Jeff King
2017-03-22 1:57 ` Kyle Meyer
2017-03-21 0:56 ` [PATCH 3/5] t1400: use test_path_is_* helpers Kyle Meyer
2017-03-21 1:51 ` Jeff King
2017-03-21 0:56 ` [PATCH 4/5] t1400: remove a set of unused output files Kyle Meyer
2017-03-21 1:51 ` Jeff King
2017-03-21 0:56 ` [PATCH 5/5] t1400: use test_when_finished for cleanup Kyle Meyer
2017-03-21 1:53 ` Jeff King
2017-03-21 2:01 ` [PATCH 0/5] t1400: modernize style Jeff King
2017-03-21 17:51 ` Junio C Hamano
2017-03-22 1:58 ` Kyle Meyer [this message]
2017-03-22 1:58 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmsukr6q.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.