From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder Date: Tue, 20 Dec 2016 12:08:49 +0200 Message-ID: <87bmw6oqtq.fsf@intel.com> References: <20161219123501.3750-1-ville.syrjala@linux.intel.com> <20161219123501.3750-5-ville.syrjala@linux.intel.com> <874m1zes9z.fsf@intel.com> <1482227203.5778.11.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3CFA56E92B for ; Tue, 20 Dec 2016 10:08:52 +0000 (UTC) In-Reply-To: <1482227203.5778.11.camel@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan De Oliveira , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMCBEZWMgMjAxNiwgQW5kZXIgQ29uc2VsdmFuIERlIE9saXZlaXJhIDxjb25zZWx2 YW4yQGdtYWlsLmNvbT4gd3JvdGU6Cj4gT24gTW9uLCAyMDE2LTEyLTE5IGF0IDE5OjM1ICswMjAw LCBKYW5pIE5pa3VsYSB3cm90ZToKPj4gT24gTW9uLCAxOSBEZWMgMjAxNiwgdmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20gd3JvdGU6Cj4+ID4gCj4+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPj4gPiAKPj4gPiBMZXQncyBjbGVhbiB1 cCB0aGUgbWVzcyB3ZSBoYXZlIGluIHRoZSBpZiBsYWRkZXIgdGhhdCBhc3NpZ25zIHRoZQo+PiA+ IC5nZXRfY2RjbGsoKSBob29rcy4gVGhlIGdyb3VwaW5nIG9mIHRoZSBwbGF0Zm9ybXMgYnkgdGhl IGZ1bmN0aW9uCj4+ID4gcmVzdWx0cyBpbiBhIHRoaW5nIHRoYXQncyBub3QgcmVhbGx5IGxlZ2li bGUsIHNvIGxldCdzIGRvIGl0IHRoZQo+PiA+IG90aGVyIHdheSBhcm91bmQgYW5kIG9yZGVyIHRo ZSBpZiBsYWRkZXIgYnkgcGxhdGZvcm0gYW5kIGR1cGxpY2F0ZQo+PiA+IHdoYXRldmVyIGFzc2ln bm1lbnRzIHdlIG5lZWQuCj4+ID4gCj4+ID4gVG8gZnVydGhlciBhdm9pZCBjb25mdXNpb24gd2l0 aCB0aGUgZnVuY3Rpb24gbmFtZXMgbGV0J3MgcmVuYW1lCj4+ID4gdGhlbSB0byBqdXN0IGZpeGVk XzxmcmVxPl9nZXRfY2RjbGsoKS4gVGhlIG90aGVyIG9wdGlvbiB3b3VsZAo+PiA+IGJlIHRvIGR1 cGxpY2F0ZSB0aGUgZnVuY3Rpb25zIGVudGlyZWx5IGJ1dCBpdCBzZWVtcyBxdWl0ZQo+PiA+IHBv aW50bGVzcyB0byBkbyB0aGF0IHNpbmNlIGVhY2ggb25lIGp1c3QgcmV0dXJucyBhIGZpeGVkIHZh bHVlLgo+PiA+IAo+PiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4+ID4gLS0tCj4+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMgfCA0MSArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tCj4+ ID4gLS0tLS0KPj4gPiDCoDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAxNyBkZWxl dGlvbnMoLSkKPj4gPiAKPj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK Pj4gPiBpbmRleCBiYmZlZjM0ODc4M2IuLjI5ZjkxZTc5OTI3MiAxMDA2NDQKPj4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gPiBAQCAtNzM3OSwyMiArNzM3OSwyMiBAQCBz dGF0aWMgaW50IHZhbGxleXZpZXdfZ2V0X2NkY2xrKHN0cnVjdAo+PiA+IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+PiA+IMKgCQkJCcKgwqDCoMKgwqDCoENDS19ESVNQTEFZX0NMT0NLX0NP TlRST0wpOwo+PiA+IMKgfQo+PiA+IMKgCj4+ID4gLXN0YXRpYyBpbnQgaWxrX2dldF9jZGNsayhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ID4gK3N0YXRpYyBpbnQgZml4ZWRf NDUwbWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ID4g wqB7Cj4+ID4gwqAJcmV0dXJuIDQ1MDAwMDsKPj4gPiDCoH0KPj4gPiDCoAo+PiA+IC1zdGF0aWMg aW50IGk5NDVfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4g PiArc3RhdGljIGludCBmaXhlZF80MDBtaHpfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdikKPj4gPiDCoHsKPj4gPiDCoAlyZXR1cm4gNDAwMDAwOwo+PiA+IMKgfQo+ PiA+IMKgCj4+ID4gLXN0YXRpYyBpbnQgaTkxNV9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+PiA+ICtzdGF0aWMgaW50IGZpeGVkXzMzM21oel9nZXRfY2RjbGso c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiA+IMKgewo+PiA+IMKgCXJldHVy biAzMzMzMzM7Cj4+ID4gwqB9Cj4+ID4gwqAKPj4gPiAtc3RhdGljIGludCBpOXh4X21pc2NfZ2V0 X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gPiArc3RhdGljIGlu dCBmaXhlZF8yMDBtaHpfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPj4gPiDCoHsKPj4gPiDCoAlyZXR1cm4gMjAwMDAwOwo+PiA+IMKgfQo+PiA+IEBAIC03NDQ0 LDcgKzc0NDQsNyBAQCBzdGF0aWMgaW50IGk5MTVnbV9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUKPj4gPiAqZGV2X3ByaXYpCj4+ID4gwqAJfQo+PiA+IMKgfQo+PiA+IMKgCj4+ID4g LXN0YXRpYyBpbnQgaTg2NV9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+PiA+ICtzdGF0aWMgaW50IGZpeGVkXzI2Nm1oel9nZXRfY2RjbGsoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiA+IMKgewo+PiA+IMKgCXJldHVybiAyNjY2Njc7Cj4+ ID4gwqB9Cj4+ID4gQEAgLTc0ODcsNyArNzQ4Nyw3IEBAIHN0YXRpYyBpbnQgaTg1eF9nZXRfY2Rj bGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPj4gPiAqZGV2X3ByaXYpCj4+ID4gwqAJcmV0dXJu IDA7Cj4+ID4gwqB9Cj4+ID4gwqAKPj4gPiAtc3RhdGljIGludCBpODMwX2dldF9jZGNsayhzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ID4gK3N0YXRpYyBpbnQgZml4ZWRfMTMz bWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ID4gwqB7 Cj4+ID4gwqAJcmV0dXJuIDEzMzMzMzsKPj4gPiDCoH0KPj4gPiBAQCAtMTYwOTgsMzIgKzE2MDk4 LDM5IEBAIHZvaWQgaW50ZWxfaW5pdF9kaXNwbGF5X2hvb2tzKHN0cnVjdAo+PiA+IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+PiA+IMKgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsg PSBoYXN3ZWxsX2dldF9jZGNsazsKPj4gPiDCoAllbHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9w cml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2KSkKPj4gPiDCoAkJZGV2X3ByaXYtPmRpc3Bs YXkuZ2V0X2NkY2xrID0gdmFsbGV5dmlld19nZXRfY2RjbGs7Cj4+ID4gKwllbHNlIGlmIChJU19H RU42KGRldl9wcml2KSB8fCBJU19JVllCUklER0UoZGV2X3ByaXYpKQo+PiA+ICsJCWRldl9wcml2 LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzQwMG1oel9nZXRfY2RjbGs7Cj4+ID4gwqAJZWxz ZSBpZiAoSVNfR0VONShkZXZfcHJpdikpCj4+ID4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2Nk Y2xrID0gaWxrX2dldF9jZGNsazsKPj4gPiAtCWVsc2UgaWYgKElTX0k5NDVHKGRldl9wcml2KSB8 fCBJU19JOTY1RyhkZXZfcHJpdikgfHwKPj4gPiAtCQnCoElTX0dFTjYoZGV2X3ByaXYpIHx8IElT X0lWWUJSSURHRShkZXZfcHJpdikpCj4+ID4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xr ID0gaTk0NV9nZXRfY2RjbGs7Cj4+ID4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0g Zml4ZWRfNDUwbWh6X2dldF9jZGNsazsKPj4gPiDCoAllbHNlIGlmIChJU19HTTQ1KGRldl9wcml2 KSkKPj4gPiDCoAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZ200NV9nZXRfY2RjbGs7 Cj4+ID4gKwllbHNlIGlmIChJU19HNFgoZGV2X3ByaXYpKQo+PiA+ICsJCWRldl9wcml2LT5kaXNw bGF5LmdldF9jZGNsayA9IGczM19nZXRfY2RjbGs7Cj4+ID4gwqAJZWxzZSBpZiAoSVNfSTk2NUdN KGRldl9wcml2KSkKPj4gPiDCoAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gaTk2NWdt X2dldF9jZGNsazsKPj4gPiArCWVsc2UgaWYgKElTX0k5NjVHKGRldl9wcml2KSkKPj4gPiArCQlk ZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBmaXhlZF80MDBtaHpfZ2V0X2NkY2xrOwo+PiA+ IMKgCWVsc2UgaWYgKElTX1BJTkVWSUVXKGRldl9wcml2KSkKPj4gPiDCoAkJZGV2X3ByaXYtPmRp c3BsYXkuZ2V0X2NkY2xrID0gcG52X2dldF9jZGNsazsKPj4gPiAtCWVsc2UgaWYgKElTX0czMyhk ZXZfcHJpdikgfHwgSVNfRzRYKGRldl9wcml2KSkKPj4gPiArCWVsc2UgaWYgKElTX0czMyhkZXZf cHJpdikpCj4+ID4gwqAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGczM19nZXRfY2Rj bGs7Cj4+ID4gLQllbHNlIGlmIChJU19JOTE1RyhkZXZfcHJpdikpCj4+ID4gLQkJZGV2X3ByaXYt PmRpc3BsYXkuZ2V0X2NkY2xrID0gaTkxNV9nZXRfY2RjbGs7Cj4+ID4gLQllbHNlIGlmIChJU19J OTQ1R00oZGV2X3ByaXYpIHx8IElTX0k4NDVHKGRldl9wcml2KSkKPj4gPiAtCQlkZXZfcHJpdi0+ ZGlzcGxheS5nZXRfY2RjbGsgPSBpOXh4X21pc2NfZ2V0X2NkY2xrOwo+PiA+ICsJZWxzZSBpZiAo SVNfSTk0NUdNKGRldl9wcml2KSkKPj4gPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsg PSBmaXhlZF8yMDBtaHpfZ2V0X2NkY2xrOwo+PiA+ICsJZWxzZSBpZiAoSVNfSTk0NUcoZGV2X3By aXYpKQo+PiA+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzQwMG1oel9n ZXRfY2RjbGs7Cj4+ID4gwqAJZWxzZSBpZiAoSVNfSTkxNUdNKGRldl9wcml2KSkKPj4gPiDCoAkJ ZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gaTkxNWdtX2dldF9jZGNsazsKPj4gPiArCWVs c2UgaWYgKElTX0k5MTVHKGRldl9wcml2KSkKPj4gPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRf Y2RjbGsgPSBmaXhlZF8zMzNtaHpfZ2V0X2NkY2xrOwo+PiA+IMKgCWVsc2UgaWYgKElTX0k4NjVH KGRldl9wcml2KSkKPj4gPiAtCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpODY1X2dl dF9jZGNsazsKPj4gPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBmaXhlZF8yNjZt aHpfZ2V0X2NkY2xrOwo+PiA+IMKgCWVsc2UgaWYgKElTX0k4NVgoZGV2X3ByaXYpKQo+PiA+IMKg CQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpODV4X2dldF9jZGNsazsKPj4gPiArCWVs c2XCoMKgaWYgKElTX0k4NDVHKGRldl9wcml2KSkKPj4gPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5n ZXRfY2RjbGsgPSBmaXhlZF8yMDBtaHpfZ2V0X2NkY2xrOwo+PiA+IMKgCWVsc2UgeyAvKiA4MzAg Ki8KPj4gPiDCoAkJV0FSTighSVNfSTgzMChkZXZfcHJpdiksICJVbmtub3duIHBsYXRmb3JtLiBB c3N1bWluZyAxMzMKPj4gPiBNSHogQ0RDTEtcbiIpOwo+PiA+IC0JCWRldl9wcml2LT5kaXNwbGF5 LmdldF9jZGNsayA9IGk4MzBfZ2V0X2NkY2xrOwo+PiA+ICsJCWRldl9wcml2LT5kaXNwbGF5Lmdl dF9jZGNsayA9IGZpeGVkXzEzM21oel9nZXRfY2RjbGs7Cj4+ID4gwqAJfQo+PiBJIHdvbmRlciBp ZiAic3dpdGNoIChkZXZfcHJpdi0+aW5mby5wbGF0Zm9ybSkiIGlzIGEgdmlhYmxlIGFsdGVybmF0 aXZlCj4+IHRvIHNvbWUgb2YgdGhlIHdvcnN0IGlmIGxhZGRlcnMgd2UgaGF2ZSwgbGlrZSB0aGlz IG9uZS4KPgo+IEhvdyBhYm91dCBzb21ldGhpbmcgbGlrZSB0aGlzPwoKSSBsaWtlIHRoaXMsIGJ1 dCBwcm9iYWJseSB0b28gaW50cnVzaXZlIHRvIGFzayBWaWxsZSB0byBwdXQgdGhpcyBpbgptaWQt c2VyaWVzLiBBIHVzZWZ1bCBjbGVhbnVwIGFmdGVyd2FyZHM/CgpCUiwKSmFuaS4KCgo+Cj4gc3Ry dWN0IGNkY2xrX2lmYWNlIHsKPiAJaW50ICgqZ2V0KSguLi4pOwo+IAl2b2lkICgqc2V0KSguLi4p Owo+IAlpbnQgKCpjYWxjKSguLi4pOwo+Cj4gCWludCBmaXhlZDsKPiB9Owo+Cj4gc3RhdGljIGlu dCBmaXhlZF9jZGNsa19nZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+IHsK PiAJcmV0dXJuIElOVEVMX0lORk8oZGV2X3ByaXYpLT5jZGNsay5maXhlZDsKPiB9Cj4KPiAjZGVm aW5lIEZJWEVEX0NEQ0xLKHZhbHVlKQlcCj4gCXsgLmdldCA9IGZpeGVkX2NkY2xrX2dldCwgLmZp eGVkID0gdmFsdWUgfQo+Cj4gc3RydWN0IGNkY2xrX2lmYWNlIHNrbF9jZGNsayA9IHsKPiAJLmdl dCA9IHNrbF9nZXRfY2RjbGssCj4gCS5zZXQgPSBza2xfc2V0X2NkY2xrLAo+IAkuY2FsYyA9IHNr bF9nZXRfY2RjbGssCj4gfTsKPgo+IC4uLgo+Cj4gQW5kIHRoZW4gaW4gZGV2aWNlIGluZm8gd2Ug anVzdCBkbyBlaXRoZXIKPgo+IMKgIC5jZGNsayA9IEZJWEVEX0NEQ0xLKHZhbHVlKSwKPgo+IG9y wqAKPgo+IMKgIC5jZGNsayA9IHNrbF9jZGNsaywKPgo+IEFuZGVyCj4KPj4gCj4+IEJSLAo+PiBK YW5pLgo+PiAKPj4gCj4+ID4gCj4+ID4gwqAKPj4gPiDCoAlpZiAoSVNfR0VONShkZXZfcHJpdikp IHsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==