From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: tune down the fast link training vs boot fail Date: Wed, 14 Dec 2016 16:56:33 +0200 Message-ID: <87bmwer23i.fsf@intel.com> References: <20161213195414.28923-1-daniel.vetter@ffwll.ch> <20161213202305.GQ31595@intel.com> <20161213223722.xxgheqytlrvsi36d@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 83F696E82D for ; Wed, 14 Dec 2016 14:56:37 +0000 (UTC) In-Reply-To: <20161213223722.xxgheqytlrvsi36d@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Daniel Vetter , Intel Graphics Development , Linus Torvalds , stable@vger.kernel.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxNCBEZWMgMjAxNiwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBUdWUsIERlYyAxMywgMjAxNiBhdCAxMDoyMzowNVBNICswMjAwLCBWaWxsZSBTeXJq w6Rsw6Qgd3JvdGU6Cj4+IE9uIFR1ZSwgRGVjIDEzLCAyMDE2IGF0IDA4OjU0OjE0UE0gKzAxMDAs IERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+ID4gSXQncyBiZWVuIHVuZml4ZWQgc2luY2UgYSB3aGls ZSBhbmQgbm8gb25lIGlzIGltbWVkaWF0ZWx5IHdvcmtpbmcgb24KPj4gPiB0aGlzLiBBbmQgd2Ug aGF2ZSB0aGUgRklYTUUgYWxyZWFkeS4gQW5kIG5vdyBhbHNvIGEgdGFzayBpbiB0aGUgRFAKPj4g PiB0ZWFtJ3MgYmFja2xvZy4KPj4gPiAKPj4gPiBDYzogTGludXMgVG9ydmFsZHMgPHRvcnZhbGRz QGxpbnV4LWZvdW5kYXRpb24ub3JnPgo+PiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4+ ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4+ ID4gUmVmZXJlbmNlczogaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvaW50 ZWwtZ2Z4LzIwMTYtSnVseS8xMDE5NTEuaHRtbAo+PiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBW ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+PiA+IC0tLQo+PiA+IEhpIExpbnVzLAo+ PiA+IAo+PiA+IEZlZWwgZnJlZSB0byBhcHBseSBkaXJlY3RseSBpbiBjYXNlIGl0IGFubm95cyB0 b28gbXVjaCBhbmQgeW91IGRvbid0Cj4+ID4gd2FudCB0byB3YWl0IGZvciB5b3VyIHByZXNlbnRz IDstKQo+PiA+IAo+PiA+IENoZWVycywgRGFuaWVsCj4+ID4gLS0tCj4+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMgfCA0ICsrLS0KPj4gPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4gPiAKPj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMKPj4gPiBpbmRleCBkYjc1YmI5MjRlNDguLjZlODc1ZDQyNjQyYSAxMDA2NDQKPj4gPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHAuYwo+PiA+IEBAIC00MDE0LDggKzQwMTQsOCBAQCBpbnRlbF9kcF9j aGVja19saW5rX3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+PiA+ICAJCXJldHVy bjsKPj4gPiAgCj4+ID4gIAkvKiBGSVhNRTogd2UgbmVlZCB0byBzeW5jaHJvbml6ZSB0aGlzIHNv cnQgb2Ygc3R1ZmYgd2l0aCBoYXJkd2FyZQo+PiA+IC0JICogcmVhZG91dCAqLwo+PiA+IC0JaWYg KFdBUk5fT05fT05DRSghaW50ZWxfZHAtPmxhbmVfY291bnQpKQo+PiA+ICsJICogcmVhZG91dC4g Q3VycmVudGx5IGZhc3QgbGluayB0cmFpbmluZyBkb2Vzbid0IHdvcmsgb24gYm9vdC11cC4gKi8K Pj4gCj4+IHMvZmFzdCBsaW5rIHRyYWluaW5nL2xpbmsgcmV0cmFpbmluZy8gaXMgd2hhdCBJJ2Qg cHV0IHRoZXJlLgo+Cj4gQWRqdXN0ZWQgLi4uCj4+IAo+PiBJJ20gYSBiaXQgc2FkIHRvIGhpZGUg aXQgYnV0IGRvZXNuJ3QgbG9vayBsaWtlIHRoZSBwcm9wZXIgc29sdXRpb24gaXMKPj4gZ29pbmcg dG8gaGFwcGVuIGFueSB0aW1lIHNvb24uCj4+IAo+PiBBY2tlZC1ieTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPgo+IC4uLiBhbmQgbWVyZ2VkIHNpbmNl IENJIHNlZW1zIHRvIGFwcHJvdmUgdG9vIDstKQoKKnNpZ2gqIHlvdSBjb3VsZCd2ZSBhZGRlZCBk ZWJ1ZyBsb2dnaW5nIGF0IGxlYXN0LiBOb3cgaXQncyBwcmV0dHkgbXVjaApndWFyYW50ZWVkIG5v Ym9keSB3aWxsIGxvb2sgYXQgdGhpcy4gSXQncyBub3QgcmlnaHQgdG8gZW5kIHVwIGhlcmUKd2l0 aG91dCBsaW5rIHBhcmFtcy4gOigKCkJSLApKYW5pLgoKCj4gLURhbmllbAo+Cj4+IAo+Cj4+ID4g KwlpZiAoIWludGVsX2RwLT5sYW5lX2NvdW50KQo+PiA+ICAJCXJldHVybjsKPj4gPiAgCj4+ID4g IAkvKiBpZiBsaW5rIHRyYWluaW5nIGlzIHJlcXVlc3RlZCB3ZSBzaG91bGQgcGVyZm9ybSBpdCBh bHdheXMgKi8KPj4gPiAtLSAKPj4gPiAyLjExLjAKPj4gCj4+IC0tIAo+PiBWaWxsZSBTeXJqw6Rs w6QKPj4gSW50ZWwgT1RDCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hu b2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:59867 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756225AbcLNO4k (ORCPT ); Wed, 14 Dec 2016 09:56:40 -0500 From: Jani Nikula To: Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Daniel Vetter , Intel Graphics Development , Linus Torvalds , stable@vger.kernel.org, Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] drm/i915: tune down the fast link training vs boot fail In-Reply-To: <20161213223722.xxgheqytlrvsi36d@phenom.ffwll.local> References: <20161213195414.28923-1-daniel.vetter@ffwll.ch> <20161213202305.GQ31595@intel.com> <20161213223722.xxgheqytlrvsi36d@phenom.ffwll.local> Date: Wed, 14 Dec 2016 16:56:33 +0200 Message-ID: <87bmwer23i.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: On Wed, 14 Dec 2016, Daniel Vetter wrote: > On Tue, Dec 13, 2016 at 10:23:05PM +0200, Ville Syrjälä wrote: >> On Tue, Dec 13, 2016 at 08:54:14PM +0100, Daniel Vetter wrote: >> > It's been unfixed since a while and no one is immediately working on >> > this. And we have the FIXME already. And now also a task in the DP >> > team's backlog. >> > >> > Cc: Linus Torvalds >> > Cc: stable@vger.kernel.org >> > Cc: Ville Syrjälä >> > References: https://lists.freedesktop.org/archives/intel-gfx/2016-July/101951.html >> > Signed-off-by: Daniel Vetter >> > --- >> > Hi Linus, >> > >> > Feel free to apply directly in case it annoys too much and you don't >> > want to wait for your presents ;-) >> > >> > Cheers, Daniel >> > --- >> > drivers/gpu/drm/i915/intel_dp.c | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c >> > index db75bb924e48..6e875d42642a 100644 >> > --- a/drivers/gpu/drm/i915/intel_dp.c >> > +++ b/drivers/gpu/drm/i915/intel_dp.c >> > @@ -4014,8 +4014,8 @@ intel_dp_check_link_status(struct intel_dp *intel_dp) >> > return; >> > >> > /* FIXME: we need to synchronize this sort of stuff with hardware >> > - * readout */ >> > - if (WARN_ON_ONCE(!intel_dp->lane_count)) >> > + * readout. Currently fast link training doesn't work on boot-up. */ >> >> s/fast link training/link retraining/ is what I'd put there. > > Adjusted ... >> >> I'm a bit sad to hide it but doesn't look like the proper solution is >> going to happen any time soon. >> >> Acked-by: Ville Syrjälä > > ... and merged since CI seems to approve too ;-) *sigh* you could've added debug logging at least. Now it's pretty much guaranteed nobody will look at this. It's not right to end up here without link params. :( BR, Jani. > -Daniel > >> > >> > + if (!intel_dp->lane_count) >> > return; >> > >> > /* if link training is requested we should perform it always */ >> > -- >> > 2.11.0 >> >> -- >> Ville Syrjälä >> Intel OTC -- Jani Nikula, Intel Open Source Technology Center