From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valo, Kalle Date: Tue, 15 Nov 2016 14:49:16 +0000 Subject: [ath9k-devel] [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table. In-Reply-To: <8d77a285e16cdd9f3b79c9e8d8800d72@vittgam.net> (Vittorio Gambaletta's message of "Fri, 14 Oct 2016 11:49:40 +0200") References: <87k2dop15n.fsf@kamboji.qca.qualcomm.com> <87eg3lg07d.fsf@kamboji.qca.qualcomm.com> <6ae887d799b201d78b4474ab9bbf6917@vittgam.net> <877f9dehn0.fsf@kamboji.qca.qualcomm.com> <8d77a285e16cdd9f3b79c9e8d8800d72@vittgam.net> Message-ID: <87bmxgpzmc.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org "Vittorio Gambaletta (VittGam)" writes: > Hello, > > On 12/10/2016 17:01:08 CEST, Valo, Kalle wrote: > >> So to tell the full story I'll change the commit log to something like >> below. Does it look ok to you? > > Yes; but I'd change "So" to "This turned out to be wrong", and add a note > about changing the order for 0x002A too: > > ---------------------------------------------------------------------- > ath9k: Really fix LED polarity for some Mini PCI AR9220 MB92 cards. > > The active_high LED of my Wistron DNMA-92 is still being recognized as > active_low on 4.7.6 mainline. When I was preparing my former commit > 0f9edcdd88a9 ("ath9k: Fix LED polarity for some Mini PCI AR9220 MB92 > cards.") to fix that I must have somehow messed up with testing, because > I tested the final version of that patch before sending it, and it was > apparently working; but now it is not working on 4.7.6 mainline. > > I initially added the PCI_DEVICE_SUB section for 0x0029/0x2096 above the > PCI_VDEVICE section for 0x0029; but then I moved the former below the > latter after seeing how 0x002A sections were sorted in the file. > > This turned out to be wrong: if a generic PCI_VDEVICE entry (that has > both subvendor and subdevice IDs set to PCI_ANY_ID) is put before a more > specific one (PCI_DEVICE_SUB), then the generic PCI_VDEVICE entry will > match first and will be used. > > With this patch, 0x0029/0x2096 has finally got active_high LED on 4.7.6. > > While I'm at it, let's fix 0x002A too by also moving its generic definition > below its specific ones. > > Fixes: 0f9edcdd88a9 ("ath9k: Fix LED polarity for some Mini PCI AR9220 MB92 cards.") > Cc: #4.7+ > Signed-off-by: Vittorio Gambaletta > [kvalo at qca.qualcomm.com: improve the commit log based on email discussions] > Signed-off-by: Kalle Valo > ---------------------------------------------------------------------- Thanks, I updated the commit with your changes. -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:40120 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933371AbcKOOtW (ORCPT ); Tue, 15 Nov 2016 09:49:22 -0500 From: "Valo, Kalle" To: "Vittorio Gambaletta (VittGam)" CC: "linux-wireless@vger.kernel.org" , ath9k-devel , "ath9k-devel@venema.h4ckr.net" , "stable@vger.kernel.org" Subject: Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table. Date: Tue, 15 Nov 2016 14:49:16 +0000 Message-ID: <87bmxgpzmc.fsf@kamboji.qca.qualcomm.com> (sfid-20161115_154925_763114_40F2F8E7) References: <87k2dop15n.fsf@kamboji.qca.qualcomm.com> <87eg3lg07d.fsf@kamboji.qca.qualcomm.com> <6ae887d799b201d78b4474ab9bbf6917@vittgam.net> <877f9dehn0.fsf@kamboji.qca.qualcomm.com> <8d77a285e16cdd9f3b79c9e8d8800d72@vittgam.net> In-Reply-To: <8d77a285e16cdd9f3b79c9e8d8800d72@vittgam.net> (Vittorio Gambaletta's message of "Fri, 14 Oct 2016 11:49:40 +0200") Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: "Vittorio Gambaletta (VittGam)" writes: > Hello, > > On 12/10/2016 17:01:08 CEST, Valo, Kalle wrote: > >> So to tell the full story I'll change the commit log to something like >> below. Does it look ok to you? > > Yes; but I'd change "So" to "This turned out to be wrong", and add a note > about changing the order for 0x002A too: > > ---------------------------------------------------------------------- > ath9k: Really fix LED polarity for some Mini PCI AR9220 MB92 cards. > > The active_high LED of my Wistron DNMA-92 is still being recognized as > active_low on 4.7.6 mainline. When I was preparing my former commit > 0f9edcdd88a9 ("ath9k: Fix LED polarity for some Mini PCI AR9220 MB92 > cards.") to fix that I must have somehow messed up with testing, because > I tested the final version of that patch before sending it, and it was > apparently working; but now it is not working on 4.7.6 mainline. > > I initially added the PCI_DEVICE_SUB section for 0x0029/0x2096 above the > PCI_VDEVICE section for 0x0029; but then I moved the former below the > latter after seeing how 0x002A sections were sorted in the file. > > This turned out to be wrong: if a generic PCI_VDEVICE entry (that has > both subvendor and subdevice IDs set to PCI_ANY_ID) is put before a more > specific one (PCI_DEVICE_SUB), then the generic PCI_VDEVICE entry will > match first and will be used. > > With this patch, 0x0029/0x2096 has finally got active_high LED on 4.7.6. > > While I'm at it, let's fix 0x002A too by also moving its generic definiti= on > below its specific ones. > > Fixes: 0f9edcdd88a9 ("ath9k: Fix LED polarity for some Mini PCI AR9220 MB= 92 cards.") > Cc: #4.7+ > Signed-off-by: Vittorio Gambaletta > [kvalo@qca.qualcomm.com: improve the commit log based on email discussion= s] > Signed-off-by: Kalle Valo > ---------------------------------------------------------------------- Thanks, I updated the commit with your changes. --=20 Kalle Valo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:40120 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933371AbcKOOtW (ORCPT ); Tue, 15 Nov 2016 09:49:22 -0500 From: "Valo, Kalle" To: "Vittorio Gambaletta (VittGam)" CC: "linux-wireless@vger.kernel.org" , ath9k-devel , "ath9k-devel@venema.h4ckr.net" , "stable@vger.kernel.org" Subject: Re: [PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table. Date: Tue, 15 Nov 2016 14:49:16 +0000 Message-ID: <87bmxgpzmc.fsf@kamboji.qca.qualcomm.com> References: <87k2dop15n.fsf@kamboji.qca.qualcomm.com> <87eg3lg07d.fsf@kamboji.qca.qualcomm.com> <6ae887d799b201d78b4474ab9bbf6917@vittgam.net> <877f9dehn0.fsf@kamboji.qca.qualcomm.com> <8d77a285e16cdd9f3b79c9e8d8800d72@vittgam.net> In-Reply-To: <8d77a285e16cdd9f3b79c9e8d8800d72@vittgam.net> (Vittorio Gambaletta's message of "Fri, 14 Oct 2016 11:49:40 +0200") Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <5082A684796FA64EB61D70C418A60FF2@qualcomm.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: "Vittorio Gambaletta (VittGam)" writes: > Hello, > > On 12/10/2016 17:01:08 CEST, Valo, Kalle wrote: > >> So to tell the full story I'll change the commit log to something like >> below. Does it look ok to you? > > Yes; but I'd change "So" to "This turned out to be wrong", and add a note > about changing the order for 0x002A too: > > ---------------------------------------------------------------------- > ath9k: Really fix LED polarity for some Mini PCI AR9220 MB92 cards. > > The active_high LED of my Wistron DNMA-92 is still being recognized as > active_low on 4.7.6 mainline. When I was preparing my former commit > 0f9edcdd88a9 ("ath9k: Fix LED polarity for some Mini PCI AR9220 MB92 > cards.") to fix that I must have somehow messed up with testing, because > I tested the final version of that patch before sending it, and it was > apparently working; but now it is not working on 4.7.6 mainline. > > I initially added the PCI_DEVICE_SUB section for 0x0029/0x2096 above the > PCI_VDEVICE section for 0x0029; but then I moved the former below the > latter after seeing how 0x002A sections were sorted in the file. > > This turned out to be wrong: if a generic PCI_VDEVICE entry (that has > both subvendor and subdevice IDs set to PCI_ANY_ID) is put before a more > specific one (PCI_DEVICE_SUB), then the generic PCI_VDEVICE entry will > match first and will be used. > > With this patch, 0x0029/0x2096 has finally got active_high LED on 4.7.6. > > While I'm at it, let's fix 0x002A too by also moving its generic definiti= on > below its specific ones. > > Fixes: 0f9edcdd88a9 ("ath9k: Fix LED polarity for some Mini PCI AR9220 MB= 92 cards.") > Cc: #4.7+ > Signed-off-by: Vittorio Gambaletta > [kvalo@qca.qualcomm.com: improve the commit log based on email discussion= s] > Signed-off-by: Kalle Valo > ---------------------------------------------------------------------- Thanks, I updated the commit with your changes. --=20 Kalle Valo=