From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"hofrat@osadl.org" <hofrat@osadl.org>,
"xypron.glpk@gmx.de" <xypron.glpk@gmx.de>,
"prameela.garnepudi@redpinesignals.com"
<prameela.garnepudi@redpinesignals.com>
Subject: Re: [PATCH] rsi: update in vap_capabilities frame to device
Date: Wed, 12 Oct 2016 14:39:33 +0000 [thread overview]
Message-ID: <87bmypeimz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <87k2ddej46.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Wed, 12 Oct 2016 17:29:13 +0300")
Kalle Valo <kvalo@codeaurora.org> writes:
> Prameela Rani Garnepudi <prameela.j04cs@gmail.com> writes:
>
>> added vap status(add/delete) field in vap capabilities frame to device
>> added sending vap capabilites frame(with vap status 'delete') in remove =
interface
>>
>> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
>
> Why? How is this better now? I'm sure there is a good reason why you add
> this but we don't know as the commit tells nothing we don't already know
> just from looking at the patch.
>
> The most important part of commit log is to answer the question "Why?",
> not "What?".
Oh, and USE capitalisation, punctuation and so on in the commit log. It
will be archived to git.
--=20
Kalle Valo=
prev parent reply other threads:[~2016-10-12 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 10:33 [PATCH] rsi: update in vap_capabilities frame to device Prameela Rani Garnepudi
2016-10-12 14:29 ` Kalle Valo
2016-10-12 14:39 ` Valo, Kalle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmypeimz.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=hofrat@osadl.org \
--cc=linux-wireless@vger.kernel.org \
--cc=prameela.garnepudi@redpinesignals.com \
--cc=prameela.j04cs@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.