From: Felipe Balbi <balbi@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Question about suspend/resume clock handling in dwc3-of-simple.c
Date: Tue, 13 Sep 2016 08:35:16 +0300 [thread overview]
Message-ID: <87bmzsl5uz.fsf@linux.intel.com> (raw)
In-Reply-To: <20160912194349.GA14284@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
Hi,
Guenter Roeck <linux@roeck-us.net> writes:
>> > Should it be clk_disable_unprepare(), or maybe something like the
>> > following
>> >
>> > if (!pm_runtime_status_suspended(dev))
>> > clk_disable_unprepare();
>> > else
>> > clk_unprepare();
>>
>> I'm not sure how balanced those calls are, yeah. I don't have HW to test
>> PM with. But note that as it is, there is no actual runtime PM support,
>> so clk_disable_unprepare() will always be necessary.
>>
>> Perhaps we will find further issues when someone tries to use runtime PM
>> with dwc3-of-simple. ;-)
>>
>
> We are working on code derived from it, so unless I can convince the author
> that he can not just use clk_unprepare() I suspect we'll hit the problem.
> If so, I'll let you know.
Are you sending that upstream? Depending on your requirements, it might
be easier to patch dwc3-of-simple.c then adding yet another glue layer :-)
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-09-13 5:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 18:56 Question about suspend/resume clock handling in dwc3-of-simple.c Guenter Roeck
2016-09-12 19:05 ` Felipe Balbi
2016-09-12 19:43 ` Guenter Roeck
2016-09-13 5:35 ` Felipe Balbi [this message]
2016-09-13 13:10 ` Guenter Roeck
2016-09-13 14:05 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmzsl5uz.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.