From: Dmitry Monakhov <dmonakhov@openvz.org>
To: xfs@oss.sgi.com
Cc: billodo@redhat.com
Subject: Re: [PATCH] PING... mkfs.xfs: fix static-lib build
Date: Fri, 19 Aug 2016 12:44:07 +0300 [thread overview]
Message-ID: <87bn0p6ql4.fsf@openvz.org> (raw)
In-Reply-To: <1470907976-2362-1-git-send-email-dmonakhov@openvz.org>
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
I'm just want to double check that this list is still alive, and
not yet moved some where XXX-xfs@kernel.org :)
Fellows, please take a look at the patch. This fix static build for
mkfs.xfs and break xfstests-bld build.
[-- Attachment #2.1: Type: text/plain, Size: 1766 bytes --]
Dmitry Monakhov <dmonakhov@openvz.org> writes:
> Order is important for static libraries, libblkid depends on libuuid.
> We have to pass libuuid after libblkid, otherwise it fails like this:
> #make mkfs.xfs
> [LD] mkfs.xfs
> /bin/bash ../libtool --quiet --tag=CC --mode=link gcc -o mkfs.xfs -static -L/devel/xfstests-bld.git/bld/lib -static-libtool-libs maxtrres.o proto.o xfs_mkfs.o ../libxfs/libxfs.la ../libxcmd/libxcmd.la -luuid -lrt -lpthread -lblkid
> /devel/xfstests-bld.git/bld/lib/libblkid.a(probe.o): In function `set_uuid':
> /devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:132: undefined reference to `uuid_is_null'
> /devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:133: undefined reference to `uuid_unparse'
> /devel/xfstests-bld.git/bld/lib/libblkid.a(probe.o): In function `get_ext2_info':
> /devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:156: undefined reference to `uuid_is_null'
> collect2: error: ld returned 1 exit status
> ../include/buildrules:45: recipe for target 'mkfs.xfs' failed
> make: *** [mkfs.xfs] Error 1
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> mkfs/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/Makefile b/mkfs/Makefile
> index 170e3c1..c13b903 100644
> --- a/mkfs/Makefile
> +++ b/mkfs/Makefile
> @@ -10,7 +10,7 @@ LTCOMMAND = mkfs.xfs
> HFILES =
> CFILES = maxtrres.c proto.c xfs_mkfs.c
>
> -LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBUUID) $(LIBRT) $(LIBPTHREAD) $(LIBBLKID)
> +LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBRT) $(LIBPTHREAD) $(LIBBLKID) $(LIBUUID)
> LTDEPENDENCIES += $(LIBXFS) $(LIBXCMD)
> LLDFLAGS = -static-libtool-libs
>
> --
> 2.1.4
[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
[-- Attachment #3: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next parent reply other threads:[~2016-08-19 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1470907976-2362-1-git-send-email-dmonakhov@openvz.org>
2016-08-19 9:44 ` Dmitry Monakhov [this message]
2016-08-19 10:28 ` [PATCH] PING... mkfs.xfs: fix static-lib build Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn0p6ql4.fsf@openvz.org \
--to=dmonakhov@openvz.org \
--cc=billodo@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.