From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
David Weinehall <david.weinehall@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Revert "drm/i915: Check live status before reading edid"
Date: Wed, 17 Aug 2016 16:43:36 +0300 [thread overview]
Message-ID: <87bn0rtss7.fsf@intel.com> (raw)
In-Reply-To: <20160817130203.GM22696@nuc-i3427.alporthouse.com>
On Wed, 17 Aug 2016, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Wed, Aug 17, 2016 at 03:47:48PM +0300, David Weinehall wrote:
>> This reverts commit 237ed86c693d8a8e4db476976aeb30df4deac74b.
>>
>> Our current implementation of live status check (repeat 9 times
>> with 10ms delays between each attempt as a workaround for
>> buggy displays) imposes a rather serious penalty, time wise,
>> on intel_hdmi_detect(). Since we we already skip live status
>> checks on platforms before gen 7, and since we seem to have
>> coped quite well before the live status check was introduced
>> for newer platforms too, the previous behaviour is probably
>> preferable, at least unless someone can point to a use-case
>> that the live status check improves (apart from "Bspec says so".
>>
>> Signed-off-by: David Weinehall <david.weinehall@linux.intel.com>
>
> Fixes: 237ed86c693d ("drm/i915: Check live status before reading edid")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97139
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@vger.kernel.org
And we've come full circle on live status. Again.
References: https://upload.wikimedia.org/wikipedia/commons/3/3b/Paris_Tuileries_Garden_Facepalm_statue.jpg
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-17 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 12:47 [PATCH] Revert "drm/i915: Check live status before reading edid" David Weinehall
2016-08-17 13:02 ` Chris Wilson
2016-08-17 13:43 ` Jani Nikula [this message]
2016-08-18 7:29 ` David Weinehall
2016-08-19 11:31 ` David Weinehall
2016-09-07 11:56 ` Jani Nikula
2016-08-17 14:22 ` ✗ Ro.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn0rtss7.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=david.weinehall@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.