From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753190AbcGTINo (ORCPT ); Wed, 20 Jul 2016 04:13:44 -0400 Received: from mga14.intel.com ([192.55.52.115]:58677 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbcGTINl (ORCPT ); Wed, 20 Jul 2016 04:13:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,393,1464678000"; d="asc'?scan'208";a="849743909" From: Felipe Balbi To: Jim Lin Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, mathias.nyman@intel.com, Jim Lin Subject: Re: [PATCH 1/1] usb: xhci: Fix panic if disconnect In-Reply-To: <1469001701-5666-1-git-send-email-jilin@nvidia.com> References: <1469001701-5666-1-git-send-email-jilin@nvidia.com> User-Agent: Notmuch/0.22+58~g3a45d29 (https://notmuchmail.org) Emacs/25.0.95.2 (x86_64-pc-linux-gnu) Date: Wed, 20 Jul 2016 11:12:18 +0300 Message-ID: <87bn1sg23h.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Jim, Jim Lin writes: > After a device is disconnected, xhci_stop_device() will be invoked > in xhci_bus_suspend(). > Also the "disconnect" IRQ will have ISR to invoke > xhci_free_virt_device() in this sequence. > xhci_irq -> xhci_handle_event -> handle_cmd_completion -> > xhci_handle_cmd_disable_slot -> xhci_free_virt_device > > If xhci->devs[slot_id] has been assigned to NULL in > xhci_free_virt_device(), then virt_dev->eps[i].ring in > xhci_stop_device() may point to an invlid address to cause kernel > panic. > > virt_dev =3D xhci->devs[slot_id]; > : > if (virt_dev->eps[i].ring && virt_dev->eps[i].ring->dequeue) > > [] Unable to handle kernel paging request at virtual address 00001a68 > [] pgd=3Dffffffc001430000 > [] [00001a68] *pgd=3D000000013c807003, *pud=3D000000013c807003, > *pmd=3D000000013c808003, *pte=3D0000000000000000 > [] Internal error: Oops: 96000006 [#1] PREEMPT SMP > [] CPU: 0 PID: 39 Comm: kworker/0:1 Tainted: G U > [] Workqueue: pm pm_runtime_work > [] task: ffffffc0bc0e0bc0 ti: ffffffc0bc0ec000 task.ti: > ffffffc0bc0ec000 > [] PC is at xhci_stop_device.constprop.11+0xb4/0x1a4 > > This issue is found when running with realtek ethernet device > (0bda:8153). > > Signed-off-by: Jim Lin yes, I saw the previous version :-) So, we're pretty close to getting the merge window opened. This will defer to v4.8-rc1. Patch looks good, though. :-) thanks =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXjzJiAAoJEIaOsuA1yqREQ78QAI/jIMwdYvMCRA2dPJy2TcvV vnjSWi/xLRys8k/PYneX1tg/RlUnTCYmTIxO3kkog2vSLt3Y1opGfJ3GfeGJR6lv DP/JJrb9VGBCQhRijf8MS/Em90uVCXUW3jp2/soGezTOMlCxsm6AwFrUFE5BG1Iz 3uH79YLLNqFagyQlscZqaqqOsrIBo1nCwb0+z4r+zc+gbulFOlYKwhgkk+CxPr7y T5zvAvqDmZnrOz4+4Grm0xicJ+nXlrn9+HiAsA18iQBdQrg6afOBq0XB3IahKo+d 0tegzwAIs7ZZBH5ZTq13fAZPpsiXrrY7Dw5VJkcU7ZvKOvawMRaW1taVFg4mK3hX MVahFRtiXsoCS85brYXOKVghp2fNriNUa70I5Y+2irjnfzLnwqQJ0nHqs7s3GmOF FfAjLx80EpbdXuyJX8fICP4jW40jl9cfuXfJr5NyNk3hglRC7v6fp7DECsPorD15 cOqxXuVd3atZ/0wN43MZmCiA/FPy3baAOLAhXQm1inSbqMHMwrKxN/B83BcL2O1W YSaJMwSYCOwvsoNlkPH5Z+xffMRa8ZAcfU/OSr6p5qmQKNXavE8BTM5MuVVc5k4s Bn4qPVMoDPR611t27ny3RqvufHKaWTdh6udHdcmrVaIuDjjkyZVDBGUgTx1FKNaM Qhmo3honRnu8QISosN1E =TEDX -----END PGP SIGNATURE----- --=-=-=--