From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b02s2-0007Wq-9R for qemu-devel@nongnu.org; Tue, 10 May 2016 04:18:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b02rw-0007G5-2I for qemu-devel@nongnu.org; Tue, 10 May 2016 04:18:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b02rv-0007G0-SR for qemu-devel@nongnu.org; Tue, 10 May 2016 04:18:15 -0400 From: Markus Armbruster References: <1461879932-9020-18-git-send-email-eblake@redhat.com> <1462854006-24658-1-git-send-email-eblake@redhat.com> Date: Tue, 10 May 2016 10:18:12 +0200 In-Reply-To: <1462854006-24658-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Mon, 9 May 2016 22:20:06 -0600") Message-ID: <87bn4efhrv.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v16A 17/24] qmp: Don't reuse qmp visitor after grabbing output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Michael Roth Eric Blake writes: > The testsuite was the only client that attempted to reuse a > QmpOutputVisitor for a second visit after encountering an > error and/or calling qmp_output_get_qobject() on a first > visit. The next patch is about to tighten the semantics to > be one-shot usage of the visitor, like all other visitors > (which will enable further simplifications down the road). > > Signed-off-by: Eric Blake > --- > > This commit is designed to completely replace commit 51750617 > on Markus' qapi-next branch; all other patches in that series > remain unchanged and the testsuite still passes. Doing this > now will make it easier for my next series to introduce a > generalized visit_free(Visitor*) instead of our current > duplication of a per-subtype foo_visit_cleanup(FooVisitor*), > without having to revert the addition of qmp_output_visitor_reset(). Patch looks good to me. I massaged qapi-next as instructed. Thanks!