From: Kalle Valo <kvalo@codeaurora.org>
To: Ross Green <rgkernel@gmail.com>
Cc: Emil Goode <emil.fsw@goode.io>, Shahar Patury <shaharp@ti.com>,
Guy Mishol <guym@ti.com>, Igor Grinberg <grinberg@compulab.co.il>,
Uri Mashiach <uri.mashiach@compulab.co.il>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: wlcore: Fix regression in wlcore_set_partition()
Date: Tue, 16 Feb 2016 17:24:15 +0200 [thread overview]
Message-ID: <87bn7gu19c.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CANfgCY02_AkRi2EMNZsneK8UdwLvAWxF_X0ts6WZbaM0=5c63A@mail.gmail.com> (Ross Green's message of "Mon, 15 Feb 2016 15:01:49 +1100")
Ross Green <rgkernel@gmail.com> writes:
> On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>>
>>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
>>> regression causing the wlcore to time out and go into recovery. Reverting the
>>> changes regarding write of the last partition size brings the module back to
>>> it's functional state.
>>>
>>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
>>> Reported-by: Ross Green <rgkernel@gmail.com>
>>> Signed-off-by: Emil Goode <emil.fsw@goode.io>
>>> [kvalo@codeaurora.org: improved commit log]
>>
>> Thanks, applied to wireless-drivers.git.
>>
>> Kalle Valo
>
> I just tested linux-4.5-rc4 it appears the above fix missed the release for rc4!
> So the behaviour of firmware reset being called after the access of
> the last partition timesout.
>
> Again tested patch with the new release - 4.5-rc4 and found everything
> to work as expected again.
>
> So Hopefully for rc5 - Please!
It takes some time to get patches into Linus' tree. And being in a
conference and then getting sick is not really helping. I'm not sure if
this patch makes to rc5 on time, but I'll try.
--
Kalle Valo
next prev parent reply other threads:[~2016-02-16 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 1:22 [PATCH] wlcore: Fix regression in wlcore_set_partition() Emil Goode
2016-02-10 17:34 ` Kalle Valo
2016-02-12 9:45 ` Kalle Valo
2016-02-15 4:01 ` Ross Green
2016-02-16 15:24 ` Kalle Valo [this message]
2016-02-17 5:34 ` Ross Green
2016-02-24 5:40 ` Ross Green
2016-02-25 0:11 ` Emil Goode
2016-02-25 2:13 ` Ross Green
2016-02-25 4:56 ` Ross Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn7gu19c.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=emil.fsw@goode.io \
--cc=grinberg@compulab.co.il \
--cc=guym@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rgkernel@gmail.com \
--cc=shaharp@ti.com \
--cc=uri.mashiach@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.