From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com From: ebiederm@xmission.com (Eric W. Biederman) References: <1453502345-30416-1-git-send-email-keescook@chromium.org> <8737tp0zhr.fsf@x220.int.ebiederm.org> Date: Mon, 25 Jan 2016 13:33:49 -0600 In-Reply-To: (Kees Cook's message of "Mon, 25 Jan 2016 10:56:41 -0800") Message-ID: <87bn89sbc2.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain Subject: [kernel-hardening] Re: [PATCH 0/2] sysctl: allow CLONE_NEWUSER to be disabled To: Kees Cook Cc: Andy Lutomirski , Andrew Morton , Al Viro , Richard Weinberger , Robert =?utf-8?B?xZp3acSZY2tp?= , Dmitry Vyukov , David Howells , Miklos Szeredi , Kostya Serebryany , Alexander Potapenko , Eric Dumazet , Sasha Levin , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-hardening@lists.openwall.com" List-ID: Kees Cook writes: > > Well, I don't know about less weird, but it would leave a unneeded > hole in the permission checks. To be clear the current patch has my: Nacked-by: "Eric W. Biederman" The code is buggy, and poorly thought through. Your lack of interest in fixing the bugs in your patch is distressing. So broken code, not willing to fix. No. We are not merging this sysctl. Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934302AbcAYTve (ORCPT ); Mon, 25 Jan 2016 14:51:34 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:38777 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934228AbcAYTvb (ORCPT ); Mon, 25 Jan 2016 14:51:31 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Kees Cook Cc: Andy Lutomirski , Andrew Morton , Al Viro , Richard Weinberger , Robert =?utf-8?B?xZp3acSZY2tp?= , Dmitry Vyukov , David Howells , Miklos Szeredi , Kostya Serebryany , Alexander Potapenko , Eric Dumazet , Sasha Levin , "linux-doc\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "kernel-hardening\@lists.openwall.com" References: <1453502345-30416-1-git-send-email-keescook@chromium.org> <8737tp0zhr.fsf@x220.int.ebiederm.org> Date: Mon, 25 Jan 2016 13:33:49 -0600 In-Reply-To: (Kees Cook's message of "Mon, 25 Jan 2016 10:56:41 -0800") Message-ID: <87bn89sbc2.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-AID: U2FsdGVkX1/pRL1a9fEo3vZRPr56K3Xqj5d8/YdwNNs= X-SA-Exim-Connect-IP: 97.121.81.63 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4847] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa04 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Kees Cook X-Spam-Relay-Country: X-Spam-Timing: total 13381 ms - load_scoreonly_sql: 0.08 (0.0%), signal_user_changed: 5.0 (0.0%), b_tie_ro: 3.5 (0.0%), parse: 1.70 (0.0%), extract_message_metadata: 16 (0.1%), get_uri_detail_list: 0.72 (0.0%), tests_pri_-1000: 6 (0.0%), tests_pri_-950: 1.26 (0.0%), tests_pri_-900: 1.01 (0.0%), tests_pri_-400: 20 (0.1%), check_bayes: 18 (0.1%), b_tokenize: 5 (0.0%), b_tok_get_all: 5 (0.0%), b_comp_prob: 1.86 (0.0%), b_tok_touch_all: 3.2 (0.0%), b_finish: 0.91 (0.0%), tests_pri_0: 146 (1.1%), check_dkim_signature: 0.54 (0.0%), check_dkim_adsp: 4.2 (0.0%), tests_pri_500: 13181 (98.5%), poll_dns_idle: 13161 (98.4%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 0/2] sysctl: allow CLONE_NEWUSER to be disabled X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Wed, 24 Sep 2014 11:00:52 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees Cook writes: > > Well, I don't know about less weird, but it would leave a unneeded > hole in the permission checks. To be clear the current patch has my: Nacked-by: "Eric W. Biederman" The code is buggy, and poorly thought through. Your lack of interest in fixing the bugs in your patch is distressing. So broken code, not willing to fix. No. We are not merging this sysctl. Eric