From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDzX-0004Ww-8C for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:04:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHDzT-0004ih-0f for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:04:51 -0500 Received: from e28smtp02.in.ibm.com ([125.16.236.2]:35706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDzS-0004hn-BL for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:04:46 -0500 Received: from localhost by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Jan 2016 22:34:42 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id D4AD2125805C for ; Thu, 7 Jan 2016 22:35:22 +0530 (IST) Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay05.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u07H4QrD12517542 for ; Thu, 7 Jan 2016 22:34:28 +0530 Received: from d28av01.in.ibm.com (localhost [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u07H4OJC008728 for ; Thu, 7 Jan 2016 22:34:26 +0530 From: "Aneesh Kumar K.V" In-Reply-To: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com> References: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com> Date: Thu, 07 Jan 2016 22:34:13 +0530 Message-ID: <87bn8xqq2a.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 00/22] 9pfs: disentangling virtio and generic code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Liu , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Stefano Stabellini , Greg Kurz Wei Liu writes: > Hi all > > Back in 2015 summer one of our OPW interns Linda Jacobson explored the > possibility of making 9pfs work on Xen. It turned out lots of code in QEMU can > be reused. > > This series refactors 9pfs related code: > > 1. Rename a bunch of files and functions to make clear they are generic. > 2. Only export two functions (marshal and unmarshal) from transport to generic > code. > 3. disentangle virtio transport code and generic 9pfs code. > 4. Some function name clean-up. > > To make sure this series doesn't break compilation a rune is use to compile > every commit. > > $ git rebase -i origin/master --exec "make -j16 clean; ./configure --target-list=x86_64-softmmu --enable-virtfs --enable-kvm; make -j16 && echo ok." > > Three use cases are tested: > > 1. Local file system driver with passthrough security policy > ./qemu-system-x86_64 -L . -hda /dev/DATA/jessie -vnc 0.0.0.0:0,to=99 -fsdev local,path=/root/qemu,security_model=passthrough,id=fs1 -device virtio-9p-pci,fsdev=fs1,mount_tag=qemu & > > 2. Local file system driver with mapped security policy > ./qemu-system-x86_64 -L . -hda /dev/DATA/jessie -vnc 0.0.0.0:0,to=99 -fsdev local,path=/root/qemu,security_model=mapped,id=fs1 -device virtio-9p-pci,fsdev=fs1,mount_tag=qemu & > > 3. Proxy file system driver > ./virtfs-proxy-helper -p /root/qemu -n -s virtfs-helper-sock -u 0 -g 0 & > ./qemu-system-x86_64 -L . -hda /dev/DATA/jessie -vnc 0.0.0.0:0,to=99 -fsdev proxy,socket=virtfs-helper-sock,id=fs1 -device virtio-9p-pci,fsdev=fs1,mount_tag=qemu & > > During each of the tests, mounting, unmounting, read and write operations are > performed. In "mapped" test, getfattr in host was used to inspect the > attributes. > > Let me know if you would like to see more tests. you can also try this http://www.tuxera.com/community/posix-test-suite/ with the xen transport. Are you looking at getting this merged before the xen transport is done or are we expecting further changes to this as you make progress with Xen transport ? W.r.t posix test suite with upstream we have one expected failure in the acl test. You can ignore that. I will also try to get some test run going here. > > Xen transport is still under development. I figure it would be better to post > this series as soon as possible because rebasing such huge series from time to > time is prone to error. > > Comments are welcome. Thanks! Good series with some nice cleanups. -aneesh